Jonathan Druart
a70980d825
To recreate: /cgi-bin/koha/patroncards/edit-template.pl?op=edit&element_id=23%20and%201%3d2+union+all+select+1,user(),@@version+--%20 Look at the Profile dropdown list. To fix this problem and to make sure it does not appears anywhere else in the label and patroncards modules, I have refactored the way the queries are built in C4::Creators::Lib Now all of the subroutine takes a hashref in parameters with a 'fields' and 'filters' parameters. From these 2 parameters the new internal subroutine _build_query will build the query and use placeholders. Test plan: 1/ Make sure you do not recreate the vulnerability with this patch applied. 2/ With decent data in the labels and patroncards modules, compare all the different view (undef the New and Manage button groups) with and without this patch applied. => You should not see any differences. This vulnerability has been reported by MDSec. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
134 lines
5.6 KiB
Perl
Executable file
134 lines
5.6 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
#
|
|
# Copyright 2009 Foundations Bible College.
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use Data::Dumper;
|
|
|
|
use C4::Auth qw(get_template_and_user);
|
|
use C4::Output qw(output_html_with_http_headers);
|
|
use C4::Creators::Lib qw(get_all_templates get_all_layouts get_output_formats);
|
|
use C4::Labels::Batch;
|
|
|
|
my $cgi = new CGI;
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "labels/label-print.tt",
|
|
query => $cgi,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { catalogue => 1 },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $op = $cgi->param('op') || 'none';
|
|
my @label_ids;
|
|
@label_ids = $cgi->multi_param('label_id') if $cgi->param('label_id'); # this will handle individual label printing
|
|
my @batch_ids;
|
|
@batch_ids = $cgi->multi_param('batch_id') if $cgi->param('batch_id');
|
|
my $layout_id = $cgi->param('layout_id') || undef;
|
|
my $template_id = $cgi->param('template_id') || undef;
|
|
my $start_label = $cgi->param('start_label') || 1;
|
|
my @item_numbers;
|
|
@item_numbers = $cgi->multi_param('item_number') if $cgi->param('item_number');
|
|
my $output_format = $cgi->param('output_format') || 'pdf';
|
|
my $referer = $cgi->param('referer') || undef;
|
|
|
|
my $layouts = undef;
|
|
my $templates = undef;
|
|
my $output_formats = undef;
|
|
my @batches = ();
|
|
my $multi_batch_count = scalar(@batch_ids);
|
|
my $label_count = scalar(@label_ids);
|
|
my $item_count = scalar(@item_numbers);
|
|
|
|
if ($op eq 'export') {
|
|
if (@label_ids) {
|
|
my $label_id_param = '&label_id=';
|
|
$label_id_param .= join ('&label_id=',@label_ids);
|
|
push (@batches, {create_script => ($output_format eq 'pdf' ? 'label-create-pdf.pl' : 'label-create-csv.pl'),
|
|
batch_id => $batch_ids[0],
|
|
template_id => $template_id,
|
|
layout_id => $layout_id,
|
|
start_label => $start_label,
|
|
label_ids => $label_id_param,
|
|
label_count => scalar(@label_ids),
|
|
});
|
|
$template->param(
|
|
batches => \@batches,
|
|
referer => $referer,
|
|
);
|
|
}
|
|
elsif (@item_numbers) {
|
|
my $item_number_param = '&item_number=';
|
|
$item_number_param .= join ('&item_number=',@item_numbers);
|
|
push (@batches, {create_script => ($output_format eq 'pdf' ? 'label-create-pdf.pl' : 'label-create-csv.pl'),
|
|
template_id => $template_id,
|
|
layout_id => $layout_id,
|
|
start_label => $start_label,
|
|
item_numbers => $item_number_param,
|
|
label_count => scalar(@item_numbers),
|
|
});
|
|
$template->param(
|
|
batches => \@batches,
|
|
referer => $referer,
|
|
);
|
|
}
|
|
elsif (@batch_ids) {
|
|
foreach my $batch_id (@batch_ids) {
|
|
push (@batches, {create_script => ($output_format eq 'pdf' ? 'label-create-pdf.pl' : 'label-create-csv.pl'),
|
|
batch_id => $batch_id,
|
|
template_id => $template_id,
|
|
layout_id => $layout_id,
|
|
start_label => $start_label,
|
|
});
|
|
}
|
|
$template->param(
|
|
batches => \@batches,
|
|
referer => $referer,
|
|
);
|
|
}
|
|
}
|
|
elsif ($op eq 'none') {
|
|
# setup select menus for selecting layout and template for this run...
|
|
$referer = $ENV{'HTTP_REFERER'};
|
|
$referer =~ s/^.*?:\/\/.*?(\/.*)$/$1/m;
|
|
@batch_ids = map{{batch_id => $_}} @batch_ids;
|
|
@label_ids = map{{label_id => $_}} @label_ids;
|
|
@item_numbers = map{{item_number => $_}} @item_numbers;
|
|
$templates = get_all_templates( { fields => [ qw( template_id template_code ) ], filters => { creator => "Labels" }, orderby => 'template_code' } );
|
|
$layouts = get_all_layouts( { fields => [ qw( layout_id layout_name ) ], filters => { creator => "Labels" }, orderby => 'layout_name' } );
|
|
$output_formats = get_output_formats();
|
|
$template->param(
|
|
batch_ids => \@batch_ids,
|
|
label_ids => \@label_ids,
|
|
item_numbers => \@item_numbers,
|
|
templates => $templates,
|
|
layouts => $layouts,
|
|
output_formats => $output_formats,
|
|
multi_batch_count => $multi_batch_count,
|
|
label_count => $label_count,
|
|
item_count => $item_count,
|
|
referer => $referer,
|
|
);
|
|
}
|
|
output_html_with_http_headers $cgi, $cookie, $template->output;
|