Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/cataloguing/value_builder
History
Marcel de Rooy c4a8e5fb3e Bug 13223: Plugin housekeeping: do not redefine wrapper 
This report is connected to bug 10480 which will change the general
mechanism of loading plugins, but can be tested independently and ahead
of that proposed change.

Several unimarc plugins use a wrapper sub. The code of this subroutine
is not exactly the same for all plugins: in some cases the routine is
extended for double character strings (dblspace and dblpipe). It would
not hurt to use the extended code for all plugins.

By moving the code to a module, we prevent redefinition
when two or more plugins are loading wrapper in a do-statement.

NOTE: You will not see wrapper redefine errors in your log, since the
plugins do not use the warnings pragma (yet). Since this patch touches
seventeen unimarc plugins, a unimarc signoff is preferred :)

Test plan:
Use some plugins changed in this patch (if not in use already).
Load the MARC editor.
Click on some tag editor-buttons to check unchanged behavior.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
               Unimarc plugins work as usual. No regression. Simple code
               factorization.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2014-11-19 13:28:08 -03:00
..
barcode.pl
barcode_manual.pl
callnumber-KU.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
callnumber.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
dateaccessioned.pl Bug 12884: Get rid of redefined subroutine warnings in dateaccessioned.pl 2014-10-22 14:18:40 -03:00
labs_theses.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
macles.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
marc21_field_003.pl
marc21_field_005.pl
marc21_field_006.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
marc21_field_007.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
marc21_field_008.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
marc21_field_008_authorities.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
marc21_field_040c.pl
marc21_field_040d.pl
marc21_field_245h.pl
marc21_leader.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
marc21_leader_authorities.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
marc21_leader_book.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
marc21_leader_computerfile.pl Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
marc21_leader_video.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
marc21_linking_section.pl Bug 12695: Remove CGI::scrolling_list from marc21_linking_section.pl 2014-08-19 09:41:37 -03:00
normarc_field_007.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
normarc_field_008.pl Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
normarc_leader.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
stocknumber.pl
stocknumberam123.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
stocknumberAV.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_4XX.pl Bug 12694: Remove CGI::scrolling_list from unimarc_field_4XX.pl 2014-08-19 12:44:27 -03:00
unimarc_field_010.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_100.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_100_authorities.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_105.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_106.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_110.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_115a.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_115b.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_116.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_117.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_120.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_121a.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_121b.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_122.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_123a.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_123d.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_123e.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_123f.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_123g.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_123i.pl Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c 2014-11-11 14:10:34 -03:00
unimarc_field_123j.pl Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c 2014-11-11 14:10:34 -03:00
unimarc_field_124.pl Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
unimarc_field_124a.pl Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
unimarc_field_124b.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_124c.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_124d.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_124e.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_124f.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_124g.pl Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
unimarc_field_125.pl Bug 11349: (qa follow-up) Fix pod 2014-07-17 11:06:15 -03:00
unimarc_field_125a.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_125b.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_126.pl Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
unimarc_field_126a.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_126b.pl Bug 11349: (qa follow-up) Fix pod 2014-07-17 11:06:15 -03:00
unimarc_field_127.pl Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
unimarc_field_128a.pl Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
unimarc_field_128b.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_128c.pl Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
unimarc_field_130.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_135a.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_140.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00
unimarc_field_141.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_210c.pl Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
unimarc_field_210c_bis.pl Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c 2014-11-11 14:10:34 -03:00
unimarc_field_225a.pl Bug 12704: Remove CGI::scrolling_list from unimarc_field_225a.pl 2014-08-19 12:44:03 -03:00
unimarc_field_686a.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_field_700-4.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
unimarc_leader.pl Bug 13223: Plugin housekeeping: do not redefine wrapper 2014-11-19 13:28:08 -03:00