Koha/opac/tracklinks.pl
Aleisha Amohia 0da874bde2 Bug 27979: Modify TrackClicks to verify URL exists in DB when multiple uri
To test:
1) Go to Admin -> system preferences and enable the TrackClicks syspref
(set to Track or Track anonymously)
2) Find a record in the staff client with an item. Edit the item and put
two external URLs in the Uniform Resource Identifier field, e.g.
"https://www.google.com/ | https://twitter.com/"
3) Search for that record in the OPAC. Notice the two links in the
holdings table.
4) Click a link and confirm that you are directed to a 404.
5) Apply the patch and refresh the page
6) Click a link and confirm that you are directed to the page as
expected
7) Go back to edit the record in the staff client and remove one of the
links from the URI field
8) Go back to the OPAC and confirm you can still access the link as
expected when there is only one URI

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-04-16 12:28:18 +02:00

87 lines
2.8 KiB
Perl
Executable file

#!/usr/bin/perl
# script to log clicks on links to external urls
# Copyright 2012 Catalyst IT
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use C4::Context;
use C4::Auth qw(checkauth);
use C4::Biblio;
use C4::Output;
use Koha::Items;
use Koha::Linktracker;
use CGI qw ( -utf8 );
use List::MoreUtils qw(any);
my $cgi = CGI->new;
my $uri = $cgi->param('uri') || '';
my $biblionumber = $cgi->param('biblionumber') || 0;
my $itemnumber = $cgi->param('itemnumber') || 0;
my $tracking_method = C4::Context->preference('TrackClicks');
unless ( $tracking_method ) {
output_error( $cgi, '404' );
exit;
}
my $tracker = Koha::Linktracker->new(
{ trackingmethod => $tracking_method } );
if ($uri && ($biblionumber || $itemnumber) ) {
my $borrowernumber = 0;
# we have a uri and we want to track
if ( $tracker->trackingmethod() eq 'track' ) {
my ( $user, $cookie, $sessionID, $flags ) =
checkauth( $cgi, 1, {}, 'opac' );
my $userenv = C4::Context->userenv;
if ( defined($userenv)
&& ref($userenv) eq 'HASH'
&& $userenv->{number} )
{
$borrowernumber = $userenv->{number};
}
# get borrower info
}
my $record = C4::Biblio::GetMarcBiblio({ biblionumber => $biblionumber });
my $marc_urls = $record ? C4::Biblio::GetMarcUrls($record, C4::Context->preference('marcflavour')) : [];
my $search_crit = { uri => { -like => "%$uri%" } };
if( $itemnumber ) { # itemnumber is leading over biblionumber
$search_crit->{itemnumber} = $itemnumber;
} elsif( $biblionumber ) {
$search_crit->{biblionumber} = $biblionumber;
}
if ( ( any { $_ eq $uri } map { $_->{MARCURL} } @$marc_urls )
|| Koha::Items->search( $search_crit )->count )
{
$tracker->trackclick(
{
uri => $uri,
biblionumber => $biblionumber,
borrowernumber => $borrowernumber,
itemnumber => $itemnumber
}
) if ( $tracker->trackingmethod() eq 'track' || $tracker->trackingmethod() eq 'anonymous' );
print $cgi->redirect($uri);
exit;
}
}
output_error( $cgi, '404' );
exit;