Koha/xt/find-missing-csrf.t
Jonathan Druart 69b6069309
Bug 34478: Add test to catch missing op in POST forms
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:14 +01:00

65 lines
1.9 KiB
Perl
Executable file

#!/usr/bin/perl
# Copyright 2024 Koha development team
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Test::More tests => 1;
use File::Slurp;
use Data::Dumper;
my @files;
# OPAC
push @files, `git ls-files 'koha-tmpl/opac-tmpl/bootstrap/en/*.tt'`;
push @files, `git ls-files 'koha-tmpl/opac-tmpl/bootstrap/en/*.inc'`;
# Staff
push @files, `git ls-files 'koha-tmpl/intranet-tmpl/prog/en/*.tt'`;
push @files, `git ls-files 'koha-tmpl/intranet-tmpl/prog/en/*.inc'`;
my @errors;
for my $file ( @files ) {
chomp $file;
my @e = check_csrf_in_forms($file);
push @errors, sprintf "%s:%s", $file, join (",", @e) if @e;
}
is( @errors, 0, "The <form> in the following files are missing it's corresponding csrf_token include (see bug 22990)" )
or diag(Dumper @errors);
sub check_csrf_in_forms {
my ( $file ) = @_;
my @lines = read_file($file);
my @errors;
return @errors unless grep { $_ =~ m|<form| } @lines;
my ( $open, $found ) = ( 0, 0 );
my $line_number = 0 ;
for my $line (@lines) {
$line_number++;
$open = $line_number if $line =~ m{<form.*method=('|")post('|")}i;
$found++ if $open && $line =~ m{csrf-token\.inc};
if ( $open && $line =~ m{</form} ) {
push @errors, $open unless $found;
$found = 0;
undef $open;
}
}
return @errors;
}