Jonathan Druart
38094a260e
When creating a patron attribute type, there is a "Allow password"
checkbox. If checked, the librarian will be able to enter a password for
this patron attribute when editing a patron.
The goal was to allow a patron to log in with a secondary password.
However, this feature has never been implemented.
"""
commit 6fc62bcd32
CommitDate: Mon May 12 09:03:00 2008 -0500
extended patron attributes tables & syspref (DB rev 081)
- password_allowed (if set, staff patron editor will
allow a password to be associated with a value; this
is mostly a hook for functionality to be implemented
in the future.
"""
To decrease maintainability, this patch suggest to remove the 2 DB fields
borrower_attributes.password and
borrower_attribute_types.password_allowed
If they have not used by the library.
Test plan:
- Edit a patron attribute type and select "allow password"
- Edit a patron and defined a password for this attribute
- Execute the DB entry
- Note that you get a warning
- Empty the password field
- Execute the DB entry
- You do not get the warning and the 2 DB fields have been removed
Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
88 lines
2.7 KiB
Perl
Executable file
88 lines
2.7 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::MockModule;
|
|
use Test::More;
|
|
|
|
use Module::Load::Conditional qw/check_install/;
|
|
|
|
BEGIN {
|
|
if ( check_install( module => 'Test::DBIx::Class' ) ) {
|
|
plan tests => 10;
|
|
} else {
|
|
plan skip_all => "Need Test::DBIx::Class"
|
|
}
|
|
}
|
|
|
|
use_ok('C4::Members::AttributeTypes');
|
|
|
|
use Test::DBIx::Class {
|
|
schema_class => 'Koha::Schema',
|
|
connect_info => ['dbi:SQLite:dbname=:memory:','',''],
|
|
connect_opts => { name_sep => '.', quote_char => '`', },
|
|
fixture_class => '::Populate',
|
|
}, 'BorrowerAttributeType', 'Category' ;
|
|
|
|
fixtures_ok [
|
|
Category => [
|
|
['categorycode'],
|
|
['orange'], ['yellow'],
|
|
],
|
|
BorrowerAttributeType => [
|
|
[
|
|
'code', 'description',
|
|
'repeatable', 'unique_id',
|
|
'opac_display',
|
|
'staff_searchable', 'authorised_value_category',
|
|
'display_checkout', 'category_code',
|
|
'class'
|
|
],
|
|
[ 'one', 'ISBN', '1', '1', '1', '1', 'red', '1', 'orange', 'green' ],
|
|
[ 'two', 'ISSN', '0', '0', '0', '0', 'blue', '0', 'yellow', 'silver' ]
|
|
|
|
],
|
|
], 'add fixtures';
|
|
|
|
my $db = Test::MockModule->new('Koha::Database');
|
|
$db->mock( _new_schema => sub { return Schema(); } );
|
|
|
|
my @members_attributetypes = C4::Members::AttributeTypes::GetAttributeTypes(undef, 1);
|
|
|
|
is( $members_attributetypes[0]->{'code'}, 'one', 'First code value is one' );
|
|
|
|
is( $members_attributetypes[1]->{'code'}, 'two', 'Second code value is two' );
|
|
|
|
is( $members_attributetypes[0]->{'class'},
|
|
'green', 'First class value is green' );
|
|
|
|
is( $members_attributetypes[1]->{'class'},
|
|
'silver', 'Second class value is silver' );
|
|
|
|
ok( C4::Members::AttributeTypes::AttributeTypeExists('one'),
|
|
'checking an attribute type exists' );
|
|
|
|
ok(
|
|
!C4::Members::AttributeTypes::AttributeTypeExists('three'),
|
|
"checking a attribute that isn't in the code doesn't exist"
|
|
);
|
|
|
|
ok( C4::Members::AttributeTypes->fetch('one'), "testing fetch feature" );
|
|
|
|
ok( !C4::Members::AttributeTypes->fetch('FAKE'),
|
|
"testing fetch feature doesn't work if value not in database" );
|