Koha/cataloguing/merge.pl
Jonathan Druart 423fa9cc8f Bug 18593: Move suggestions when bibliographic records are merged
When bibliographic records are merged, the suggestions.biblionumber
field should be replaced with the new record.
Ideally we should have kept an history of the merges, to know what was
the original record. Now we cannot fix the broken links.

Test plan:
1) Create a suggestion in OPAC
2) Accept the suggestion in staff
3) Add order from this suggestion
4) Go to cataloguing search and search for the record and another
5) Merge the suggestion record with the catalog record - catalog record wins (should be the more common case when a patron suggests something that already exists)
6) Verify that after merging, the new title displays in the acquisition record
7) Verify that the suggestion info no longer displays in basket

From Katrin's test plan:
8) Verify that the new title doesn't display in suggestions. The old title will still show as suggested (not updated)
=> This is the title from suggestions.title, I think it makes sense to show this one.
Maybe we should open a new bug report to improve the display of the suggestion, and link to the bibliographic record

Signed-off-by: Lucie Gay <lucie.gay@ens-paris-saclay.fr>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2018-03-26 17:01:10 -03:00

266 lines
9.1 KiB
Perl
Executable file

#!/usr/bin/perl
# Copyright 2009 BibLibre
# Parts Copyright Catalyst IT 2011
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use CGI qw ( -utf8 );
use C4::Output;
use C4::Auth;
use C4::Items;
use C4::Biblio;
use C4::Serials;
use C4::Koha;
use C4::Reserves qw/MergeHolds/;
use C4::Acquisition qw/ModOrder GetOrdersByBiblionumber/;
use Koha::BiblioFrameworks;
use Koha::Items;
use Koha::MetadataRecord;
my $input = new CGI;
my @biblionumbers = $input->multi_param('biblionumber');
my $merge = $input->param('merge');
my @errors;
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
template_name => "cataloguing/merge.tt",
query => $input,
type => "intranet",
authnotrequired => 0,
flagsrequired => { editcatalogue => 'edit_catalogue' },
}
);
#------------------------
# Merging
#------------------------
if ($merge) {
my $dbh = C4::Context->dbh;
# Creating a new record from the html code
my $record = TransformHtmlToMarc( $input, 1 );
my $ref_biblionumber = $input->param('ref_biblionumber');
@biblionumbers = grep { $_ != $ref_biblionumber } @biblionumbers;
# prepare report
my @report_records;
my $report_fields_str = $input->param('report_fields');
$report_fields_str ||= C4::Context->preference('MergeReportFields');
my @report_fields;
foreach my $field_str (split /,/, $report_fields_str) {
if ($field_str =~ /(\d{3})([0-9a-z]*)/) {
my ($field, $subfields) = ($1, $2);
push @report_fields, {
tag => $field,
subfields => [ split //, $subfields ]
}
}
}
# Rewriting the leader
$record->leader(GetMarcBiblio({ biblionumber => $ref_biblionumber })->leader());
my $frameworkcode = $input->param('frameworkcode');
my @notmoveditems;
# Modifying the reference record
ModBiblio($record, $ref_biblionumber, $frameworkcode);
# Moving items from the other record to the reference record
foreach my $biblionumber (@biblionumbers) {
my $items = Koha::Items->search({ biblionumber => $biblionumber });
while ( my $item = $items->next) {
my $res = MoveItemFromBiblio( $item->itemnumber, $biblionumber, $ref_biblionumber );
if ( not defined $res ) {
push @notmoveditems, $item->itemnumber;
}
}
}
# If some items could not be moved :
if (scalar(@notmoveditems) > 0) {
my $itemlist = join(' ',@notmoveditems);
push @errors, { code => "CANNOT_MOVE", value => $itemlist };
}
my $sth_subscription = $dbh->prepare("
UPDATE subscription SET biblionumber = ? WHERE biblionumber = ?
");
my $sth_subscriptionhistory = $dbh->prepare("
UPDATE subscriptionhistory SET biblionumber = ? WHERE biblionumber = ?
");
my $sth_serial = $dbh->prepare("
UPDATE serial SET biblionumber = ? WHERE biblionumber = ?
");
my $sth_suggestions = $dbh->prepare("
UPDATE suggestions SET biblionumber = ? WHERE biblionumber = ?
");
my $report_header = {};
foreach my $biblionumber ($ref_biblionumber, @biblionumbers) {
# build report
my $marcrecord = GetMarcBiblio({ biblionumber => $biblionumber });
my %report_record = (
biblionumber => $biblionumber,
fields => {},
);
foreach my $field (@report_fields) {
my @marcfields = $marcrecord->field($field->{tag});
foreach my $marcfield (@marcfields) {
my $tag = $marcfield->tag();
if (scalar @{$field->{subfields}}) {
foreach my $subfield (@{$field->{subfields}}) {
my @values = $marcfield->subfield($subfield);
$report_header->{ $tag . $subfield } = 1;
push @{ $report_record{fields}->{$tag . $subfield} }, @values;
}
} elsif ($field->{tag} gt '009') {
my @marcsubfields = $marcfield->subfields();
foreach my $marcsubfield (@marcsubfields) {
my ($code, $value) = @$marcsubfield;
$report_header->{ $tag . $code } = 1;
push @{ $report_record{fields}->{ $tag . $code } }, $value;
}
} else {
$report_header->{ $tag . '@' } = 1;
push @{ $report_record{fields}->{ $tag .'@' } }, $marcfield->data();
}
}
}
push @report_records, \%report_record;
}
foreach my $biblionumber (@biblionumbers) {
# Moving subscriptions from the other record to the reference record
my $subcount = CountSubscriptionFromBiblionumber($biblionumber);
if ($subcount > 0) {
$sth_subscription->execute($ref_biblionumber, $biblionumber);
$sth_subscriptionhistory->execute($ref_biblionumber, $biblionumber);
}
# Moving serials
$sth_serial->execute($ref_biblionumber, $biblionumber);
# Moving suggestions
$sth_suggestions->execute($ref_biblionumber, $biblionumber);
# Moving orders (orders linked to items of frombiblio have already been moved by MoveItemFromBiblio)
my @allorders = GetOrdersByBiblionumber($biblionumber);
foreach my $myorder (@allorders) {
$myorder->{'biblionumber'} = $ref_biblionumber;
ModOrder ($myorder);
# TODO : add error control (in ModOrder?)
}
# Deleting the other records
if (scalar(@errors) == 0) {
# Move holds
MergeHolds($dbh, $ref_biblionumber, $biblionumber);
my $error = DelBiblio($biblionumber);
push @errors, $error if ($error);
}
}
# Parameters
$template->param(
result => 1,
report_records => \@report_records,
report_header => $report_header,
ref_biblionumber => scalar $input->param('ref_biblionumber')
);
#-------------------------
# Show records to merge
#-------------------------
} else {
my $ref_biblionumber = $input->param('ref_biblionumber');
if ($ref_biblionumber) {
my $framework = $input->param('frameworkcode');
$framework //= GetFrameworkCode($ref_biblionumber);
# Getting MARC Structure
my $tagslib = GetMarcStructure(1, $framework);
my $marcflavour = lc(C4::Context->preference('marcflavour'));
# Creating a loop for display
my @records;
foreach my $biblionumber (@biblionumbers) {
my $marcrecord = GetMarcBiblio({ biblionumber => $biblionumber });
my $frameworkcode = GetFrameworkCode($biblionumber);
my $recordObj = new Koha::MetadataRecord({'record' => $marcrecord, schema => $marcflavour});
my $record = {
recordid => $biblionumber,
record => $marcrecord,
frameworkcode => $frameworkcode,
display => $recordObj->createMergeHash($tagslib),
};
if ($ref_biblionumber and $ref_biblionumber == $biblionumber) {
$record->{reference} = 1;
$template->param(ref_record => $record);
unshift @records, $record;
} else {
push @records, $record;
}
}
my ($biblionumbertag) = GetMarcFromKohaField('biblio.biblionumber');
# Parameters
$template->param(
ref_biblionumber => $ref_biblionumber,
records => \@records,
ref_record => $records[0],
framework => $framework,
biblionumbertag => $biblionumbertag,
MergeReportFields => C4::Context->preference('MergeReportFields'),
);
} else {
my @records;
foreach my $biblionumber (@biblionumbers) {
my $frameworkcode = GetFrameworkCode($biblionumber);
my $record = {
biblionumber => $biblionumber,
data => GetBiblioData($biblionumber),
frameworkcode => $frameworkcode,
};
push @records, $record;
}
# Ask the user to choose which record will be the kept
$template->param(
choosereference => 1,
records => \@records,
);
my $frameworks = Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] });
$template->param( frameworks => $frameworks );
}
}
if (@errors) {
# Errors
$template->param( errors => \@errors );
}
output_html_with_http_headers $input, $cookie, $template->output;
exit;