Hammat Wele e303854076 Bug 33224: OPACHoldsIfAvailableAtPickup and no on-shelf holds don't mix well ... When OPACHoldsIfAvailableAtPickup preference is set to Don't allow and circulation rules allow on-shelf holds only if any unavailable, and we have a record with a checked out copy at Centerville and an available copy at Midway, a Midway patron should not be able to place a hold for pickup at Midway since the Midway copy is available. This is the setting: - circulation rules allow on-shelf holds only if any unavailable - OPACHoldsIfAvailableAtPickup is set to Don't allow To test: 1. Set up the circulation rule so that on-shelf holds are allowed ('Yes') 2. Create a record with two items, one at Centerville and one at Midway 3. Check out the Centerville item 4. Log into the OPAC with a Midway patron (I used Henry Acevedo) 5. Try to place a hold on the record --> Midway is not a valid pickup location (correct behaviour) 6. Cancel 7. Change the circulation rules so that on-shelf holds are only allowed 'if any unavailable' 8. Try to place a hold on the record from the OPAC again --> The system allows you to place the hold for pickup at Midway (incorrect behaviour) 9. Optionally, check the Holds to pull for Midway (the hold is there, it shouldn't) 10. Optionnaly, check in the Midway item (it is trapped for Henry's hold) 11. Apply the patch 12. Try again to place a hold on the record from the OPAC --> it is impossible to select Midway, Midway is not a valid pickup location Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>		2025-03-19 17:34:55 +01:00
..
clubs	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
errors	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
external/overdrive	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
sci	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
sco	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
svc	Bug 36112: Port default CHECKOUT_NOTE notice to TT	2025-02-19 17:05:35 +01:00
ilsdi.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
maintenance.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
oai.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-account-pay-return.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-account-pay.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-account.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-addbybiblionumber.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-alert-subscribe.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-alert-subscriptions.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-article-request-cancel.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-authorities-home.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-authoritiesdetail.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-basket.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-blocked.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-browse.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-browser.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-changelanguage.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-course-details.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-course-reserves.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-curbside-pickups.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-detail.pl	Bug 28478: Make opac-*detail.pl scripts use Koha::Biblio->opac_suppressed()	2025-03-06 13:54:28 +01:00
opac-discharge.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-dismiss-message.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-downloadcart.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-downloadshelf.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-export.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-holdshistory.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-ics.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-idref.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-illrequests.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-image.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-imageviewer.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-ISBDdetail.pl	Bug 28478: Make opac-*detail.pl scripts use Koha::Biblio->opac_suppressed()	2025-03-06 13:54:28 +01:00
opac-issue-note.pl	Bug 36112: Port default CHECKOUT_NOTE notice to TT	2025-02-19 17:05:35 +01:00
opac-library.pl	Bug 32051: Rename Library to Contact for one public library	2025-03-07 18:02:55 +01:00
opac-main.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-MARCdetail.pl	Bug 28478: Make opac-*detail.pl scripts use Koha::Biblio->opac_suppressed()	2025-03-06 13:54:28 +01:00
opac-memberentry.pl	Bug 38903: Fix theme in some getTranslatedLanguages calls	2025-03-07 15:41:13 +01:00
opac-messaging.pl	Bug 38903: Fix theme in some getTranslatedLanguages calls	2025-03-07 15:41:13 +01:00
opac-modrequest-suspend.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-modrequest.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-mymessages.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-news-rss.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-overdrive-search.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-page.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-passwd.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-password-recovery.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-patron-consent.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-patron-image.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-privacy.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-ratings.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-readingrecord.pl	Bug 18798: Use Koha.Preference in OPAC Reading Record	2025-03-19 11:55:30 +01:00
opac-recall.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-recalls.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-registration-verify.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-renew.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-reportproblem.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-request-article.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-reserve.pl	Bug 33224: OPACHoldsIfAvailableAtPickup and no on-shelf holds don't mix well	2025-03-19 17:34:55 +01:00
opac-reset-password.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-restrictedpage.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-retrieve-file.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-review.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-routing-lists.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-search-history.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-search.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-sendbasket.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-sendshelf.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-serial-issues.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-shareshelf.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-shelves.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-showmarc.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-showreviews.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-suggestions.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-tags.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-tags_subject.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-topissues.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-user.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
opac-virtual-card.pl	Bug 26777: Allow ability to select diffferent barcode types	2024-08-26 17:39:36 +02:00
tracklinks.pl	Bug 38664: Tidy the whole codebase	2025-02-11 14:58:24 +01:00
unapi	Bug 17600: Fix opac/unapi	2021-11-22 11:04:51 +01:00