Jonathan Druart
cae4b98060
This unnecessary complicated subroutine returned an arrayref and an
hashref of the patron categories available for the logged in user, for a given
category_type, ordered by categorycode.
This can now be done with the search_limited method.
Test plan:
- Same prerequisite as before
For the following pages, you should not see patron categories limited to other
libraries. They should be ordered as before this patch, by categorycode.
- Add/edit a patron, change his/her patron category value.
- On the 3 following reports:
reports/bor_issues_top.pl
reports/borrowers_out.pl
reports/cat_issues_top.pl
The display for these 3 reports are different than the 2 from the first
patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by
categorycode and the ones limited to other libraries are not displayed
(should certainly be fixed).
Note that the big part of this patch has already been tested before
(update child related: CATCODE_MULTI).
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
93 lines
3 KiB
Perl
Executable file
93 lines
3 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2000-2002 Katipo Communications
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
=head1 updatechild.pl
|
|
|
|
script to update a child member to (usually) an adult member category
|
|
|
|
- if called with op=multi, will return all available non child categories, for selection.
|
|
- if called with op=update, script will update member record via ModMember().
|
|
|
|
=cut
|
|
|
|
use strict;
|
|
#use warnings; FIXME - Bug 2505
|
|
use CGI qw ( -utf8 );
|
|
use C4::Context;
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
use C4::Members;
|
|
use Koha::Patron::Categories;
|
|
|
|
# use Smart::Comments;
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
my $input = new CGI;
|
|
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "members/update-child.tt",
|
|
query => $input,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { borrowers => 1 },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $borrowernumber = $input->param('borrowernumber');
|
|
my $catcode = $input->param('catcode');
|
|
my $cattype = $input->param('cattype');
|
|
my $catcode_multi = $input->param('catcode_multi');
|
|
my $op = $input->param('op');
|
|
|
|
if ( $op eq 'multi' ) {
|
|
# FIXME - what are the possible upgrade paths? C -> A , C -> S ...
|
|
# currently just allowing C -> A
|
|
my $patron_categories = Koha::Patron::Categories->search_limited({ category_type => 'A' }, {order_by => ['categorycode']});
|
|
$template->param(
|
|
MULTI => 1,
|
|
CATCODE_MULTI => 1,
|
|
borrowernumber => $borrowernumber,
|
|
patron_categories => $patron_categories,
|
|
);
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|
|
}
|
|
|
|
elsif ( $op eq 'update' ) {
|
|
my $member = GetMember('borrowernumber'=>$borrowernumber);
|
|
$member->{'guarantorid'} = 0;
|
|
$member->{'categorycode'} = $catcode;
|
|
my $borcat = Koha::Patron::Categories->find($catcode);
|
|
$member->{'category_type'} = $borcat->category_type;
|
|
$member->{'description'} = $borcat->description;
|
|
delete $member->{password};
|
|
ModMember(%$member);
|
|
|
|
if ( $catcode_multi ) {
|
|
$template->param(
|
|
SUCCESS => 1,
|
|
borrowernumber => $borrowernumber,
|
|
);
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|
|
} else {
|
|
print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$borrowernumber");
|
|
}
|
|
}
|
|
|