Koha/virtualshelves/addbybiblionumber.pl
Jonathan Druart 7dfc64022b Bug 16517: Do not crash when creating a list with an existing name
A typo has been made during a merge conflict when rebasing bug 16517.

it should be
  eval { Koha::Object->new->store; };
instead of
  eval { Koha::Object->new; }->store;

Test plan:
From the result list (intranet side), check some entries and add them to
a new list
Use an existing list's name
=> Without this patch you will get a server error (exception 'Duplicate shelf
object' raised by Koha::Virtualshelf->new->store)
=> With this patch you must get a friendly error message

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-05-23 17:16:10 +00:00

243 lines
6 KiB
Perl
Executable file

#!/usr/bin/perl
#script to provide virtual shelf management
#
#
# Copyright 2000-2002 Katipo Communications
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
=head1 NAME
addbybiblionumber.pl
=head1 DESCRIPTION
This script allow to add a virtual in a virtual shelf from a biblionumber.
=head1 CGI PARAMETERS
=over 4
=item biblionumber
The biblionumber
=item shelfnumber
the shelfnumber where to add the virtual.
=item newvirtualshelf
if this parameter exists, then it must be equals to the name of the shelf
to add.
=item category
if this script has to add a shelf, it add one with this category.
=item newshelf
if this parameter exists, then we create a new shelf
=back
=cut
use strict;
use warnings;
use CGI qw ( -utf8 );
use C4::Biblio;
use C4::Output;
use C4::Auth;
use Koha::Virtualshelves;
our $query = new CGI;
our @biblionumber = HandleBiblioPars();
our $shelfnumber = $query->param('shelfnumber');
our $newvirtualshelf = $query->param('newvirtualshelf');
our $newshelf = $query->param('newshelf');
our $category = $query->param('category');
our $sortfield = $query->param('sortfield');
my $confirmed = $query->param('confirmed') || 0;
our $authorized = 1;
our $errcode = 0;
our ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
template_name => "virtualshelves/addbybiblionumber.tt",
query => $query,
type => "intranet",
authnotrequired => 0,
flagsrequired => { catalogue => 1 },
}
);
if( $newvirtualshelf) {
HandleNewVirtualShelf();
exit if $authorized;
ShowTemplate(); #error message
}
elsif($shelfnumber && $confirmed) {
HandleShelfNumber();
exit if $authorized;
ShowTemplate(); #error message
}
elsif($shelfnumber) { #still needs confirmation
HandleSelectedShelf();
LoadBib() if $authorized;
ShowTemplate();
}
else {
HandleSelect();
LoadBib();
ShowTemplate();
}
#end
sub HandleBiblioPars {
my @bib= $query->multi_param('biblionumber');
if(@bib==0 && $query->param('biblionumbers')) {
my $str= $query->param('biblionumbers');
@bib= split '/', $str;
}
elsif(@bib==1 && $bib[0]=~/\//) {
@bib= split '/', $bib[0];
}
return @bib;
}
sub HandleNewVirtualShelf {
my $shelf = eval {
Koha::Virtualshelf->new(
{
shelfname => $newvirtualshelf,
category => $category,
sortfield => $sortfield,
owner => $loggedinuser,
}
)->store;
};
if ( $@ or not $shelf ) {
$authorized = 0;
$errcode = 1;
return;
}
for my $bib (@biblionumber){
$shelf->add_biblio( $bib, $loggedinuser );
}
#Reload the page where you came from
print $query->header;
print "<html><meta http-equiv=\"refresh\" content=\"0\" /><body onload=\"window.opener.location.reload(true);self.close();\"></body></html>";
}
sub HandleShelfNumber {
my $shelf = Koha::Virtualshelves->find( $shelfnumber );
if($authorized = $shelf->can_biblios_be_added( $loggedinuser ) ) {
for my $bib (@biblionumber){
$shelf->add_biblio( $bib, $loggedinuser );
}
#Close this page and return
print $query->header;
print "<html><meta http-equiv=\"refresh\" content=\"0\" /><body onload=\"self.close();\"></body></html>";
}
else {
$errcode=2; #no perm
}
}
sub HandleSelectedShelf {
my $shelf = Koha::Virtualshelves->find( $shelfnumber );
if($authorized = $shelf->can_biblios_be_added( $loggedinuser ) ) {
#confirm adding to specific shelf
$template->param(
singleshelf => 1,
shelfnumber => $shelf->shelfnumber,
shelfname => $shelf->shelfname,
);
}
else {
$errcode=2; #no perm
}
}
sub HandleSelect {
my $private_shelves = Koha::Virtualshelves->search(
{
category => 1,
owner => $loggedinuser,
},
{ order_by => 'shelfname' }
);
my $shelves_shared_with_me = Koha::Virtualshelves->search(
{
category => 1,
'virtualshelfshares.borrowernumber' => $loggedinuser,
-or => {
allow_add => 1,
owner => $loggedinuser,
}
},
{
join => 'virtualshelfshares',
}
);
my $public_shelves= Koha::Virtualshelves->search(
{
category => 2,
-or => {
allow_add => 1,
owner => $loggedinuser,
}
},
{ order_by => 'shelfname' }
);
$template->param (
private_shelves => $private_shelves,
private_shelves_shared_with_me => $shelves_shared_with_me,
public_shelves => $public_shelves,
);
}
sub LoadBib {
my @biblios;
for my $bib (@biblionumber) {
my $data = GetBiblioData($bib);
push(@biblios,
{ biblionumber => $bib,
title => $data->{'title'},
author => $data->{'author'},
} );
}
$template->param(
multiple => (scalar(@biblios) > 1),
total => scalar @biblios,
biblios => \@biblios,
);
}
sub ShowTemplate {
$template->param (
newshelf => $newshelf||0,
authorized => $authorized,
errcode => $errcode,
);
output_html_with_http_headers $query, $cookie, $template->output;
}