52172938c2
This patch removes only instance in this file. Problem is that there are many template files involved. Most of them have other instances of scrolling_lists but is a problem for other bugs, they will depend on this. What is replaced is a pulldown for delimiter choices. In all but one case the code is the same (variable name change), and I did a little tidy of the TT code To test: 1. Apply the patch In all the following cases, check delimiters pulldown (Output box, bottom right) 2. Go to Reports > Statistics wizard > Acquisitions 3. Go to Reports > Statistics wizard > Patrons 4. Go to Reports > Statistics wizard > Catalog 5. Go to Reports > Statistics wizard > Circulation 6. Go to Reports > Statistics wizard > Serials 7. Go to Reports > Statistics wizard > Holds there is a bug here, pulldown next to this must show 'CSV' option, but shows nothing. Will be fixed 8. Go to Reports > Other > Average loan time 9. Go to Reports > Top lists > Patron checking out the most Here there is a 'Delimiter' label before delimiters, only case 10. Go to Reports > Top lists > Most-circulated items 11. Go to Reports > Inactive > Patrons who haven't checked out There is and inconsistency here, name of option on reports page, and name on this report, 'Patrons with no checkouts' Followed test plan. Pulldowns display as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
84 lines
1.8 KiB
Perl
84 lines
1.8 KiB
Perl
package C4::Reports;
|
|
|
|
# Copyright 2007 Liblime Ltd
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 2 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along
|
|
# with Koha; if not, write to the Free Software Foundation, Inc.,
|
|
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
|
|
use strict;
|
|
#use warnings; FIXME - Bug 2505
|
|
use CGI;
|
|
|
|
use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
|
|
use C4::Context;
|
|
use C4::Debug;
|
|
|
|
BEGIN {
|
|
# set the version for version checking
|
|
$VERSION = 3.07.00.049;
|
|
require Exporter;
|
|
@ISA = qw(Exporter);
|
|
@EXPORT = qw(
|
|
GetDelimiterChoices
|
|
);
|
|
}
|
|
|
|
=head1 NAME
|
|
|
|
C4::Reports - Module for generating reports
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
This module contains functions common to reports.
|
|
|
|
=head1 EXPORTED FUNCTIONS
|
|
|
|
=head2 GetDelimiterChoices
|
|
|
|
my $delims = GetDelimiterChoices;
|
|
|
|
This will return a list of all the available delimiters.
|
|
|
|
=cut
|
|
|
|
sub GetDelimiterChoices {
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
my $sth = $dbh->prepare("
|
|
SELECT options, value
|
|
FROM systempreferences
|
|
WHERE variable = 'delimiter'
|
|
");
|
|
|
|
$sth->execute();
|
|
|
|
my ($choices, $default) = $sth->fetchrow;
|
|
my @dels = split /\|/, $choices;
|
|
|
|
return {
|
|
values => \@dels,
|
|
default => $default,
|
|
};
|
|
}
|
|
|
|
1;
|
|
|
|
__END__
|
|
|
|
=head1 AUTHOR
|
|
|
|
Jesse Weaver <jesse.weaver@liblime.com>
|
|
|
|
=cut
|