ed7543287b
Having to write [% KOHA_VERSION %] for each url is bad because: - It's easily forgettable when adding new <script> or <link> - It prevents grep'ing for the full filename - It violates the DRY principle - If at some point we want to change the "force js and css reload" mechanism, it will be tedious This patch: - adds a Template::Toolkit plugin that generates <script> and <link> tags for JS and CSS files, and inserts automatically the Koha version in the filename - use the new plugin to remove all occurences of [% KOHA_VERSION %] - remove the code that was adding KOHA_VERSION as a template variable Test plan: 1. Apply patch 2. Go to several different pages in Koha (opac and intranet) while checking your browser's dev tools (there should be no 404 for JS and CSS files, and the Koha version should appear in filenames) and the server logs (there should be no "File not found") 3. `git grep KOHA_VERSION` should return nothing 4. prove t/db_dependent/Koha/Template/Plugin/Asset.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
145 lines
6.4 KiB
Text
145 lines
6.4 KiB
Text
[% USE Asset %]
|
|
[% SET footerjs = 1 %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Tools › Rotating collections ›
|
|
[%- IF ( action == "new" ) %]
|
|
Add a new collection
|
|
[% ELSE %]
|
|
Edit collection [% editColTitle %]
|
|
[% END -%]
|
|
</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
<body id="rcoll_editCollections" class="tools rcoll">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'cat-search.inc' %]
|
|
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> › <a href="/cgi-bin/koha/rotating_collections/rotatingCollections.pl">Rotating collections</a> ›
|
|
[%- IF ( action == "new" ) %]
|
|
Add a new collection
|
|
[% ELSE %]
|
|
<a href="/cgi-bin/koha/rotating_collections/addItems.pl?colId=[% editColId %]">Collection <i>[% editColTitle %]</i></a> › Edit
|
|
[% END -%]
|
|
</div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
|
|
[% IF ( previousActionCreate ) %]
|
|
[% IF ( createSuccess ) %]
|
|
<div class="dialog message">
|
|
<p>Collection <i>[% createdTitle %]</i> added successfully</p>
|
|
<p><a href="/cgi-bin/koha/rotating_collections/rotatingCollections.pl">Return to rotating collections home</a></p>
|
|
</div>
|
|
[% ELSE %]
|
|
<div class="dialog alert">
|
|
<p>Collection <i>[% createdTitle %]</i> failed to be added</p>
|
|
<p>
|
|
[% IF failureMessage == "NO_TITLE" %]
|
|
No title entered.
|
|
[% ELSIF failureMessage == "DUPLICATE_TITLE" %]
|
|
Title already in use.
|
|
[% ELSIF failureMessage == "NO_DESCRIPTION" %]
|
|
No description entered.
|
|
[% ELSE %]
|
|
[% failureMessage %]
|
|
[% END %]
|
|
</p>
|
|
</div>
|
|
[% END %]
|
|
[% END %]
|
|
|
|
[% IF ( previousActionDelete ) %]
|
|
[% IF ( deleteSuccess ) %]
|
|
<div class="dialog message">
|
|
<p>Collection deleted successfully</p>
|
|
<p><a href="/cgi-bin/koha/rotating_collections/rotatingCollections.pl">Return to rotating collections home</a></p>
|
|
</div>
|
|
[% ELSE %]
|
|
<div class="dialog alert">Collection failed to be deleted</div>
|
|
[% END %]
|
|
[% END %]
|
|
|
|
[% IF ( previousActionUpdate ) %]
|
|
[% IF ( updateSuccess ) %]
|
|
<div class="dialog message">
|
|
<p>Collection <i>[% updatedTitle %]</i> updated successfully</p>
|
|
<p><a href="/cgi-bin/koha/rotating_collections/rotatingCollections.pl">Return to rotating collections home</a></p>
|
|
</div>
|
|
[% ELSE %]
|
|
<div class="dialog alert">
|
|
<p>Collection <i>[% updatedTitle %]</i> failed to be updated</p>
|
|
<p>
|
|
[% IF failureMessage == "NO_ID" %]
|
|
No collection id given.
|
|
[% ELSIF failureMessage == "DUPLICATE_TITLE" %]
|
|
Title already in use.
|
|
[% ELSE %]
|
|
[% failureMessage %]
|
|
[% END %]
|
|
</p>
|
|
</div>
|
|
[% END %]
|
|
[% END %]
|
|
|
|
<div>
|
|
|
|
[% IF action == "new" || action == "edit" %]
|
|
[% IF ( previousActionEdit ) %]
|
|
<h1>Edit collection <i>[% editColTitle %]</i></h1>
|
|
[% ELSE %]
|
|
<h1>Add new collection</h1>
|
|
[% END %]
|
|
|
|
<form action="editCollections.pl" method="post" class="validated">
|
|
[% IF ( previousActionEdit ) %]
|
|
<input type="hidden" name="action" value="update" />
|
|
<input type="hidden" name="colId" value="[% editColId %]" />
|
|
[% ELSE %]
|
|
<input type="hidden" name="action" value="create" />
|
|
[% END %]
|
|
|
|
<fieldset class="rows">
|
|
<ol>
|
|
<li>
|
|
<label class="required" for="title">Title: </label>
|
|
[% IF ( editColTitle ) %]
|
|
<input type="text" name="title" value="[% editColTitle %]" required="required" />
|
|
<span class="required">Required</span>
|
|
[% ELSE %]
|
|
<input type="text" name="title" required="required" />
|
|
<span class="required">Required</span>
|
|
[% END %]
|
|
</li>
|
|
<li>
|
|
<label for="description">Description: </label>
|
|
[% IF (editColDescription ) %]
|
|
<input type="text" size="50" name="description" value="[% editColDescription %]" />
|
|
[% ELSE %]
|
|
<input type="text" size="50" name="description" />
|
|
[% END %]
|
|
</li>
|
|
</ol>
|
|
</fieldset>
|
|
<fieldset class="action">
|
|
<p><input type="submit" value="Submit" /> <a href="/cgi-bin/koha/rotating_collections/rotatingCollections.pl" class="cancel">Cancel</a></p>
|
|
</fieldset>
|
|
</form>
|
|
[% END %]
|
|
</div>
|
|
|
|
</div> <!-- /.yui-b -->
|
|
</div> <!-- /#yui-main -->
|
|
<div class="yui-b">
|
|
[% INCLUDE 'tools-menu.inc' %]
|
|
</div>
|
|
</div> <!-- /#bd -->
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
[% Asset.js("js/tools-menu.js") %]
|
|
[% Asset.js("js/rotating-collections.js") %]
|
|
[% END %]
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|