Jonathan Druart
3aeb1fc7e8
At the moment we have 2 different modules for acquisition orders: Koha::Tmp::Order[s] and Koha::Acquisition::Order The later has been added before the creation of Koha::Object. Koha::Tmp::Order[s] has been created to make the TT syntax for notices works with acquisition order data. This patch removes the temporary packages Koha::Tmp::Order[s] and adapt the code of Koha::Acquisition::Order[s] to be based on Koha::Object[s]. It also overloads Koha::Object->new to add the trick that was done in Koha::Acquisition::Order->insert. This is needed because acqui/addorder.pl is called from several places and CGI->Vars is used to retrieved order's attributes (and so much more). To avoid regression, the easiest (but not cleanest) way to do is to filter on aqorders column's names. This is *not* a pattern to follow! Test plan: Create basket and add orders from different ways, then continue a whole acquisition process Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
99 lines
3.5 KiB
Perl
99 lines
3.5 KiB
Perl
#!/usr/bin/perl
|
|
|
|
use Modern::Perl;
|
|
use Test::More tests => 18;
|
|
use Data::Dumper;
|
|
|
|
use C4::Acquisition qw( NewBasket GetBasketsInfosByBookseller );
|
|
use C4::Biblio qw( AddBiblio );
|
|
use C4::Budgets qw( AddBudget );
|
|
use C4::Context;
|
|
use Koha::Database;
|
|
use Koha::Acquisition::Orders;
|
|
|
|
my $schema = Koha::Database->new()->schema();
|
|
$schema->storage->txn_begin();
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
$dbh->{RaiseError} = 1;
|
|
|
|
my $supplier = Koha::Acquisition::Bookseller->new(
|
|
{
|
|
name => 'my vendor',
|
|
address1 => 'bookseller\'s address',
|
|
phone => '0123456',
|
|
active => 1,
|
|
deliverytime => 5,
|
|
}
|
|
)->store;
|
|
my $supplierid = $supplier->id;
|
|
|
|
my $basketno;
|
|
ok($basketno = NewBasket($supplierid, 1), 'NewBasket( $supplierid , 1 ) returns $basketno');
|
|
|
|
my $budgetid = C4::Budgets::AddBudget(
|
|
{
|
|
budget_code => 'budget_code_test_getordersbybib',
|
|
budget_name => 'budget_name_test_getordersbybib',
|
|
}
|
|
);
|
|
my $budget = C4::Budgets::GetBudget( $budgetid );
|
|
|
|
my ($biblionumber1, $biblioitemnumber1) = AddBiblio(MARC::Record->new, '');
|
|
my ($biblionumber2, $biblioitemnumber2) = AddBiblio(MARC::Record->new, '');
|
|
my ($biblionumber3, $biblioitemnumber3) = AddBiblio(MARC::Record->new, '');
|
|
|
|
my $order1 = Koha::Acquisition::Order->new(
|
|
{
|
|
basketno => $basketno,
|
|
quantity => 2,
|
|
biblionumber => $biblionumber1,
|
|
budget_id => $budget->{budget_id},
|
|
}
|
|
)->store;
|
|
my $ordernumber1 = $order1->ordernumber;
|
|
|
|
my $order2 = Koha::Acquisition::Order->new(
|
|
{
|
|
basketno => $basketno,
|
|
quantity => 4,
|
|
biblionumber => $biblionumber2,
|
|
budget_id => $budget->{budget_id},
|
|
}
|
|
)->store;
|
|
my $ordernumber2 = $order2->ordernumber;
|
|
|
|
my $baskets = C4::Acquisition::GetBasketsInfosByBookseller( $supplierid );
|
|
is( scalar(@$baskets), 1, 'Start: 1 basket' );
|
|
my $basket = $baskets->[0];
|
|
is( $basket->{total_items}, 6, 'Start with 6 items' );
|
|
is( $basket->{total_biblios}, 2, 'Start with 2 biblios' );
|
|
is( $basket->{total_items_cancelled}, 0, 'Start with 0 item cancelled' );
|
|
is( $basket->{total_biblios_cancelled}, 0, 'Start with 0 biblio cancelled' );
|
|
|
|
C4::Acquisition::DelOrder( $biblionumber2, $ordernumber2 );
|
|
$baskets = C4::Acquisition::GetBasketsInfosByBookseller( $supplierid );
|
|
is( scalar(@$baskets), 1, 'Order2 deleted, still 1 basket' );
|
|
$basket = $baskets->[0];
|
|
is( $basket->{total_items}, 6, 'Order2 deleted, still 6 items' );
|
|
is( $basket->{total_biblios}, 2, 'Order2 deleted, still 2 biblios' );
|
|
is( $basket->{total_items_cancelled}, 4, 'Order2 deleted, 4 items cancelled' );
|
|
is( $basket->{total_biblios_cancelled}, 1, 'Order2 deleted, 2 biblios cancelled' );
|
|
|
|
C4::Acquisition::DelOrder( $biblionumber1, $ordernumber1 );
|
|
$baskets = C4::Acquisition::GetBasketsInfosByBookseller( $supplierid );
|
|
is( scalar(@$baskets), 1, 'Both orders deleted, still 1 basket' );
|
|
$basket = $baskets->[0];
|
|
is( $basket->{total_items}, 6, 'Both orders deleted, still 6 items' );
|
|
is( $basket->{total_biblios}, 2, 'Both orders deleted, still 6 biblios' );
|
|
is( $basket->{total_items_cancelled}, 6, 'Both orders deleted, 6 items cancelled' );
|
|
is( $basket->{total_biblios_cancelled}, 2, 'Both orders deleted, 2 biblios cancelled' );
|
|
|
|
C4::Acquisition::CloseBasket( $basketno );
|
|
$baskets = C4::Acquisition::GetBasketsInfosByBookseller( $supplierid );
|
|
is( scalar(@$baskets), 0, 'Basket is closed, 0 basket opened' );
|
|
$baskets = C4::Acquisition::GetBasketsInfosByBookseller( $supplierid, 1 );
|
|
is( scalar(@$baskets), 1, 'Basket is closed, test allbasket parameter');
|
|
|
|
|
|
$schema->storage->txn_rollback();
|