Koha/admin/checkmarc.pl
Katrin Fischer 252f4674a5 Bug 14391: Add granular permissions to the administration module
So far the administration module only allowed for 2 permissions:
- circulation conditions (manage_circ_rules)
- everything else (parameters_remaining_permissions)

With this patch almost every section of the administration page
will have its own granular permission.

To test:
- Create different staff users:
  1) One with parameters_remaining_permissions
  2) One with parameters
  3) One with catalogue and no parameters
  4) One superlibrarian
- Apply the patch
- Run the database update
- Check the staff users:
  1) All subpermissions, but manage_circ_rules
     should be checked
  2) Nothing should have changed
  3) manage_item_serach_fields shoudl be checked
     (page had catalogue permission before)
  4) Nothing should have changed
- Try different settings of the permissions and
  verify that
  - Administration page behaves correctly
  - Administration menu behaves correctly
  ! You shoudl only see what you have permission for

https://bugs.koha-community.org/show_bug.cgi?id=14391

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-11-07 12:29:32 +00:00

264 lines
8.1 KiB
Perl
Executable file

#!/usr/bin/perl
# Copyright 2000-2002 Katipo Communications
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use C4::Output;
use C4::Auth;
use CGI qw ( -utf8 );
use C4::Context;
use C4::Biblio;
my $input = new CGI;
my ($template, $borrowernumber, $cookie)
= get_template_and_user({template_name => "admin/checkmarc.tt",
query => $input,
type => "intranet",
authnotrequired => 0,
flagsrequired => { parameters => 'manage_marc_frameworks' },
debug => 1,
});
my $dbh = C4::Context->dbh;
my $total = 0;
# checks itemnum field
my $sth = $dbh->prepare("select tab from marc_subfield_structure where kohafield=\"items.itemnumber\"");
$sth->execute;
while (my ($res) = $sth->fetchrow) {
if ($res==-1) {
$template->param(itemnum => 0);
} else {
$template->param(itemnum => 1);
$total++;
last;
}
}
# checks biblio.biblionumber and biblioitem.biblioitemnumber (same tag and tab=-1)
$sth = $dbh->prepare("select tagfield,tab,frameworkcode from marc_subfield_structure where kohafield=\"biblio.biblionumber\"");
$sth->execute;
my $first = 1;
my $bibliotag = '';
while (my ($res,$tab,$frameworkcode) = $sth->fetchrow) {
if ($first) {
$bibliotag = $res;
$first = 0;
} else {
if ($bibliotag != $res) {
$template->param(biblionumber => 1);
$total++;
last;
}
}
my $sth2 = $dbh->prepare("SELECT tagfield,tab
FROM marc_subfield_structure
WHERE kohafield=\"biblioitems.biblioitemnumber\"
AND frameworkcode = ? ");
$sth2->execute($frameworkcode);
my ($res2,$tab2) = $sth2->fetchrow;
if ($res && $res2 && $tab==-1 && $tab2==-1) {
$template->param(biblionumber => 0);
} else {
$template->param(biblionumber => 1);
$total++;
last;
}
}
# checks all item fields are in the same tag and in tab 10
$sth = $dbh->prepare("select tagfield,tab,kohafield from marc_subfield_structure where kohafield like \"items.%\" and tab >=0");
$sth->execute;
my $field;
my $res;
my $res2;
my $tab;
($res,$res2,$field) = $sth->fetchrow;
my $tagfield = $res;
$tab = $res2;
my $subtotal=0;
#warn "TAGF : $tagfield";
while (($res,$res2,$field) = $sth->fetchrow) {
# (ignore itemnumber, that must be in -1 tab)
if (($res ne $tagfield) or ($res2 ne $tab)) {
$subtotal++;
}
}
$sth = $dbh->prepare("select kohafield from marc_subfield_structure where tagfield=?");
$sth->execute($tagfield);
while (($res2) = $sth->fetchrow) {
if (!$res2 || $res2 =~ /^items/) {
} else {
$subtotal++;
}
}
if ($subtotal == 0) {
$template->param(itemfields => 0);
} else {
$template->param(itemfields => 1);
$total++;
}
$sth = $dbh->prepare("select distinct tagfield from marc_subfield_structure where tab = 10");
$sth->execute;
my $totaltags = 0;
my $list = "";
while (($res2) = $sth->fetchrow) {
$totaltags++;
$list.=$res2.",";
}
if ($totaltags > 1) {
$template->param(itemtags => $list);
$total++;
} else {
$template->param(itemtags => 0);
}
# checks biblioitems.itemtype must be mapped and use authorised_value=itemtype
$sth = $dbh->prepare("select tagfield,tab,authorised_value from marc_subfield_structure where kohafield = \"biblioitems.itemtype\"");
$sth->execute;
while (($res,$res2,$field) = $sth->fetchrow) {
if ($res && $res2>=0 && $field eq "itemtypes") {
$template->param(itemtype => 0);
} else {
$template->param(itemtype => 1);
$total++;
last;
}
}
# checks items.homebranch must be mapped and use authorised_value=branches
$sth = $dbh->prepare("select tagfield,tab,authorised_value from marc_subfield_structure where kohafield = \"items.homebranch\"");
$sth->execute;
while (($res,$res2,$field) = $sth->fetchrow) {
if ($res && $res2 eq 10 && $field eq "branches") {
$template->param(branch => 0);
} else {
$template->param(branch => 1);
$total++;
last;
}
}
# checks items.homebranch must be mapped and use authorised_value=branches
$sth = $dbh->prepare("select tagfield,tab,authorised_value from marc_subfield_structure where kohafield = \"items.holdingbranch\"");
$sth->execute;
while (($res,$res2,$field) = $sth->fetchrow) {
if ($res && $res2 eq 10 && $field eq "branches") {
$template->param(holdingbranch => 0);
} else {
$template->param(holdingbranch => 1);
$total++;
last; #MR
}
}
# checks that itemtypes & branches tables are not empty
$sth = $dbh->prepare("select count(*) from itemtypes");
$sth->execute;
($res) = $sth->fetchrow;
if ($res) {
$template->param(itemtypes_empty =>0);
} else {
$template->param(itemtypes_empty =>1);
$total++;
}
$sth = $dbh->prepare("select count(*) from branches");
$sth->execute;
($res) = $sth->fetchrow;
if ($res) {
$template->param(branches_empty =>0);
} else {
$template->param(branches_empty =>1);
$total++;
}
$sth = $dbh->prepare("select count(*) from marc_subfield_structure where frameworkcode is NULL");
$sth->execute;
($res) = $sth->fetchrow;
if ($res) {
$template->param(frameworknull =>1);
$total++;
}
$sth = $dbh->prepare("select count(*) from marc_tag_structure where frameworkcode is NULL");
$sth->execute;
($res) = $sth->fetchrow;
if ($res) {
$template->param(frameworknull =>1);
$total++;
}
# verify that all of a field's subfields (except the ones explicitly ignored)
# are in the same tab
$sth = $dbh->prepare("SELECT tagfield, frameworkcode, frameworktext, GROUP_CONCAT(DISTINCT tab) AS tabs
FROM marc_subfield_structure
LEFT JOIN biblio_framework USING (frameworkcode)
WHERE tab != -1
GROUP BY tagfield, frameworkcode, frameworktext
HAVING COUNT(DISTINCT tab) > 1");
$sth->execute;
my $inconsistent_tabs = $sth->fetchall_arrayref({});
if (scalar(@$inconsistent_tabs) > 0) {
$total++;
$template->param(inconsistent_tabs => 1);
$template->param(tab_info => $inconsistent_tabs);
}
# verify that authtypecodes used in the framework
# are defined in auth_types
$sth = $dbh->prepare("SELECT frameworkcode, frameworktext, tagfield, tagsubfield, authtypecode
FROM marc_subfield_structure
LEFT JOIN biblio_framework USING (frameworkcode)
WHERE authtypecode IS NOT NULL
AND authtypecode <> ''
AND tab > '-1'
AND authtypecode NOT IN (SELECT authtypecode FROM auth_types)
ORDER BY frameworkcode, tagfield, tagsubfield");
$sth->execute;
my $invalid_authtypecodes = $sth->fetchall_arrayref({});
if (scalar(@$invalid_authtypecodes) > 0) {
$total++;
$template->param(invalid_authtypecodes => 1);
$template->param(authtypecode_info => $invalid_authtypecodes);
}
# checks items.permanent_location is not mapped
$sth = $dbh->prepare("SELECT frameworkcode, frameworktext, tagfield, tagsubfield
FROM marc_subfield_structure
LEFT JOIN biblio_framework USING (frameworkcode)
WHERE kohafield='permanent_location' OR
kohafield='items.permanent_location'");
$sth->execute;
my $permanent_location_mapped = $sth->fetchall_arrayref({});
if (scalar(@$permanent_location_mapped) > 0) {
$total++;
$template->param(permanent_location_mapped => 1);
$template->param(mapped_permanent_location => $permanent_location_mapped);
}
$template->param(total => $total,
);
output_html_with_http_headers $input, $cookie, $template->output;