252f4674a5
So far the administration module only allowed for 2 permissions:
- circulation conditions (manage_circ_rules)
- everything else (parameters_remaining_permissions)
With this patch almost every section of the administration page
will have its own granular permission.
To test:
- Create different staff users:
1) One with parameters_remaining_permissions
2) One with parameters
3) One with catalogue and no parameters
4) One superlibrarian
- Apply the patch
- Run the database update
- Check the staff users:
1) All subpermissions, but manage_circ_rules
should be checked
2) Nothing should have changed
3) manage_item_serach_fields shoudl be checked
(page had catalogue permission before)
4) Nothing should have changed
- Try different settings of the permissions and
verify that
- Administration page behaves correctly
- Administration menu behaves correctly
! You shoudl only see what you have permission for
https://bugs.koha-community.org/show_bug.cgi?id=14391
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
116 lines
3.6 KiB
Perl
Executable file
116 lines
3.6 KiB
Perl
Executable file
#! /usr/bin/perl
|
|
|
|
# Copyright 2006 SAN OUEST-PROVENCE et Paul POULAIN
|
|
# Copyright 2015 Koha Development Team
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
use CGI qw ( -utf8 );
|
|
use C4::Context;
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
|
|
use Koha::Cities;
|
|
|
|
my $input = new CGI;
|
|
my $searchfield = $input->param('city_name') // q||;
|
|
my $cityid = $input->param('cityid');
|
|
my $op = $input->param('op') || 'list';
|
|
my @messages;
|
|
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{ template_name => "admin/cities.tt",
|
|
query => $input,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { parameters => 'manage_cities' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
if ( $op eq 'add_form' ) {
|
|
my $city;
|
|
if ($cityid) {
|
|
$city = Koha::Cities->find($cityid);
|
|
}
|
|
|
|
$template->param( city => $city, );
|
|
} elsif ( $op eq 'add_validate' ) {
|
|
my $cityid = $input->param('cityid');
|
|
my $city_name = $input->param('city_name');
|
|
my $city_state = $input->param('city_state');
|
|
my $city_zipcode = $input->param('city_zipcode');
|
|
my $city_country = $input->param('city_country');
|
|
|
|
if ($cityid) {
|
|
my $city = Koha::Cities->find($cityid);
|
|
$city->city_name($city_name);
|
|
$city->city_state($city_state);
|
|
$city->city_zipcode($city_zipcode);
|
|
$city->city_country($city_country);
|
|
eval { $city->store; };
|
|
if ($@) {
|
|
push @messages, { type => 'error', code => 'error_on_update' };
|
|
} else {
|
|
push @messages, { type => 'message', code => 'success_on_update' };
|
|
}
|
|
} else {
|
|
my $city = Koha::City->new(
|
|
{ city_name => $city_name,
|
|
city_state => $city_state,
|
|
city_zipcode => $city_zipcode,
|
|
city_country => $city_country,
|
|
}
|
|
);
|
|
eval { $city->store; };
|
|
if ($@) {
|
|
push @messages, { type => 'error', code => 'error_on_insert' };
|
|
} else {
|
|
push @messages, { type => 'message', code => 'success_on_insert' };
|
|
}
|
|
}
|
|
$searchfield = q||;
|
|
$op = 'list';
|
|
} elsif ( $op eq 'delete_confirm' ) {
|
|
my $city = Koha::Cities->find($cityid);
|
|
$template->param( city => $city, );
|
|
} elsif ( $op eq 'delete_confirmed' ) {
|
|
my $city = Koha::Cities->find($cityid);
|
|
my $deleted = eval { $city->delete; };
|
|
|
|
if ( $@ or not $deleted ) {
|
|
push @messages, { type => 'error', code => 'error_on_delete' };
|
|
} else {
|
|
push @messages, { type => 'message', code => 'success_on_delete' };
|
|
}
|
|
$op = 'list';
|
|
}
|
|
|
|
if ( $op eq 'list' ) {
|
|
my $cities = Koha::Cities->search( { city_name => { -like => "%$searchfield%" } } );
|
|
$template->param( cities => $cities, );
|
|
}
|
|
|
|
$template->param(
|
|
cityid => $cityid,
|
|
searchfield => $searchfield,
|
|
messages => \@messages,
|
|
op => $op,
|
|
);
|
|
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|