57608fdecb
This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Follow-up: - Added 3 tests in t/db_dependent/Circulation_Branches.t to test AddReturn policies - Removed HomeOrHoldingBranchReturn from sysprefs.sql - Added notice on removing syspref in updatedatabase QA edits: - removed trailing whitespace in tests - moved branchname lookup from returns.pl to template Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> |
||
|---|---|---|
| .. | ||
| acquisitions.pref | ||
| admin.pref | ||
| authorities.pref | ||
| cataloguing.pref | ||
| circulation.pref | ||
| enhanced_content.pref | ||
| i18n_l10n.pref | ||
| local_use.pref | ||
| logs.pref | ||
| opac.pref | ||
| patrons.pref | ||
| searching.pref | ||
| serials.pref | ||
| staff_client.pref | ||
| tools.pref | ||
| web_services.pref | ||