Koha/course_reserves
Kyle M Hall 7d15ff3404
Bug 23727: Editing course reserve items is broken
Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged".

This patch set adds two new sets of columns to the course_items table.

The first set determines if the specified column should be swapped or
not. The was previously 'implied' by the column being set to undef which
has been the root problem with that way of knowing if a column should
swap or not.

The second set of new columns are for storing the item field values
while the item is on course reserve. Previously, the column values
were swapped between the items table and the course_items table,
which leaves ambiguity as to what each value is. Now, the original
columns *always* store the value when the item is on course reserve,
and the new storage columns store the original item value while the
item is on reserve, and are NULL when an item is *not* on reserve.

Test Plan:
1) Apply this patch
2) Add and edit course items, not the new checkboxes for enabling fields
3) Everything should function as before

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-04-17 13:45:56 +01:00
..
add_items.pl Bug 23727: Editing course reserve items is broken 2020-04-17 13:45:56 +01:00
batch_add_items.pl Bug 23727: Editing course reserve items is broken 2020-04-17 13:45:56 +01:00
course-details.pl Bug 19231: No need to pass the size to the template 2017-10-27 16:05:55 -03:00
course-reserves.pl Bug 21501: Remove dead code from course reserves module 2018-11-02 10:37:45 +00:00
course.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
mod_course.pl Bug 21349: Instructors with special characters in cardnumber cannot be removed from course reserves 2018-10-29 00:35:41 +00:00