Koha/circ
Jonathan Druart d864c5640a
Bug 24612: Make hold-transfer-slip take reserve_id
To make sure we are going to display the correct hold's info we need to
pass the reserve_id.

== Test plan ==
1. Add some content to HOLD_SLIP notice, e.g.

  <h2>[% branch.branchname %]</h2>
  <div>[% biblio.author %]<br>[% biblio.title %]<br>[% item.barcode %]
  <ul><li> Reserve ID:  [% hold.reserve_id %]</li>
  <li>Expiration date: [% hold.expirationdate %]</li></ul>

2. Add 2 holds for 1 patron to a single record
3. Check the reserve IDs in the reserves table - on a clean sandbox, they will be 1 and 2
4. Check in one of the items from the record and print the slip
5. Note that the reserve ID on the slip is 2 and the expiration date is blank
6. Repeated check ins do not change this
7. Check in a second item from the record
8. Note that the reserve ID for this hold is also 2, but this time the expiration date is filled in
9. Check in the first item again - the reserve ID stays as 2, but this time the expiration date is filled in
10. Apply patch
11. cancel the holds to come back to a clean state
    (and maybe ensure items aren't in transit)
12. redo the test and see the following differences
13. 1st checkin:
    1. expiration date ok
    2. the reserve ID is the one of the first hold
14. 2nd checkin:
    1. expiration date ok
    2. the reserve ID is the one of the second hold

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-05-22 09:33:16 +01:00
..
add_message.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
article-request-slip.pl Bug 20851: Add module to circ/article-request-slip.pl 2018-06-08 09:48:12 -04:00
article-requests.pl Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
bookcount.pl Bug 20661: Shortcut circ scripts if a blocking error appeared 2018-08-10 12:23:03 +00:00
branchoverdues.pl Bug 11529: Use new biblio fields whenever possible 2019-08-05 15:03:17 +01:00
branchtransfers.pl Bug 24837: Rename selectbranchprinter.pl to set-library.pl 2020-03-24 11:07:22 +00:00
checkout-notes.pl Bug 22617: Fix checkout notes typo in manage_checkout_notes permission usage 2019-06-21 13:09:53 +01:00
circulation-home.pl Bug 17698: (follow-up) Fixing things in Comment 57 2018-07-23 15:23:43 +00:00
circulation.pl Bug 24612: Make hold-transfer-slip take reserve_id 2020-05-22 09:33:16 +01:00
del_message.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
hold-transfer-slip.pl Bug 24612: Make hold-transfer-slip take reserve_id 2020-05-22 09:33:16 +01:00
offline-mf.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
offline.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
on-site_checkouts.pl Bug 17698: Do not send pending_checkout_notes from all circ scripts 2018-07-23 15:23:44 +00:00
overdue.pl Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
pendingreserves.pl Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
renew.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
request-article.pl Bug 21291: (follow-up) Pass subscriptionsnumber to all tools in staff detail's sidebar 2018-10-15 13:40:47 +00:00
reserveratios.pl Bug 24907: Add 'include suspended' to holds ratio report 2020-03-24 10:59:36 +00:00
returns.pl Bug 24612: Make hold-transfer-slip take reserve_id 2020-05-22 09:33:16 +01:00
set-library.pl Bug 24837: Rename selectbranchprinter.pl to set-library.pl 2020-03-24 11:07:22 +00:00
transfer-slip.pl Bug 19997: use Modern::Perl in Circulation perl scripts 2018-02-05 09:45:48 -03:00
transferstoreceive.pl Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
view_holdsqueue.pl Bug 17698: Do not send pending_checkout_notes from all circ scripts 2018-07-23 15:23:44 +00:00
waitingreserves.pl Bug 24436: Add handling for reserve transfer triggers 2020-03-20 15:59:45 +00:00
ypattrodue-attr-search-authvalue.pl Bug 19997: use Modern::Perl in Circulation perl scripts 2018-02-05 09:45:48 -03:00
ysearch.pl Bug 24750: Instructor Search Results 2020-04-27 11:29:24 +01:00