Main Koha release repository https://koha-community.org
Find a file
Julian Maurice 58edcef03d Bug 19036: Add ability to enable credit number for only some credit types
This feature is disabled by default for all credit types. To enable it
you have to set the syspref AutoCreditNumber to the value of your choice
and then enable the feature for each credit type you want.
System credit types can be modified too (but only this particular field
can be modified)

Also, throw an exception when the feature is enabled and a value for
credit_number has already been set

Updated test plan:
Test plan:
0. Apply patch, run updatedatabase and update_dbix_class_files
1. Go to Admin » Column settings, and uncheck the 'hidden' box for
   column credit_number in table account-fines. It will be easier for
   testing
2. Create a manual credit for a borrower. Verify in Transactions tab
   that this credit has no number generated
3. In Admin » Credit types:
  a. edit the FORGIVEN type and enable credit number generation
  b. create a new type A, check "can be manually added" and "enable
     credit number"
  c. create a new type B, check "can be manually added". Do NOT enable
     credit number
4. Change syspref 'AutoCreditNumber' to 'incremental'
5. Create more manual credits with types CREDIT and B, and verify that
   the numbers are not generated
6. Create more manual credits with types FORGIVEN and A, and verify that
   the numbers generated are 1, 2, 3, ...
7. Change syspref 'AutoCreditNumber' to 'annual'
8. Create more manual credits with types CREDIT and B, and verify that
   the numbers are not generated
9. Create more manual credits with types FORGIVEN and A, and verify that
   the numbers generated are '2020-0001', '2020-0002', ...
10. Change syspref to 'AutoCreditNumber' to 'branchyyyymmincr'
11. Create more manual credits with types CREDIT and B, and verify that
    the numbers are not generated
12. Create more manual credits with types FORGIVEN and A, and verify
    that the numbers generated are 'BRANCHA2020020001',
    'BRANCHA2020020002', ... (assuming you are connected to library
    BRANCHA, and it's February 2020)
13. Set library to another one, say BRANCHB
14. Create more manual credits with types FORGIVEN and A, and verify
    that the numbers generated are 'BRANCHB2020020001',
    'BRANCHB2020020002', ...
15. Edit the letter ACCOUNT_CREDIT, and add [% account.credit_number %]
    somewhere. Go back to Transactions tab and click on 'Print' for one
    line that has a credit number. Make sure the number is there.
16. prove t/db_dependent/Koha/Account.t

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-08-20 12:31:59 +02:00
acqui Bug 26134: (bug 23463 follow-up) Fix add to basket from staged file 2020-08-19 08:24:43 +02:00
admin Bug 19036: Add ability to enable credit number for only some credit types 2020-08-20 12:31:59 +02:00
api/v1 Bug 23820: Add checkout to default to patron's home branch on club hold 2020-07-20 17:45:30 +02:00
authorities Bug 25428: Correctly encode link if authority subfield is a URL 2020-05-22 09:33:16 +01:00
basket Bug 17842: Simplify the code 2020-06-12 10:32:35 +02:00
C4 Bug 25114: Remove duplicated logic from GetLoanLength() 2020-08-18 17:39:48 +02:00
catalogue Bug 5428: Jump back to the search result after deleting a record 2020-08-13 07:55:45 +02:00
cataloguing Bug 5428: Jump back to the search result after deleting a record 2020-08-13 07:55:45 +02:00
circ Bug 23695: Alter transferbook to take a hash of params and specify from_branch 2020-08-18 15:45:48 +02:00
clubs Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
course_reserves Bug 25606: Remove all reserve items button 2020-08-07 16:54:40 +02:00
debian Bug 25778: Fix var scope in koha-plack for PERL5LIB and KOHA_HOME 2020-08-18 15:45:49 +02:00
docs Bug 26179: Add Timothy Alexis Vass to contributors 2020-08-13 08:09:10 +02:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 24151: (follow-up) Rename the config key with 'bcrypt_settings' 2020-07-23 12:15:38 +02:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 19036: Add ability to enable credit number for only some credit types 2020-08-20 12:31:59 +02:00
Koha Bug 19036: Add ability to enable credit number for only some credit types 2020-08-20 12:31:59 +02:00
koha-tmpl Bug 19036: Add ability to enable credit number for only some credit types 2020-08-20 12:31:59 +02:00
labels Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
members Bug 6725: Make patron duplicate matching flexible 2020-08-18 17:39:48 +02:00
misc Bug 24591: Add --help option to misc/devel/get-prepared-letter.pl 2020-08-07 16:54:40 +02:00
offline_circ Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
opac Bug 16371: Combine get_daily_quote and get_daily_quote_for_interface 2020-08-13 10:15:33 +02:00
patron_lists
patroncards Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
plugins Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
pos Bug 26017: (follow-up) Serverside permission check on registers page 2020-08-06 11:37:06 +02:00
reports Bug 25605: Replace NULL values with '' when downloading a report as a tab separated text 2020-08-19 09:29:40 +02:00
reserve Bug 25516: Fix for "Can't call method unblessed on unblessed reference" 2020-05-19 08:29:34 +01:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections
serials Bug 25081: Fix wrong comment 2020-04-08 11:53:37 +01:00
services
skel
suggestion Bug 24819: (follow-up) Rename suggestor to suggester 2020-04-20 13:36:42 +01:00
svc Bug 26251: Remove unused routines from svc/split_callnumbers 2020-08-20 10:23:56 +02:00
t Bug 19036: Add ability to enable credit number for only some credit types 2020-08-20 12:31:59 +02:00
tags Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
tmp/modified_authorities
tools Bug 5428: (QA follow-up) Add searchid for deleting items in a batch and editing in batch 2020-08-13 07:55:45 +02:00
virtualshelves Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
xt Bug 22844: Fix yaml_valid.t - don't pick .json files 2020-07-21 09:47:11 +02:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json
.gitignore
.htaccess
.mailmap
.perlcriticrc Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
.scss-lint.yml
about.pl Bug 25826: Add a warning to the about page 2020-08-07 09:55:50 +02:00
changelanguage.pl
cpanfile Bug 25723: Drop DateTime::Set from cpanfile 2020-07-20 17:45:31 +02:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
gulpfile.js Bug 26228: Update gulpfile to work with Node.js v12 2020-08-18 14:47:44 +02:00
help.pl
INSTALL
Koha.pm Bug 6725: DBRev 20.06.00.025 2020-08-18 17:41:49 +02:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl
LICENSE
mainpage.pl Bug 16371: Combine get_daily_quote and get_daily_quote_for_interface 2020-08-13 10:15:33 +02:00
Makefile.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-07-21 14:34:25 +02:00
MANIFEST.SKIP
package.json Bug 26228: Update gulpfile to work with Node.js v12 2020-08-18 14:47:44 +02:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md
README.robots
rewrite-config.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-07-21 14:34:25 +02:00
yarn.lock Bug 26228: Update gulpfile to work with Node.js v12 2020-08-18 14:47:44 +02:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo