Marcel de Rooy
590cae04fd
After feedback from the dev mailing list, it seems appropriate here to propose making the Default framework authoritative for Koha to MARC mappings. This implies checking only the Default framework in the routines: [1] GetMarcFromKohaField: The parameter frameworkcode is removed. A follow-up report (19097) will update the calls not adjusted here. This is safe since the parameter is silently ignored. [2] GetMarcSubfieldStructureFromKohaField: Framework parameter is removed and calls are adjusted. Includes acquisitions_stats.pl. [3] TransformKohaToMarc: The parameter is removed; all calls are verified or adjusted. [4] TransformMarcToKoha: The parameter is no longer used and will be removed in a follow-up report (19097). It always goes to Default now. [5] TransformMarcToKohaOneField: The parameter is removed and all calls are adjusted. Including: Breeding, XISBN and MetadataRecord modules. [6] C4::Koha::IsKohaFieldLinked: This routine was called only once (in C4::Items::_build_default_values_for_mod_marc. It can be replaced by calling GetMarcFromKohaField. If there is no kohafield linked, undef is returned. (Corresponding unit test is removed here.) [7] C4::Items::ModItemFromMarc: The helper routine _build_default_values_for_mod_marc does no longer have a framework parameter. The cache key default_value_for_mod_marc- is no longer combined with a frameworkcode. Three admin scripts are adjusted accordingly; some tests will be corrected in the next patch. Test plan: See next patch. That patch adjusts all tests involved. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
429 lines
17 KiB
Perl
Executable file
429 lines
17 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2000-2002 Katipo Communications
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
use C4::Output;
|
|
use C4::Auth;
|
|
use CGI qw ( -utf8 );
|
|
use C4::Context;
|
|
|
|
use Koha::Authority::Types;
|
|
use Koha::AuthorisedValueCategories;
|
|
|
|
use List::MoreUtils qw( uniq );
|
|
|
|
sub string_search {
|
|
my ( $searchstring, $frameworkcode ) = @_;
|
|
my $dbh = C4::Context->dbh;
|
|
$searchstring =~ s/\'/\\\'/g;
|
|
my @data = split( ' ', $searchstring );
|
|
my $count = @data;
|
|
my $sth =
|
|
$dbh->prepare(
|
|
"Select * from marc_subfield_structure where (tagfield like ? and frameworkcode=?) order by tagfield"
|
|
);
|
|
$sth->execute( "$searchstring%", $frameworkcode );
|
|
my @results;
|
|
my $cnt = 0;
|
|
my $u = 1;
|
|
|
|
while ( my $data = $sth->fetchrow_hashref ) {
|
|
push( @results, $data );
|
|
$cnt++;
|
|
$u++;
|
|
}
|
|
$sth->finish;
|
|
return ( $cnt, \@results );
|
|
}
|
|
|
|
sub marc_subfield_structure_exists {
|
|
my ($tagfield, $tagsubfield, $frameworkcode) = @_;
|
|
my $dbh = C4::Context->dbh;
|
|
my $sql = "select tagfield from marc_subfield_structure where tagfield = ? and tagsubfield = ? and frameworkcode = ?";
|
|
my $rows = $dbh->selectall_arrayref($sql, {}, $tagfield, $tagsubfield, $frameworkcode);
|
|
return @$rows > 0;
|
|
}
|
|
|
|
my $input = new CGI;
|
|
my $tagfield = $input->param('tagfield');
|
|
my $tagsubfield = $input->param('tagsubfield');
|
|
my $frameworkcode = $input->param('frameworkcode');
|
|
my $pkfield = "tagfield";
|
|
my $offset = $input->param('offset');
|
|
$offset = 0 if not defined $offset or $offset < 0;
|
|
my $script_name = "/cgi-bin/koha/admin/marc_subfields_structure.pl";
|
|
|
|
my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "admin/marc_subfields_structure.tt",
|
|
query => $input,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { parameters => 'parameters_remaining_permissions' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
my $cache = Koha::Caches->get_instance();
|
|
|
|
my $op = $input->param('op') || "";
|
|
$tagfield =~ s/\,//g;
|
|
|
|
if ($op) {
|
|
$template->param(
|
|
script_name => $script_name,
|
|
tagfield => $tagfield,
|
|
frameworkcode => $frameworkcode,
|
|
$op => 1
|
|
); # we show only the TMPL_VAR names $op
|
|
}
|
|
else {
|
|
$template->param(
|
|
script_name => $script_name,
|
|
tagfield => $tagfield,
|
|
frameworkcode => $frameworkcode,
|
|
else => 1
|
|
); # we show only the TMPL_VAR names $op
|
|
}
|
|
|
|
################## ADD_FORM ##################################
|
|
# called by default. Used to create form to add or modify a record
|
|
if ( $op eq 'add_form' ) {
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
# builds kohafield tables
|
|
my @kohafields;
|
|
push @kohafields, "";
|
|
my $sth2 = $dbh->prepare("SHOW COLUMNS from biblio");
|
|
$sth2->execute;
|
|
while ( ( my $field ) = $sth2->fetchrow_array ) {
|
|
push @kohafields, "biblio." . $field;
|
|
}
|
|
$sth2 = $dbh->prepare("SHOW COLUMNS from biblioitems");
|
|
$sth2->execute;
|
|
while ( ( my $field ) = $sth2->fetchrow_array ) {
|
|
if ( $field eq 'notes' ) { $field = 'bnotes'; }
|
|
push @kohafields, "biblioitems." . $field;
|
|
}
|
|
$sth2 = $dbh->prepare("SHOW COLUMNS from items");
|
|
$sth2->execute;
|
|
while ( ( my $field ) = $sth2->fetchrow_array ) {
|
|
push @kohafields, "items." . $field;
|
|
}
|
|
|
|
# build authorised value list
|
|
$sth2->finish;
|
|
$sth2 = $dbh->prepare("select distinct category from authorised_values");
|
|
$sth2->execute;
|
|
my @av_cat = Koha::AuthorisedValueCategories->search;
|
|
my @authorised_values = map { $_->category_name } @av_cat;
|
|
|
|
# build thesaurus categories list
|
|
my @authtypes = uniq( "", map { $_->authtypecode } Koha::Authority::Types->search );
|
|
|
|
# build value_builder list
|
|
my @value_builder = ('');
|
|
|
|
# read value_builder directory.
|
|
# 2 cases here : on CVS install, $cgidir does not need a /cgi-bin
|
|
# on a standard install, /cgi-bin need to be added.
|
|
# test one, then the other
|
|
my $cgidir = C4::Context->config('intranetdir') . "/cgi-bin";
|
|
unless ( opendir( DIR, "$cgidir/cataloguing/value_builder" ) ) {
|
|
$cgidir = C4::Context->config('intranetdir');
|
|
opendir( DIR, "$cgidir/cataloguing/value_builder" )
|
|
|| die "can't opendir $cgidir/value_builder: $!";
|
|
}
|
|
while ( my $line = readdir(DIR) ) {
|
|
if ( $line =~ /\.pl$/ &&
|
|
$line !~ /EXAMPLE\.pl$/ ) { # documentation purposes
|
|
push( @value_builder, $line );
|
|
}
|
|
}
|
|
@value_builder= sort {$a cmp $b} @value_builder;
|
|
closedir DIR;
|
|
|
|
# build values list
|
|
my $sth =
|
|
$dbh->prepare(
|
|
"select * from marc_subfield_structure where tagfield=? and frameworkcode=?"
|
|
); # and tagsubfield='$tagsubfield'");
|
|
$sth->execute( $tagfield, $frameworkcode );
|
|
my @loop_data = ();
|
|
my $i = 0;
|
|
while ( my $data = $sth->fetchrow_hashref ) {
|
|
my %row_data; # get a fresh hash for the row data
|
|
$row_data{defaultvalue} = $data->{defaultvalue};
|
|
$row_data{maxlength} = $data->{maxlength};
|
|
$row_data{tab} = $data->{tab};
|
|
$row_data{tagsubfield} = $data->{tagsubfield};
|
|
$row_data{subfieldcode} = $data->{'tagsubfield'} eq '@' ? '_' : $data->{'tagsubfield'};
|
|
$row_data{urisubfieldcode} = $row_data{subfieldcode} eq '%' ? 'pct' : $row_data{subfieldcode};
|
|
$row_data{liblibrarian} = $data->{'liblibrarian'};
|
|
$row_data{libopac} = $data->{'libopac'};
|
|
$row_data{seealso} = $data->{'seealso'};
|
|
$row_data{kohafields} = \@kohafields;
|
|
$row_data{kohafield} = $data->{kohafield};
|
|
$row_data{authorised_values} = \@authorised_values;
|
|
$row_data{authorised_value} = $data->{authorised_value};
|
|
$row_data{value_builders} = \@value_builder;
|
|
$row_data{value_builder} = $data->{'value_builder'};
|
|
$row_data{authtypes} = \@authtypes;
|
|
$row_data{authtypecode} = $data->{'authtypecode'};
|
|
$row_data{repeatable} = $data->{repeatable};
|
|
$row_data{mandatory} = $data->{mandatory};
|
|
$row_data{hidden} = $data->{hidden};
|
|
$row_data{isurl} = $data->{isurl};
|
|
$row_data{row} = $i;
|
|
$row_data{link} = $data->{'link'};
|
|
push( @loop_data, \%row_data );
|
|
$i++;
|
|
}
|
|
|
|
# Add a new row for the "New" tab
|
|
my %row_data; # get a fresh hash for the row data
|
|
$row_data{'new_subfield'} = 1;
|
|
$row_data{'subfieldcode'} = '';
|
|
$row_data{'maxlength'} = 9999;
|
|
$row_data{tab} = -1; #ignore
|
|
$row_data{tagsubfield} = "";
|
|
$row_data{liblibrarian} = "";
|
|
$row_data{libopac} = "";
|
|
$row_data{seealso} = "";
|
|
$row_data{hidden} = "";
|
|
$row_data{repeatable} = 0;
|
|
$row_data{mandatory} = 0;
|
|
$row_data{isurl} = 0;
|
|
$row_data{kohafields} = \@kohafields;
|
|
$row_data{authorised_values} = \@authorised_values;
|
|
$row_data{value_builders} = \@value_builder;
|
|
$row_data{authtypes} = \@authtypes;
|
|
$row_data{link} = "";
|
|
$row_data{row} = $i;
|
|
push( @loop_data, \%row_data );
|
|
|
|
$template->param( 'use_heading_flags_p' => 1 );
|
|
$template->param( 'heading_edit_subfields_p' => 1 );
|
|
$template->param(
|
|
action => "Edit subfields",
|
|
tagfield => $tagfield,
|
|
loop => \@loop_data,
|
|
more_tag => $tagfield
|
|
);
|
|
|
|
# END $OP eq ADD_FORM
|
|
################## ADD_VALIDATE ##################################
|
|
# called by add_form, used to insert/modify data in DB
|
|
}
|
|
elsif ( $op eq 'add_validate' ) {
|
|
my $dbh = C4::Context->dbh;
|
|
$template->param( tagfield => "$input->param('tagfield')" );
|
|
# my $sth = $dbh->prepare(
|
|
# "replace marc_subfield_structure (tagfield,tagsubfield,liblibrarian,libopac,repeatable,mandatory,kohafield,tab,seealso,authorised_value,authtypecode,value_builder,hidden,isurl,frameworkcode, link,defaultvalue)
|
|
# values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)"
|
|
# );
|
|
my $sth_insert = $dbh->prepare(qq{
|
|
insert into marc_subfield_structure (tagfield,tagsubfield,liblibrarian,libopac,repeatable,mandatory,kohafield,tab,seealso,authorised_value,authtypecode,value_builder,hidden,isurl,frameworkcode, link,defaultvalue,maxlength)
|
|
values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)
|
|
});
|
|
my $sth_update = $dbh->prepare(qq{
|
|
update marc_subfield_structure set tagfield=?, tagsubfield=?, liblibrarian=?, libopac=?, repeatable=?, mandatory=?, kohafield=?, tab=?, seealso=?, authorised_value=?, authtypecode=?, value_builder=?, hidden=?, isurl=?, frameworkcode=?, link=?, defaultvalue=?, maxlength=?
|
|
where tagfield=? and tagsubfield=? and frameworkcode=?
|
|
});
|
|
my @tagsubfield = $input->multi_param('tagsubfield');
|
|
my @liblibrarian = $input->multi_param('liblibrarian');
|
|
my @libopac = $input->multi_param('libopac');
|
|
my @kohafield = $input->multi_param('kohafield');
|
|
my @tab = $input->multi_param('tab');
|
|
my @seealso = $input->multi_param('seealso');
|
|
my @hidden = $input->multi_param('hidden');
|
|
my @authorised_values = $input->multi_param('authorised_value');
|
|
my @authtypecodes = $input->multi_param('authtypecode');
|
|
my @value_builder = $input->multi_param('value_builder');
|
|
my @link = $input->multi_param('link');
|
|
my @defaultvalue = $input->multi_param('defaultvalue');
|
|
my @maxlength = $input->multi_param('maxlength');
|
|
|
|
for ( my $i = 0 ; $i <= $#tagsubfield ; $i++ ) {
|
|
my $tagfield = $input->param('tagfield');
|
|
my $tagsubfield = $tagsubfield[$i];
|
|
$tagsubfield = "@" unless $tagsubfield ne '';
|
|
$tagsubfield = "@" if $tagsubfield eq '_';
|
|
my $liblibrarian = $liblibrarian[$i];
|
|
my $libopac = $libopac[$i];
|
|
my $repeatable = $input->param("repeatable$i") ? 1 : 0;
|
|
my $mandatory = $input->param("mandatory$i") ? 1 : 0;
|
|
my $kohafield = $kohafield[$i];
|
|
my $tab = $tab[$i];
|
|
my $seealso = $seealso[$i];
|
|
my $authorised_value = $authorised_values[$i];
|
|
my $authtypecode = $authtypecodes[$i];
|
|
my $value_builder = $value_builder[$i];
|
|
my $hidden = $hidden[$i]; #input->param("hidden$i");
|
|
my $isurl = $input->param("isurl$i") ? 1 : 0;
|
|
my $link = $link[$i];
|
|
my $defaultvalue = $defaultvalue[$i];
|
|
my $maxlength = $maxlength[$i] ? $maxlength[$i] : 9999;
|
|
|
|
if (defined($liblibrarian) && $liblibrarian ne "") {
|
|
my $is_demo = C4::Context->config('demo') || '';
|
|
if ( $is_demo ne '1' ) {
|
|
if (marc_subfield_structure_exists($tagfield, $tagsubfield, $frameworkcode)) {
|
|
$sth_update->execute(
|
|
$tagfield,
|
|
$tagsubfield,
|
|
$liblibrarian,
|
|
$libopac,
|
|
$repeatable,
|
|
$mandatory,
|
|
$kohafield,
|
|
$tab,
|
|
$seealso,
|
|
$authorised_value,
|
|
$authtypecode,
|
|
$value_builder,
|
|
$hidden,
|
|
$isurl,
|
|
$frameworkcode,
|
|
$link,
|
|
$defaultvalue,
|
|
$maxlength,
|
|
(
|
|
$tagfield,
|
|
$tagsubfield,
|
|
$frameworkcode,
|
|
),
|
|
);
|
|
} else {
|
|
$sth_insert->execute(
|
|
$tagfield,
|
|
$tagsubfield,
|
|
$liblibrarian,
|
|
$libopac,
|
|
$repeatable,
|
|
$mandatory,
|
|
$kohafield,
|
|
$tab,
|
|
$seealso,
|
|
$authorised_value,
|
|
$authtypecode,
|
|
$value_builder,
|
|
$hidden,
|
|
$isurl,
|
|
$frameworkcode,
|
|
$link,
|
|
$defaultvalue,
|
|
$maxlength,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
$sth_insert->finish;
|
|
$sth_update->finish;
|
|
$cache->clear_from_cache("MarcStructure-0-$frameworkcode");
|
|
$cache->clear_from_cache("MarcStructure-1-$frameworkcode");
|
|
$cache->clear_from_cache("default_value_for_mod_marc-");
|
|
$cache->clear_from_cache("MarcSubfieldStructure-$frameworkcode");
|
|
|
|
print $input->redirect("/cgi-bin/koha/admin/marc_subfields_structure.pl?tagfield=$tagfield&frameworkcode=$frameworkcode");
|
|
exit;
|
|
|
|
# END $OP eq ADD_VALIDATE
|
|
################## DELETE_CONFIRM ##################################
|
|
# called by default form, used to confirm deletion of data in DB
|
|
}
|
|
elsif ( $op eq 'delete_confirm' ) {
|
|
my $dbh = C4::Context->dbh;
|
|
my $sth =
|
|
$dbh->prepare(
|
|
"select * from marc_subfield_structure where tagfield=? and tagsubfield=? and frameworkcode=?"
|
|
);
|
|
|
|
$sth->execute( $tagfield, $tagsubfield, $frameworkcode );
|
|
my $data = $sth->fetchrow_hashref;
|
|
$sth->finish;
|
|
$template->param(
|
|
liblibrarian => $data->{'liblibrarian'},
|
|
tagsubfield => $data->{'tagsubfield'},
|
|
delete_link => $script_name,
|
|
tagfield => $tagfield,
|
|
tagsubfield => $tagsubfield,
|
|
frameworkcode => $frameworkcode,
|
|
);
|
|
|
|
# END $OP eq DELETE_CONFIRM
|
|
################## DELETE_CONFIRMED ##################################
|
|
# called by delete_confirm, used to effectively confirm deletion of data in DB
|
|
}
|
|
elsif ( $op eq 'delete_confirmed' ) {
|
|
my $dbh = C4::Context->dbh;
|
|
my $is_demo = C4::Context->config('demo') || '';
|
|
if ( $is_demo ne '1' ) {
|
|
my $sth =
|
|
$dbh->prepare(
|
|
"delete from marc_subfield_structure where tagfield=? and tagsubfield=? and frameworkcode=?"
|
|
);
|
|
$sth->execute( $tagfield, $tagsubfield, $frameworkcode );
|
|
$sth->finish;
|
|
}
|
|
$cache->clear_from_cache("MarcStructure-0-$frameworkcode");
|
|
$cache->clear_from_cache("MarcStructure-1-$frameworkcode");
|
|
$cache->clear_from_cache("default_value_for_mod_marc-");
|
|
$cache->clear_from_cache("MarcSubfieldStructure-$frameworkcode");
|
|
print $input->redirect("/cgi-bin/koha/admin/marc_subfields_structure.pl?tagfield=$tagfield&frameworkcode=$frameworkcode");
|
|
exit;
|
|
|
|
# END $OP eq DELETE_CONFIRMED
|
|
################## DEFAULT ##################################
|
|
}
|
|
else { # DEFAULT
|
|
my ( $count, $results ) = string_search( $tagfield, $frameworkcode );
|
|
my @loop_data = ();
|
|
for ( my $i = 0; $i < $count; $i++ ) {
|
|
my %row_data; # get a fresh hash for the row data
|
|
$row_data{tagfield} = $results->[$i]{'tagfield'};
|
|
$row_data{tagsubfield} = $results->[$i]{'tagsubfield'};
|
|
$row_data{liblibrarian} = $results->[$i]{'liblibrarian'};
|
|
$row_data{kohafield} = $results->[$i]{'kohafield'};
|
|
$row_data{repeatable} = $results->[$i]{'repeatable'};
|
|
$row_data{mandatory} = $results->[$i]{'mandatory'};
|
|
$row_data{tab} = $results->[$i]{'tab'};
|
|
$row_data{seealso} = $results->[$i]{'seealso'};
|
|
$row_data{authorised_value} = $results->[$i]{'authorised_value'};
|
|
$row_data{authtypecode} = $results->[$i]{'authtypecode'};
|
|
$row_data{value_builder} = $results->[$i]{'value_builder'};
|
|
$row_data{hidden} = $results->[$i]{'hidden'};
|
|
$row_data{isurl} = $results->[$i]{'isurl'};
|
|
$row_data{link} = $results->[$i]{'link'};
|
|
|
|
if ( $row_data{tab} eq -1 ) {
|
|
$row_data{subfield_ignored} = 1;
|
|
}
|
|
|
|
push( @loop_data, \%row_data );
|
|
}
|
|
$template->param( loop => \@loop_data );
|
|
$template->param(
|
|
edit_tagfield => $tagfield,
|
|
edit_frameworkcode => $frameworkcode
|
|
);
|
|
|
|
} #---- END $OP eq DEFAULT
|
|
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|