Tomas Cohen Arazi
3cd669e527
This patch changes the params accepted by C4::Circulation::MarkIssueReturned by removing the $dropbox_branch param. This passed branchcode was only used to initialize the Koha::Calendar object, but the date arithmetic has already taken place in a couple places before we reach this point. This logic needs to be simplified (bug 14591), and this is the starting point. To test: - Apply this patch - Run: $ git grep MarkIssueReturned => SUCCESS: Check all the uses of the function either originally passed undef, or now pass the same date that would've been calculated anyway, in the returndate param. - Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> |
||
---|---|---|
.. | ||
holds | ||
rss | ||
social_data | ||
thirdparty | ||
advance_notices.pl | ||
automatic_item_modification_by_age.pl | ||
automatic_renewals.pl | ||
backup.sh | ||
batch_anonymise.pl | ||
build_browser_and_cloud.pl | ||
cart_to_shelf.pl | ||
check-url-quick.pl | ||
check-url.pl | ||
cleanup_database.pl | ||
cloud-kw.pl | ||
cloud-sample.conf | ||
CONFIGURE.gmail | ||
create_koc_db.pl | ||
crontab.example | ||
delete_expired_opac_registrations.pl | ||
delete_items.pl | ||
delete_patrons.pl | ||
delete_records_via_leader.pl | ||
edi_cron.pl | ||
fines.pl | ||
gather_print_notices.pl | ||
import_webservice_batch.pl | ||
j2a.pl | ||
longoverdue.pl | ||
membership_expiry.pl | ||
merge_authorities.pl | ||
notice_unprocessed_suggestions.pl | ||
overdue_notices.pl | ||
printoverdues.sh | ||
process_message_queue.pl | ||
purge_suggestions.pl | ||
reconcile_balances.pl | ||
remove_temporary_edifiles.pl | ||
runreport.pl | ||
serialsUpdate.pl | ||
share_usage_with_koha_community.pl | ||
sitemap.pl | ||
staticfines.pl | ||
stockrotation.pl | ||
update_totalissues.pl |