Marcel de Rooy
8c510e1a92
Similar to the full path test in sub themelanguage, this patch makes a change in _get_template_file. This allows you to pass a template outside the modules directory to get_template_and_user. (Note: the sub badtemplatecheck already blocks bad paths.) Especially, this would be helpful for plugins using templates. As can be seen in Templates.pm, a change was made earlier to overwrite the filename for a plugin in sub gettemplate. This exception can now be removed. Also note the small change in Koha/Plugin/Base.pm; mbf_path is already absolute and if we pass a full path, we do not need it. This allows use of a regular Koha template or a shared template between plugins (as long as badtemplatecheck allows the path). What are the side-effects of this change? [1] We should not pass absolute paths if we mean relative ones. A follow-up patch deals with one occurrence in the codebase. No regressions for regular use. [2] Plugins can call get_template_and_user directly or go via get_template in Koha/Plugin/Base (absolute paths don't go via mbf_path). Note: replaced two single quotes in Auth.pm to show template name in test description. Test plan: [1] Open some page on OPAC or staff client to trigger a template. [2] Run t/db_dependent/Auth.t to verify not allowing some bad templates. [3] Run t/db_dependent/Templates.t to verify an absolute path. [4] Run t/db_dependent/Plugins.t to verify using templates in a plugin. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
239 lines
8.2 KiB
Perl
239 lines
8.2 KiB
Perl
#!/usr/bin/perl
|
|
#
|
|
# This Koha test module is a stub!
|
|
# Add more tests here!!!
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
|
|
use Test::MockObject;
|
|
use Test::MockModule;
|
|
use List::MoreUtils qw/all any none/;
|
|
use Test::More tests => 21;
|
|
use Test::Warn;
|
|
use t::lib::Mocks;
|
|
use t::lib::TestBuilder;
|
|
|
|
use C4::Auth qw(checkpw);
|
|
use C4::Members;
|
|
use Koha::AuthUtils qw/hash_password/;
|
|
use Koha::Database;
|
|
use Koha::Patrons;
|
|
|
|
BEGIN {
|
|
use_ok('C4::Auth');
|
|
}
|
|
|
|
my $schema = Koha::Database->schema;
|
|
my $builder = t::lib::TestBuilder->new;
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
# FIXME: SessionStorage defaults to mysql, but it seems to break transaction
|
|
# handling
|
|
t::lib::Mocks::mock_preference( 'SessionStorage', 'tmp' );
|
|
|
|
$schema->storage->txn_begin;
|
|
|
|
subtest 'checkauth() tests' => sub {
|
|
|
|
plan tests => 2;
|
|
|
|
my $patron = $builder->build({ source => 'Borrower', value => { flags => undef } })->{userid};
|
|
|
|
# Mock a CGI object with real userid param
|
|
my $cgi = Test::MockObject->new();
|
|
$cgi->mock( 'param', sub { return $patron; } );
|
|
$cgi->mock( 'cookie', sub { return; } );
|
|
|
|
my $authnotrequired = 1;
|
|
my ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, $authnotrequired );
|
|
|
|
is( $userid, undef, 'checkauth() returns undef for userid if no logged in user (Bug 18275)' );
|
|
|
|
my $db_user_id = C4::Context->config('user');
|
|
my $db_user_pass = C4::Context->config('pass');
|
|
$cgi = Test::MockObject->new();
|
|
$cgi->mock( 'cookie', sub { return; } );
|
|
$cgi->mock( 'param', sub {
|
|
my ( $self, $param ) = @_;
|
|
if ( $param eq 'userid' ) { return $db_user_id; }
|
|
elsif ( $param eq 'password' ) { return $db_user_pass; }
|
|
else { return; }
|
|
});
|
|
( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, $authnotrequired );
|
|
is ( $userid, $db_user_id, 'If DB user is logging in, it should be considered as logged in, i.e. checkauth return the relevant userid' );
|
|
C4::Context->_new_userenv; # For next tests
|
|
|
|
};
|
|
|
|
my $hash1 = hash_password('password');
|
|
my $hash2 = hash_password('password');
|
|
|
|
{ # tests no_set_userenv parameter
|
|
my $patron = $builder->build( { source => 'Borrower' } );
|
|
Koha::Patrons->find( $patron->{borrowernumber} )->update_password( $patron->{userid}, $hash1 );
|
|
my $library = $builder->build(
|
|
{
|
|
source => 'Branch',
|
|
}
|
|
);
|
|
|
|
ok( checkpw( $dbh, $patron->{userid}, 'password', undef, undef, 1 ), 'checkpw returns true' );
|
|
is( C4::Context->userenv, undef, 'Userenv should be undef as required' );
|
|
C4::Context->_new_userenv('DUMMY SESSION');
|
|
C4::Context->set_userenv(0,0,0,'firstname','surname', $library->{branchcode}, 'Library 1', 0, '', '');
|
|
is( C4::Context->userenv->{branch}, $library->{branchcode}, 'Userenv gives correct branch' );
|
|
ok( checkpw( $dbh, $patron->{userid}, 'password', undef, undef, 1 ), 'checkpw returns true' );
|
|
is( C4::Context->userenv->{branch}, $library->{branchcode}, 'Userenv branch is preserved if no_set_userenv is true' );
|
|
ok( checkpw( $dbh, $patron->{userid}, 'password', undef, undef, 0 ), 'checkpw still returns true' );
|
|
isnt( C4::Context->userenv->{branch}, $library->{branchcode}, 'Userenv branch is overwritten if no_set_userenv is false' );
|
|
}
|
|
|
|
# get_template_and_user tests
|
|
|
|
{ # Tests for the language URL parameter
|
|
|
|
sub MockedCheckauth {
|
|
my ($query,$authnotrequired,$flagsrequired,$type) = @_;
|
|
# return vars
|
|
my $userid = 'cobain';
|
|
my $sessionID = 234;
|
|
# we don't need to bother about permissions for this test
|
|
my $flags = {
|
|
superlibrarian => 1, acquisition => 0,
|
|
borrowers => 0,
|
|
catalogue => 1, circulate => 0,
|
|
coursereserves => 0, editauthorities => 0,
|
|
editcatalogue => 0, management => 0,
|
|
parameters => 0, permissions => 0,
|
|
plugins => 0, reports => 0,
|
|
reserveforothers => 0, serials => 0,
|
|
staffaccess => 0, tools => 0,
|
|
updatecharges => 0
|
|
};
|
|
|
|
my $session_cookie = $query->cookie(
|
|
-name => 'CGISESSID',
|
|
-value => 'nirvana',
|
|
-HttpOnly => 1
|
|
);
|
|
|
|
return ( $userid, $session_cookie, $sessionID, $flags );
|
|
}
|
|
|
|
# Mock checkauth, build the scenario
|
|
my $auth = new Test::MockModule( 'C4::Auth' );
|
|
$auth->mock( 'checkauth', \&MockedCheckauth );
|
|
|
|
# Make sure 'EnableOpacSearchHistory' is set
|
|
t::lib::Mocks::mock_preference('EnableOpacSearchHistory',1);
|
|
# Enable es-ES for the OPAC and staff interfaces
|
|
t::lib::Mocks::mock_preference('opaclanguages','en,es-ES');
|
|
t::lib::Mocks::mock_preference('language','en,es-ES');
|
|
|
|
# we need a session cookie
|
|
$ENV{"SERVER_PORT"} = 80;
|
|
$ENV{"HTTP_COOKIE"} = 'CGISESSID=nirvana';
|
|
|
|
my $query = new CGI;
|
|
$query->param('language','es-ES');
|
|
|
|
my ( $template, $loggedinuser, $cookies ) = get_template_and_user(
|
|
{
|
|
template_name => "about.tt",
|
|
query => $query,
|
|
type => "opac",
|
|
authnotrequired => 1,
|
|
flagsrequired => { catalogue => 1 },
|
|
debug => 1
|
|
}
|
|
);
|
|
|
|
ok ( ( all { ref($_) eq 'CGI::Cookie' } @$cookies ),
|
|
'BZ9735: the cookies array is flat' );
|
|
|
|
# new query, with non-existent language (we only have en and es-ES)
|
|
$query->param('language','tomas');
|
|
|
|
( $template, $loggedinuser, $cookies ) = get_template_and_user(
|
|
{
|
|
template_name => "about.tt",
|
|
query => $query,
|
|
type => "opac",
|
|
authnotrequired => 1,
|
|
flagsrequired => { catalogue => 1 },
|
|
debug => 1
|
|
}
|
|
);
|
|
|
|
ok( ( none { $_->name eq 'KohaOpacLanguage' and $_->value eq 'tomas' } @$cookies ),
|
|
'BZ9735: invalid language, it is not set');
|
|
|
|
ok( ( any { $_->name eq 'KohaOpacLanguage' and $_->value eq 'en' } @$cookies ),
|
|
'BZ9735: invalid language, then default to en');
|
|
|
|
for my $template_name (
|
|
qw(
|
|
../../../../../../../../../../../../../../../etc/passwd
|
|
test/../../../../../../../../../../../../../../etc/passwd
|
|
/etc/passwd
|
|
test/does_not_finished_by_tt_t
|
|
)
|
|
) {
|
|
eval {
|
|
( $template, $loggedinuser, $cookies ) = get_template_and_user(
|
|
{
|
|
template_name => $template_name,
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 1,
|
|
flagsrequired => { catalogue => 1 },
|
|
}
|
|
);
|
|
};
|
|
like ( $@, qr(^bad template path), "The file $template_name should not be accessible" );
|
|
}
|
|
( $template, $loggedinuser, $cookies ) = get_template_and_user(
|
|
{
|
|
template_name => 'errors/errorpage.tt',
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 1,
|
|
flagsrequired => { catalogue => 1 },
|
|
}
|
|
);
|
|
my $file_exists = ( -f $template->{filename} ) ? 1 : 0;
|
|
is ( $file_exists, 1, 'The file errors/errorpage.tt should be accessible (contains integers)' );
|
|
}
|
|
|
|
# Check that there is always an OPACBaseURL set.
|
|
my $input = CGI->new();
|
|
my ( $template1, $borrowernumber, $cookie );
|
|
( $template1, $borrowernumber, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "opac-detail.tt",
|
|
type => "opac",
|
|
query => $input,
|
|
authnotrequired => 1,
|
|
}
|
|
);
|
|
|
|
ok( ( any { 'OPACBaseURL' eq $_ } keys %{$template1->{VARS}} ),
|
|
'OPACBaseURL is in OPAC template' );
|
|
|
|
my ( $template2 );
|
|
( $template2, $borrowernumber, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "catalogue/detail.tt",
|
|
type => "intranet",
|
|
query => $input,
|
|
authnotrequired => 1,
|
|
}
|
|
);
|
|
|
|
ok( ( any { 'OPACBaseURL' eq $_ } keys %{$template2->{VARS}} ),
|
|
'OPACBaseURL is in Staff template' );
|
|
|
|
ok(C4::Auth::checkpw_hash('password', $hash1), 'password validates with first hash');
|
|
ok(C4::Auth::checkpw_hash('password', $hash2), 'password validates with second hash');
|