Koha/acqui
Nick Clemens d30e02977f Bug 32167: [22.05.x] (bug 14860 follow-up) Populate price fields even if no discount on vendor
On bug 14860 an 'else' was removed, assuming the price fields were set before discount,
this was incorrect. This patch renames the variable and always set the price, only discounting
ecost if a discount, but setting the values even if not

To test:
 0 - Have a vendor with a discount of 0% specified (no discount)
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount field
 5 - Add the order - note $0 order line
 6 - Repeat with another vendor with a 10% discount and confirm that is correct
 7 - Apply patch
 8 - Repeat 2-4
 9 - Add the order and confirm $10 price
10 - Repeat with discounted vendor, confirm prices are set discounted correctly

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2022-11-23 16:08:56 +00:00
..
acqui-home.pl Bug 29287: Add child funds to display of parent funds on acqui home 2022-03-01 22:47:46 -10:00
addorder.pl Bug 29111: Remove unused indicator modification code for items 2021-10-15 11:34:26 +02:00
addorderiso2709.pl Bug 32167: [22.05.x] (bug 14860 follow-up) Populate price fields even if no discount on vendor 2022-11-23 16:08:56 +00:00
ajax-getauthvaluedropbox.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
basket.pl Bug 31001: Fix "CGI::param called in list context" warning in basket.pl 2022-08-12 15:47:32 +00:00
basketgroup.pl Bug 16258: Add a syspref to govern EDIFACT functionality 2022-04-13 15:55:38 +02:00
basketheader.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
booksellers.pl Bug 28082: Add acquisitions toolbar to vendors on vendor search page 2022-05-10 15:17:17 -10:00
cancelorder.pl Bug 29658: Fix crash on cancelling cancelled order 2022-10-31 20:54:25 +00:00
check_budget_total.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
check_uniqueness.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
duplicate_orders.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
edi_ean.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
edifactmsgs.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
edimsg.pl Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
finishreceive.pl Bug 29771: Remove trivial cases 2022-03-08 23:03:34 -10:00
histsearch.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
invoice-files.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
invoice.pl Bug 24190: (QA follow-up) record unchanged bookfund and fix typo 2021-09-21 20:22:57 +02:00
invoices.pl Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
lateorders-export.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
lateorders.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
modordernotes.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
neworderempty.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
newordersubscription.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
newordersuggestion.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
ordered.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
orderreceive.pl Bug 30359: GetBudgetHierarchy is slow on order receive page 2022-10-31 22:26:01 +00:00
parcel.pl Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
parcels.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
showorder.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
spent.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
supplier.pl Bug 28082: Add acquisitions toolbar to vendors on vendor search page 2022-05-10 15:17:17 -10:00
transferorder.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
uncertainprice.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
updatesupplier.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
z3950_search.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00