Marcel de Rooy
d5c364e172
Makefile.PL: Section for creating file t/test-config.txt removed. Removes t/Makefile and t/rewrite-config-test too. Modifies XISBN.t to remove two commented lines. Test plan: Grep for KohaTest, database_dependent, config-test, t/Makefile. Run perl Makefile.PL and include running the test suite. This may fail on t/00-valid-xml.t and t/QueryParser.t, but that is not the result of this patch. Same for t/00-load.t with potential error on Koha::Plugins::Base. I had this result: Test Summary Report: t/00-valid-xml.t (Wstat: 1792 Tests: 381 Failed: 7) Failed tests: 10, 30-31, 169, 181, 201-202 Non-zero exit status: 7 t/QueryParser.t (Wstat: 512 Tests: 0 Failed: 0) Non-zero exit status: 2 Parse errors: No plan found in TAP output Files=92, Tests=12385, 45 wallclock secs ( 1.74 usr 0.15 sys + 26.61 cusr 1.92 csys = 30.42 CPU) Result: FAIL Failed 2/92 test programs. 7/12385 subtests failed. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> All tests pass, and I find no mention of the removed test code. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
117 lines
3.4 KiB
Perl
Executable file
117 lines
3.4 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
#
|
|
# This Koha test module is a stub!
|
|
# Add more tests here!!!
|
|
|
|
use Modern::Perl;
|
|
|
|
# use Test::Class::Load qw ( t/db_dependent/ );
|
|
use Test::More tests => 5;
|
|
use MARC::Record;
|
|
use C4::Biblio;
|
|
use C4::XISBN;
|
|
use Data::Dumper;
|
|
use C4::Context;
|
|
|
|
BEGIN {
|
|
use_ok('C4::XISBN');
|
|
}
|
|
|
|
# Avoid "redefined subroutine" warnings
|
|
local $SIG{__WARN__} = sub { warn $_[0] unless $_[0] =~ /redefined/ };
|
|
*C4::Search::SimpleSearch = \&Mock_SimpleSearch;
|
|
|
|
my $context = C4::Context->new;
|
|
|
|
my ( $biblionumber_tag, $biblionumber_subfield ) =
|
|
GetMarcFromKohaField( 'biblio.biblionumber', '' );
|
|
my ( $isbn_tag, $isbn_subfield ) =
|
|
GetMarcFromKohaField( 'biblioitems.isbn', '' );
|
|
|
|
# Harry Potter and the Sorcerer's Stone, 1st American ed. 1997
|
|
my $isbn1 = '0590353403';
|
|
# ThingISBN match : Silent Wing, First Edition 1998
|
|
my $isbn2 = '0684843897';
|
|
# XISBN match : Harry Potter and the Philosopher's Stone, Magic ed. 2000
|
|
my $isbn3 = '1551923963';
|
|
|
|
my $biblionumber1 = _add_biblio_with_isbn($isbn1);
|
|
my $biblionumber2 = _add_biblio_with_isbn($isbn2);
|
|
my $biblionumber3 = _add_biblio_with_isbn($isbn3);
|
|
|
|
my $trial = C4::XISBN::get_biblionumber_from_isbn($isbn1);
|
|
is( $trial->[0]->{biblionumber},
|
|
$biblionumber1,
|
|
"It gets the correct biblionumber from the only isbn we have added." );
|
|
|
|
$trial = C4::XISBN::_get_biblio_from_xisbn($isbn1);
|
|
is( $trial->{biblionumber},
|
|
$biblionumber1, "Gets biblionumber like the previous test." );
|
|
|
|
$context->set_preference( 'ThingISBN', 1 );
|
|
$context->set_preference( 'XISBN', 0 );
|
|
my $results_thingisbn = C4::XISBN::get_xisbns($isbn1);
|
|
is( $results_thingisbn->[0]->{biblionumber},
|
|
$biblionumber2,
|
|
"Gets correct biblionumber from a book with a similar isbn using ThingISBN." );
|
|
|
|
$context->set_preference( 'ThingISBN', 0 );
|
|
$context->set_preference( 'XISBN', 1 );
|
|
my $results_xisbn = C4::XISBN::get_xisbns($isbn1);
|
|
is( $results_xisbn->[0]->{biblionumber},
|
|
$biblionumber3,
|
|
"Gets correct biblionumber from a book with a similar isbn using XISBN." );
|
|
|
|
# clean up after ourselves
|
|
DelBiblio($biblionumber1);
|
|
DelBiblio($biblionumber2);
|
|
DelBiblio($biblionumber3);
|
|
|
|
# Util subs
|
|
|
|
# Add new biblio with isbn and return biblionumber
|
|
sub _add_biblio_with_isbn {
|
|
my $isbn = shift;
|
|
|
|
my $marc_record = MARC::Record->new;
|
|
my $field = MARC::Field->new( $isbn_tag, '', '', $isbn_subfield => $isbn );
|
|
$marc_record->append_fields($field);
|
|
my ( $biblionumber, $biblioitemnumber ) = AddBiblio( $marc_record, '' );
|
|
return $biblionumber;
|
|
}
|
|
|
|
# Mocked subs
|
|
|
|
# C4::Search::SimpleSearch
|
|
sub Mock_SimpleSearch {
|
|
my $query = shift;
|
|
my @results;
|
|
|
|
$query =~ s/-//g;
|
|
my $ret_biblionumber;
|
|
if ( $query =~ /$isbn1/ ) {
|
|
$ret_biblionumber = $biblionumber1;
|
|
}
|
|
elsif ( $query =~ /$isbn2/ ) {
|
|
$ret_biblionumber = $biblionumber2;
|
|
}
|
|
elsif ( $query =~ /$isbn3/ ) {
|
|
$ret_biblionumber = $biblionumber3;
|
|
}
|
|
|
|
my $record = MARC::Record->new;
|
|
$record->leader(' ngm a22 7a 4500');
|
|
my $biblionumber_field;
|
|
if ( $biblionumber_tag < 10 ) {
|
|
$biblionumber_field =
|
|
MARC::Field->new( $biblionumber_tag, $ret_biblionumber );
|
|
}
|
|
else {
|
|
$biblionumber_field = MARC::Field->new( $biblionumber_tag, '', '',
|
|
$biblionumber_subfield => $ret_biblionumber );
|
|
}
|
|
$record->append_fields($biblionumber_field);
|
|
|
|
push @results, $record->as_usmarc;
|
|
return ( undef, \@results, 1 );
|
|
}
|