5d170aa268
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8015: Fix complains from qa tools Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Bug 8015: Get rid of the eval in ModifyRecordWithTemplate This patch removes the use of eval in the C4::MarcModificationTemplates::ModifyRecordWithTemplate routine. Now this routine call the wanted modification routine with the list of parameters. This call is done only if the condition is respected. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Bug 8015: Get rid of eval for evaluating =~ m// Koha::SimpleMarc::field_equals uses eval in order to check if a string matches a pattern. Now this eval is removed and the "regex" variable does not contain the regex separated character (/ or |). Regression: Before this patch, the user was able to user a modifier. Now it is not possible. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Bug 8015: Get rid of the eval for substitution Before this patch, the regex substitution was contain into only one variable (e.g. my $regex = "/foo/bar/i"). Now each member of the regex is stored into a field in the marc_modification_template_actions sql table. In order to avoid a complex code, only modifiers i and g are take into account. Note: If you already add the mmta table, you have to drop it. This patch also adds a foreign key from mmta to mmt tables. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Bug 8015: FIX ui issue Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Bug 8015: The template name is a required field Test plan: Try to add a template with an empty string as name. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com> |
||
|---|---|---|
| .. | ||
| csv-profiles | ||
| quotes | ||
| background-job-progress.pl | ||
| batchMod.pl | ||
| cleanborrowers.pl | ||
| copy-holidays.pl | ||
| csv-profiles.pl | ||
| exceptionHolidays.pl | ||
| export.pl | ||
| holidays.pl | ||
| import_borrowers.pl | ||
| inventory.pl | ||
| koha-news.pl | ||
| letter.pl | ||
| manage-marc-import.pl | ||
| marc_modification_templates.pl | ||
| modborrowers.pl | ||
| newHolidays.pl | ||
| overduerules.pl | ||
| pdfViewer.pl | ||
| picture-upload.pl | ||
| quotes-upload.pl | ||
| quotes.pl | ||
| scheduler.pl | ||
| stage-marc-import.pl | ||
| tools-home.pl | ||
| upload-cover-image.pl | ||
| upload-file-progress.pl | ||
| upload-file.pl | ||
| viewlog.pl | ||