Koha/t/db_dependent
Nick Clemens 3ec73d80e2
Bug 17798: Confirm hold when printing slip from another patron's account
This patch adds a few pieces of information to the print slip button
and makes the code confirm the hold

As we are printing before the confirm, we also add the ability to pass
in the itemnumber to 'ReserveSlip'

This is slightly hacky, however, I don't see another way to allow
printing without an additional page reload.

To test:
 1 - Place a title level hold for patron A, for delivery to library B
 2 - Attempt to checkout an item from the record above to Patron B from
     library A
 3 - You receive an alert about the hold
 4 - Click "Don't check out, confirm hold, and print slip"
 5 - Confirm the slip looks correct and has item info
 6 - Confirm that item is in transit to fill hold
 7 - Revert transit status
 8 - Attempt to checkout the item to Patron B from Library B
 9 - Click "Don't check out, confirm hold, and print slip"
10 - Confirm slip is correct
11 - Confirm item is marked waiting

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-11-06 08:42:41 -03:00
..
Acquisition
api/v1 Bug 8367: (QA follow-up) Fix broken tests 2023-11-02 10:22:40 -03:00
Auth
AuthoritiesMarc
Authority
Biblio Bug 34549: Strip non-XML chars during TransformHtmlToMarc 2023-10-09 11:41:32 -03:00
Budgets
Circulation Bug 25560: Unit tests 2023-10-10 10:53:58 -03:00
CourseReserves
Creators
cronjobs
data Bug 34587: SushiCounter tests 2023-10-31 16:46:27 -03:00
Exporter
Holds Bug 8367: (QA follow-up) Fix QA script 2023-11-01 18:01:36 -03:00
Illrequest Bug 34842: Fix Illrequest/Config.t if DB upgraded twice 2023-10-03 08:51:12 -04:00
Items
Koha Bug 35190: Adjust tests 2023-11-03 14:22:46 -03:00
Labels Bug 10762: Fix tests continued 2023-10-28 10:02:31 -03:00
LDAP
Letters Bug 31383: Adjust and add tests 2023-10-20 14:43:57 -03:00
Members Bug 33947: Remove GetAllIssues 2023-10-20 11:03:03 -03:00
misc/translator
OAI
Patron Bug 16223: Tidy 2023-10-11 12:13:12 -03:00
Record
Reports
Reserves Bug 17798: Confirm hold when printing slip from another patron's account 2023-11-06 08:42:41 -03:00
Search
selenium Bug 34227: (follow-up) Adjust selenium tests 2023-10-30 09:39:38 -03:00
Serials
SIP Bug 15504: Fix tests count 2023-10-24 10:05:25 -03:00
Template/Plugin Bug 31383: (bug 29691 follow-up) Remove get_opac_news_by_id 2023-10-23 10:45:34 -03:00
Utils
www
00-strict.t
Accounts.t Bug 34912: Add 14 hours to 1970 date in Account(s).t 2023-10-04 09:15:39 -04:00
Acquisition.t Bug 14092: (QA follow-up) Avoid fiddling with the hash in the template 2023-10-20 16:31:15 -03:00
Amazon.t
ArticleRequests.t
AudioAlerts.t
Auth.t Bug 15504: (follow-up) Unit tests 2023-10-24 10:05:15 -03:00
Auth_with_cas.t
Auth_with_ldap.t
Auth_with_shibboleth.t
AuthorisedValues.t
AuthoritiesMarc.t Bug 27943: (QA follow-up) Perltidy 2023-10-30 09:02:21 -03:00
AuthoritiesMarc_GetTagsLabels.t
AuthUtils.t
Barcodes.t
Barcodes_ValueBuilder.t
Biblio.t Bug 34014: Unit test 2023-10-20 11:02:59 -03:00
Biblio_holdsqueue.t
Breeding.t Bug 28166: (QA follow-up) Fix and tidy tests and code 2023-10-23 11:33:50 -03:00
Breeding_Auth.t
Budgets.t Bug 31631: (QA follow-up) Tidy code 2023-10-18 15:41:37 -03:00
Cache.t
Calendar.t
Charset.t
check_kohastructure.t
check_sysprefs.t
Circulation.t Bug 34924: Add 'auto_renew_final' and 'auto_unseen_final' return to CanBookBeRenewed 2023-10-31 11:02:46 -03:00
Circulation_holdsqueue.t
Clubs.t
Context.t
Contract.t
CourseReserves.t
db_structure.t
DecreaseLoanHighHolds.t
Filter_MARC_ViewPolicy.t
Fines.t
FrameworkPlugin.t
Heading.t
Heading_MARC21.t
Hold.t
Holds.t
HoldsQueue.t
Holidays.t Bug 27249: Replace DateTime->now by dt_from_string 2023-10-17 14:45:34 -03:00
Illbatches.t Bug 30719: Remove unused Koha::Illbatch->requests_count method 2023-10-17 14:45:24 -03:00
IllbatchStatuses.t Bug 30719: (QA follow-up) Updating remaining naming 2023-10-17 14:45:23 -03:00
Illcomments.t
Illrequestattributes.t Bug 33970: Fix tests 2023-10-25 12:09:46 -03:00
Illrequests.t Bug 34905: Fix icon 2023-10-04 09:15:41 -04:00
ILSDI_Services.t Bug 15504: Remove PatronLastActivity preference 2023-10-24 10:05:22 -03:00
ImportBatch.t
ImportExportFramework.t
Installer.t
Items.t Bug 32496: Fix tests 2023-09-22 12:35:47 -03:00
Koha.t
Koha_Database.t
Koha_Elasticsearch.t
Koha_ExternalContent_OverDrive.t
Koha_MetadataRecord_Authority.t
Koha_Misc_Files.t
Languages.t
Letters.t Bug 12532: (follow-up) Catch more cases in tests 2023-10-10 09:58:54 -03:00
LibraryGroups.t
Linker_Default.t
Linker_FirstMatch.t
Log.t
MarcModificationTemplates.t Bug 24480: (follow-up) Adjust tests 2023-11-03 12:04:35 -03:00
Matcher.t
Members.t Bug 26170: Add protected status for patrons 2023-11-01 17:23:06 -03:00
Message.t
MungeMarcPrice.t
Overdues.t
Passwordrecovery.t
Patroncards.t
PatronLists.t Bug 32730: Add Patron Lists tab to patron details and circulation pages 2023-11-01 17:23:09 -03:00
Patrons.t
Prices.t Bug 34967: Move to db_dependent 2023-10-03 09:24:50 -04:00
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
Reports.t
Reserves.t Bug 8367: (QA follow-up) Fix broken tests in Reserves.t 2023-11-02 10:39:24 -03:00
rollingloans.t
RotatingCollections.t
Search.t
Serials.t Bug 31846: Add syspref for serials search results limit 2023-10-25 10:35:27 -03:00
Serials_2.t
Service.t
ShelfBrowser.t
Sitemapper.t
SocialData.t
StockRotationItems.t
StockRotationRotas.t
StockRotationStages.t
SuggestionEngine_ExplodedTerms.t
Suggestions.t
sysprefs.t
TablesSettings.t
Tags.t
Templates.t
TestBuilder.t
Upload.t
UsageStats.t
Virtualshelves.t
XISBN.t
XSLT.t
yaml.t
zebra_config.pl