Koha/misc
Nick Clemens ff08e99965 Bug 25758: Return on_reserve over too_soon when not calling from automatic_renewals cron
Bug 19014 altered CanBookBeRenewed to return (auto_)too_soon over on_reserve

For cron purposes this is the correct behaviour.

For display purposes we wish to see on_reserve over too_soon

This patchset adds a switch to 'CanBookBeRenewed' to alter the priority of these statuses

To test:
 1 - set NoRenewalBeforePrecision to date only
 2 - set a circ rule to auto-renewal=yes, no renewal before=0, checkout period to 7 days
 3 - check item out
 4 - confirm item shows Scheduled For Automatic Renewal in issues table
 5 - place a hold on the item for another patron
 6 - reload issues table for patron 1, confirm checkout still shows "scheduled for automatic renewal" rather than "on hold"
 7 - change No Renewal Before value to 7
 8 - reload issues table for patron 1, confirm checkout now shows "on hold"
 9 - Apply patch
10 - restart_all
11 - Reload the issues table - confirm 'on_hold' still shows
12 - Change No Renewal Before to 0
13 - Refresh issues table, still shows 'On hold'
14 - perl misc/cronjobs/automatic_renewals.pl -v
15 - Result shows 'auto_too_soon'
16 - prove -v t/db_dependent/Circulation.t

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-09-28 11:08:03 +02:00
..
admin Bug 23816: (follow-up) Fix many things 2020-09-09 15:39:52 +02:00
bin Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
cronjobs Bug 25758: Return on_reserve over too_soon when not calling from automatic_renewals cron 2020-09-28 11:08:03 +02:00
devel Bug 24591: Add --help option to misc/devel/get-prepared-letter.pl 2020-08-07 16:54:40 +02:00
interface_customization Bug 23148: Replace Bridge icons with transparent PNG files 2020-07-20 16:16:37 +02:00
load_testing Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
maintenance Bug 26407: fix query in 'title exists' in search_for_data_inconsistencies.pl 2020-09-18 10:37:56 +02:00
migration_tools Bug 26231: Remove incorrect use of AddAuthority() when 001 present 2020-09-28 10:09:52 +02:00
release_notes Bug 25642: Fix description of new feature in update_dbix_class_files.pl 2020-06-15 10:30:01 +02:00
search_tools
translator Bug 25922: Fix typo 'arial-label' -> 'aria-label' 2020-07-20 17:45:31 +02:00
add_date_fields_to_marc_records.pl
batchCompareMARCvsFrameworks.pl
batchdeletebiblios.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
batchDeleteUnusedSubfields.pl
batchImportMARCWithBiblionumbers.pl
batchRebuildBiblioTables.pl
batchRebuildItemsTables.pl
batchRepairMissingBiblionumbers.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
check_sysprefs.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
commit_file.pl
export_borrowers.pl
export_records.pl Bug 26175: Remove warn if undefined barcode in misc/export_records.pl 2020-08-26 15:21:41 +02:00
exportauth.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
import_patrons.pl
koha-install-log
kohalib.pl
link_bibs_to_authorities.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
load_yaml.pl
mod_zebraqueue.pl
perlmodule_ls.pl
perlmodule_rm.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
recreateIssueStatistics.pl
sax_parser_print.pl
sax_parser_test.pl
sip_cli_emulator.pl
stage_file.pl
z3950_responder.pl