Koha/acqui
Nick Clemens 7c734c6903
Bug 14680: Always subtract discount from price to calculate estimated cost
This patch simply removes a discrepancty where when a discount is provided on the order form
we add the discount to the price, and when it comes form the vendor we subtract the discount.

Discounts should always descrease the estimated cost

To test:
 0 - Have a vendor with a discount of 10% specified
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount field
 5 - Add the order - note $10 RRP and $9 actual/budgeted cost
 6 - Repeat 2&3
 7 - Select the tile, set price $10 and discount 50%
 8 - Add the order - note $20 RRP and $10 actual/budgeted cost! FAIL
 9 - Apply patch, restart all
10 - Repeat 2-7
11 - Add the order, note $10 RRP and $5 actual.budgeted cost

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-07-18 11:17:50 -03:00
..
acqui-home.pl Bug 29287: Add child funds to display of parent funds on acqui home 2022-03-01 22:47:46 -10:00
addorder.pl Bug 29111: Remove unused indicator modification code for items 2021-10-15 11:34:26 +02:00
addorderiso2709.pl Bug 14680: Always subtract discount from price to calculate estimated cost 2022-07-18 11:17:50 -03:00
ajax-getauthvaluedropbox.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
basket.pl Bug 31001: Fix "CGI::param called in list context" warning in basket.pl 2022-07-06 18:29:32 -03:00
basketgroup.pl Bug 16258: Add a syspref to govern EDIFACT functionality 2022-04-13 15:55:38 +02:00
basketheader.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
booksellers.pl Bug 28082: Add acquisitions toolbar to vendors on vendor search page 2022-05-10 15:17:17 -10:00
cancelorder.pl Bug 29785: Rename Koha::Object->message with ->object_messages 2022-02-09 22:01:36 -10:00
check_budget_total.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
check_uniqueness.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
duplicate_orders.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
edi_ean.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
edifactmsgs.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
edimsg.pl Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
finishreceive.pl Bug 29771: Remove trivial cases 2022-03-08 23:03:34 -10:00
histsearch.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
invoice-files.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
invoice.pl Bug 24190: (QA follow-up) record unchanged bookfund and fix typo 2021-09-21 20:22:57 +02:00
invoices.pl Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
lateorders-export.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
lateorders.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
modordernotes.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
neworderempty.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
newordersubscription.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
newordersuggestion.pl Bug 23991: Move SearchSuggestion to Koha::Suggestions 2022-06-27 12:30:28 -03:00
ordered.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
orderreceive.pl Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
parcel.pl Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
parcels.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
showorder.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
spent.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
supplier.pl Bug 28082: Add acquisitions toolbar to vendors on vendor search page 2022-05-10 15:17:17 -10:00
transferorder.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
uncertainprice.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
updatesupplier.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
z3950_search.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00