0f122a9400
Test Plan:
1. Apply patch
2. create a patron list if there aren't any
3. search for a patron
4. observe the "Patron lists" tab showing the list that the patron is not in
5. try adding the patron to the list and removing them from the list to
be sure the feature has full operation
6. click "Check Out" on the side bar menu to navigate to the circulation
page for this patron
7. observe the "Patron lists" tab, and verify it operates as it did on the
patron details page
Bug 32730: (follow-up) Minor corrections
by Owen Leonard
This patch corrects an instance of an incorrect capital letter
("Patron Lists" -> "Patron lists") and makes minor tweaks to
indentation.
Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Edit: (tcohen) new files should be run through perltidy ALWAYS. Did it
and squashed it here.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
126 lines
4.2 KiB
Perl
Executable file
126 lines
4.2 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::More tests => 12;
|
|
use t::lib::TestBuilder;
|
|
use t::lib::Mocks;
|
|
|
|
use Koha::Database;
|
|
use Koha::List::Patron
|
|
qw( AddPatronList AddPatronsToList DelPatronList DelPatronsFromList GetPatronLists ModPatronList );
|
|
use Koha::Patrons;
|
|
|
|
my $schema = Koha::Database->schema;
|
|
$schema->storage->txn_begin;
|
|
|
|
my $builder = t::lib::TestBuilder->new;
|
|
|
|
t::lib::Mocks::mock_userenv();
|
|
|
|
# Create 10 sample borrowers
|
|
my @borrowers = ();
|
|
foreach (1..10) {
|
|
push @borrowers, $builder->build({ source => 'Borrower' });
|
|
}
|
|
|
|
my $owner = $borrowers[0]->{borrowernumber};
|
|
my $owner2 = $borrowers[1]->{borrowernumber};
|
|
|
|
my @lists = GetPatronLists( { owner => $owner } );
|
|
my $list_count_original = @lists;
|
|
|
|
my $list1 = AddPatronList( { name => 'Test List 1', owner => $owner } );
|
|
is( $list1->name(), 'Test List 1', 'AddPatronList works' );
|
|
|
|
my $list2 = AddPatronList( { name => 'Test List 2', owner => $owner } );
|
|
|
|
ModPatronList(
|
|
{
|
|
patron_list_id => $list2->patron_list_id(),
|
|
name => 'Test List 3',
|
|
owner => $owner
|
|
}
|
|
);
|
|
$list2->discard_changes();
|
|
is( $list2->name(), 'Test List 3', 'ModPatronList works' );
|
|
|
|
AddPatronsToList(
|
|
{ list => $list1, cardnumbers => [ map { $_->{cardnumber} } @borrowers ] }
|
|
);
|
|
is(
|
|
scalar @borrowers,
|
|
$list1->patron_list_patrons()->search_related('borrowernumber')->all(),
|
|
'AddPatronsToList works for cardnumbers'
|
|
);
|
|
|
|
AddPatronsToList(
|
|
{
|
|
list => $list2,
|
|
borrowernumbers => [ map { $_->{borrowernumber} } @borrowers ]
|
|
}
|
|
);
|
|
is(
|
|
scalar @borrowers,
|
|
$list2->patron_list_patrons()->search_related('borrowernumber')->all(),
|
|
'AddPatronsToList works for borrowernumbers'
|
|
);
|
|
|
|
my $deleted_patron = $builder->build_object({ class => 'Koha::Patrons' });
|
|
$deleted_patron->delete;
|
|
my @result = AddPatronsToList({list => $list2,borrowernumbers => [ $deleted_patron->borrowernumber ]});
|
|
is( scalar @result, 0,'Invalid borrowernumber not added');
|
|
@result = AddPatronsToList({list => $list2,cardnumbers => [ $deleted_patron->cardnumber ]});
|
|
is( scalar @result, 0,'Invalid cardnumber not added');
|
|
|
|
my @ids =
|
|
$list1->patron_list_patrons()->get_column('patron_list_patron_id')->all();
|
|
DelPatronsFromList(
|
|
{
|
|
list => $list1,
|
|
patron_list_patrons => \@ids,
|
|
}
|
|
);
|
|
$list1->discard_changes();
|
|
is( $list1->patron_list_patrons()->count(), 0, 'DelPatronsFromList works.' );
|
|
|
|
my $patron = $builder->build_object({ class => 'Koha::Patrons' });
|
|
AddPatronsToList({list => $list2,borrowernumbers => [ $patron->borrowernumber ]});
|
|
@lists = $patron->get_lists_with_patron;
|
|
is( scalar @lists, 1, 'get_lists_with_patron works' );
|
|
|
|
@lists = GetPatronLists( { owner => $owner } );
|
|
is( scalar @lists, $list_count_original + 2, 'GetPatronLists works' );
|
|
|
|
my $list3 = AddPatronList( { name => 'Test List 3', owner => $owner2, shared => 0 } );
|
|
@lists = GetPatronLists( { owner => $owner } );
|
|
is( scalar @lists, $list_count_original + 2, 'GetPatronLists does not return non-shared list' );
|
|
|
|
my $list4 = AddPatronList( { name => 'Test List 4', owner => $owner2, shared => 1 } );
|
|
@lists = GetPatronLists( { owner => $owner } );
|
|
is( scalar @lists, $list_count_original + 3, 'GetPatronLists does return shared list' );
|
|
|
|
DelPatronList( { patron_list_id => $list1->patron_list_id(), owner => $owner } );
|
|
DelPatronList( { patron_list_id => $list2->patron_list_id(), owner => $owner } );
|
|
|
|
@lists =
|
|
GetPatronLists( { patron_list_id => $list1->patron_list_id(), owner => $owner } );
|
|
is( scalar @lists, 0, 'DelPatronList works' );
|
|
|
|
$schema->storage->txn_rollback;
|
|
|