dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
187 lines
7.5 KiB
Text
187 lines
7.5 KiB
Text
[% USE raw %]
|
|
[% USE Asset %]
|
|
[% SET footerjs = 1 %]
|
|
[% SET panel_id = 0 %]
|
|
[% BLOCK pagelist %]
|
|
<div class="pagelist">
|
|
<form method="post" action="/cgi-bin/koha/admin/columns_settings.pl">
|
|
<input type="hidden" name="action" value="save" />
|
|
<input type="hidden" name="module" value="[% modulename | html %]" />
|
|
<input type="hidden" name="panel" value="[% panel_id | html %]" />
|
|
[% SET panel_id = panel_id + 1 %]
|
|
[% IF module.keys and module.keys.size > 0 %]
|
|
[% FOR pagename IN module.keys %]
|
|
<h5>[% pagename | html %]</h5>
|
|
[% SET tables = module %]
|
|
[% IF tables.$pagename.keys and tables.$pagename.keys.size > 0 %]
|
|
[% FOR tablename IN tables.$pagename.keys.sort %]
|
|
[% IF pagename == 'additem' AND tablename == 'itemst' %]
|
|
<div class="alert">Changes made below will only apply to item subfields that are mapped to the 'items' table. <a href="/cgi-bin/koha/admin/koha2marclinks.pl?tablename=items">Go to Koha to MARC mapping</a></div>
|
|
[% END %]
|
|
<table>
|
|
<caption>
|
|
[% IF tablename == 'currencies-table' %]
|
|
Currency
|
|
[% ELSIF pagename == 'additem' AND tablename == 'itemst' %]
|
|
Items Editor
|
|
[% END %]
|
|
(id=[% tablename | html %])
|
|
</caption>
|
|
<thead><tr><th>Column name</th><th>Is hidden by default</th><th>Cannot be toggled</th></tr></thead>
|
|
<tbody>
|
|
[% FOR column IN tables.$pagename.$tablename %]
|
|
[% SET value = pagename _ '#' _ tablename _ '#' _ column.columnname %]
|
|
<tr>
|
|
<td>
|
|
[% column.columnname | html %]
|
|
<input type="hidden" name="columnid" value="[% value | html %]" />
|
|
</td>
|
|
<td>
|
|
[% IF column.is_hidden %]
|
|
[% IF column.cannot_be_modified %]
|
|
<input type="checkbox" name="[% value | html %]_hidden" value="1" checked="checked" disabled="disabled" />
|
|
<input type="hidden" name="[% value | html %]_hidden" value="1" />
|
|
[% ELSE %]
|
|
<input type="checkbox" name="[% value | html %]_hidden" value="1" checked="checked" />
|
|
[% END %]
|
|
[% ELSE %]
|
|
[% IF column.cannot_be_modified %]
|
|
<input type="checkbox" name="[% value | html %]_hidden" value="1" disabled="disabled" />
|
|
<input type="hidden" name="[% value | html %]_hidden" value="0" />
|
|
[% ELSE %]
|
|
<input type="checkbox" name="[% value | html %]_hidden" value="1" />
|
|
[% END %]
|
|
[% END %]
|
|
</td>
|
|
<td>
|
|
[% IF column.cannot_be_toggled %]
|
|
[% IF column.cannot_be_modified %]
|
|
<input type="checkbox" name="[% value | html %]_cannot_be_toggled" value="1" checked="checked" disabled="disabled" />
|
|
<input type="hidden" name="[% value | html %]_cannot_be_toggled" value="1" />
|
|
[% ELSE %]
|
|
<input type="checkbox" name="[% value | html %]_cannot_be_toggled" value="1" checked="checked" />
|
|
[% END %]
|
|
[% ELSE %]
|
|
[% IF column.cannot_be_modified %]
|
|
<input type="checkbox" name="[% value | html %]_cannot_be_toggled" value="1" disabled="disabled" />
|
|
<input type="hidden" name="[% value | html %]_cannot_be_toggled" value="0" />
|
|
[% ELSE %]
|
|
<input type="checkbox" name="[% value | html %]_cannot_be_toggled" value="1" />
|
|
[% END %]
|
|
[% END %]
|
|
</td>
|
|
</tr>
|
|
[% END %]
|
|
</tbody>
|
|
</table>
|
|
[% END %]
|
|
<input type="submit" value="Save" />
|
|
[% ELSE %]
|
|
There is no table to configure for this module.
|
|
[% END %]
|
|
[% END %]
|
|
[% ELSE %]
|
|
There is no page using the table configuration in this module.
|
|
[% END %]
|
|
</form>
|
|
</div>
|
|
[% END %]
|
|
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Administration › Columns settings</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
|
|
<body id="admin_tables" class="admin">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'prefs-admin-search.inc' %]
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › Columns settings</div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
<h2>Columns settings</h2>
|
|
<div id="modules">
|
|
<h3><a href="#acqui">Acquisition</a></h3>
|
|
<div id="acqui">
|
|
<h4>Acquisition tables</h4>
|
|
[% PROCESS pagelist module=modules.acqui modulename="acqui" %]
|
|
</div>
|
|
|
|
<h3><a href="#admin">Administration</a></h3>
|
|
<div id="admin">
|
|
<h4>Administration tables</h4>
|
|
[% PROCESS pagelist module=modules.admin modulename="admin" %]
|
|
</div>
|
|
|
|
<h3><a href="#authorities">Authorities</a></h3>
|
|
<div id="authorities">
|
|
<h4>Authorities tables</h4>
|
|
[% PROCESS pagelist module=modules.authorities modulename="authorities" %]
|
|
</div>
|
|
|
|
<h3><a href="#catalog">Catalog</a></h3>
|
|
<div id="catalogue">
|
|
<h4>Catalogue tables</h4>
|
|
[% PROCESS pagelist module=modules.catalogue modulename="catalogue" %]
|
|
</div>
|
|
|
|
<h3><a href="#cataloguing">Cataloging</a></h3>
|
|
<div id="cataloguing">
|
|
<h4>Cataloguing tables</h4>
|
|
[% PROCESS pagelist module=modules.cataloguing modulename="cataloguing" %]
|
|
</div>
|
|
|
|
<h3><a href="#circulation">Circulation</a></h3>
|
|
<div id="circulation">
|
|
<h4>Circulation tables</h4>
|
|
[% PROCESS pagelist module=modules.circ modulename="circ" %]
|
|
</div>
|
|
|
|
<h3><a href="#members">Patrons</a></h3>
|
|
<div id="members">
|
|
<h4>Patrons tables</h4>
|
|
[% PROCESS pagelist module=modules.members modulename="members" %]
|
|
</div>
|
|
|
|
<h3><a href="#opac">OPAC</a></h3>
|
|
<div id="opac">
|
|
<h4>OPAC tables</h4>
|
|
[% PROCESS pagelist module=modules.opac modulename="opac" %]
|
|
</div>
|
|
|
|
<h3><a href="#reports">Reports</a></h3>
|
|
<div id="reports">
|
|
<h4>Reports tables</h4>
|
|
[% PROCESS pagelist module=modules.reports modulename="reports" %]
|
|
</div>
|
|
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="yui-b">
|
|
[% INCLUDE 'admin-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
[% Asset.js("js/admin-menu.js") | $raw %]
|
|
<script type="text/javascript">
|
|
$(document).ready( function() {
|
|
var accordion = $( "#modules" ).accordion({
|
|
collapsible: true,
|
|
autoHeight: false,
|
|
header: "h3",
|
|
[%- IF panel -%]
|
|
[%# we were asked to show a specific panel, usually on update %]
|
|
active: [%- panel | html -%]
|
|
[%- ELSE -%]
|
|
active: false
|
|
[%- END -%]
|
|
});
|
|
});
|
|
</script>
|
|
[% END %]
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|