Koha/opac
Jonathan Druart db14275db4 Bug 19298: Placing a hold from a list at the OPAC should respect issuing rules
The issuing rule retrieve to know if a hold can be placed on a record of
a list is not correct.

Test plan:
0/ With item-level_itypes = item level
1/ Define a item.itype=BK and biblioitems.itemtype=CF
2/ Create a default rule to allow on shelf holds
3/ Create a specific rule for CF with on shelf holds="If any
unavailable"
4/ Add this bibliographic record to a list and view the list
=> Without this patch you will not see "Place hold"
=> With this patch applied you will see the "Place hold" button,
respecting the correct issuing rule

Followed test plan, patches worked as described.

Note: Just to clarify the test plan slightly in step 4 where it says you will not see 'Place Hold' it means to
the left of the 'Save to another List' link below the item availability
in the opac-shelves.pl page. Not the 'Place hold' button in the grey
page header box.

Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-10-25 12:14:39 -03:00
..
clubs
errors
external/overdrive
rss
sco Bug 12691: Use Koha.Preference in Self-Checkout 2017-09-07 14:03:45 -03:00
svc Bug 16892: Address error checking in comment #47 2017-08-25 10:51:25 -03:00
ilsdi.pl Bug 16476: Do not call CGI->param in list context, some more 2016-05-16 17:11:46 +00:00
maintenance.pl
oai.pl
opac-account-pay-paypal-return.pl
opac-account-pay-return.pl Bug 19173: Make OPAC online payments pluggable 2017-09-19 14:15:52 -03:00
opac-account-pay.pl Bug 19173: Make OPAC online payments pluggable 2017-09-19 14:15:52 -03:00
opac-account.pl Bug 19173: Add opac payment and marc conversion plugins to the pulldown filter list 2017-09-19 14:15:52 -03:00
opac-addbybiblionumber.pl Bug 18262: Koha::Biblio - Remove GetBiblioData - part 1 2017-07-14 12:22:23 -03:00
opac-alert-subscribe.pl
opac-article-request-cancel.pl
opac-authorities-home.pl
opac-authoritiesdetail.pl Bug 18149: Move CountUsage calls to Koha namespace 2017-09-19 11:47:32 -03:00
opac-basket.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-blocked.pl
opac-browser.pl
opac-changelanguage.pl Bug 18946 [QA Followup] - code cleanup 2017-09-01 13:02:26 -03:00
opac-course-details.pl
opac-course-reserves.pl
opac-detail.pl Bug 15685: (follow-up) K:A:O->find and ->fetch are no longer used 2017-10-11 13:08:46 -03:00
opac-discharge.pl Bug 16463: Replace discharge link with error message if user has checked out items 2017-09-29 12:37:00 -03:00
opac-downloadcart.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-downloadshelf.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-export.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-ics.pl
opac-idref.pl
opac-image.pl
opac-imageviewer.pl
opac-ISBDdetail.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-issue-note.pl
opac-main.pl
opac-MARCdetail.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-memberentry.pl Bug 18298: Add server-side checks and refactor stuffs 2017-10-16 09:44:32 -03:00
opac-messaging.pl
opac-modrequest-suspend.pl
opac-modrequest.pl Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel 2017-09-12 12:42:58 -03:00
opac-mymessages.pl
opac-news-rss.pl
opac-overdrive-search.pl
opac-passwd.pl Bug 18298: Add server-side checks and refactor stuffs 2017-10-16 09:44:32 -03:00
opac-password-recovery.pl Bug 18298: Add server-side checks and refactor stuffs 2017-10-16 09:44:32 -03:00
opac-patron-image.pl
opac-privacy.pl
opac-ratings-ajax.pl
opac-ratings.pl
opac-readingrecord.pl
opac-registration-verify.pl
opac-renew.pl Bug 18572 - QA Followup 2017-07-24 13:38:31 -03:00
opac-request-article.pl
opac-reserve.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-restrictedpage.pl
opac-retrieve-file.pl
opac-review.pl Bug 18262: Koha::Biblio - Remove GetBiblioData - part 1 2017-07-14 12:22:23 -03:00
opac-search-history.pl
opac-search.pl Bug 13205: [FOLLOW-UP] Fixing math and variable names 2017-10-09 16:15:49 -03:00
opac-sendbasket.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-sendshelf.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-serial-issues.pl
opac-shareshelf.pl
opac-shelves.pl Bug 19298: Placing a hold from a list at the OPAC should respect issuing rules 2017-10-25 12:14:39 -03:00
opac-showmarc.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-showreviews.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-suggestions.pl
opac-tags.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-tags_subject.pl
opac-topissues.pl
opac-user.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
tracklinks.pl
unapi Bug 17797: Add XSLT_Handler in opac/unapi 2017-09-01 13:00:06 -03:00