Jonathan Druart
b679cac964
If JS is disabled and a user clicks on the "Rate me" button, Koha will crashes with: DBIx::Class::ResultSet::create(): Column 'rating_value' cannot be null at /usr/share/koha/lib/C4/Ratings.pm line 208 To avoid that, opac-ratings.pl will check if a rate has been selected. Test plan: Disable JS On a record detail page, click on the "Rate me" button TESTED PLAN: 1) go to /cgi-bin/koha/opac-ratings.pl?biblionumber=1 -- kaboom as above. 2) apply patch 3) refresh -- either login screen (don't know why) -- or if already logged in, detail page. 4) koha qa test tool Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> I tested successfully by temporarily removing the modification made by Bug 16210. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>
62 lines
1.8 KiB
Perl
Executable file
62 lines
1.8 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2011 KohaAloha, NZ
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
=head1
|
|
|
|
A non-javascript method to add/modify a biblio's rating, called from opac-detail.pl
|
|
|
|
note: there is currently no 'delete rating' functionality in this script
|
|
|
|
=cut
|
|
|
|
use strict;
|
|
use warnings;
|
|
use CGI qw ( -utf8 );
|
|
|
|
use C4::Auth;
|
|
use C4::Context;
|
|
use C4::Ratings;
|
|
use C4::Debug;
|
|
|
|
my $query = CGI->new();
|
|
|
|
# auth required to add ratings
|
|
my ($userid, $cookie, $sessionID) = checkauth( $query, 0, {}, 'opac' );
|
|
my $loggedinuser = C4::Context->userenv->{'number'};
|
|
|
|
my $biblionumber = $query->param('biblionumber');
|
|
my $rating_old_value = $query->param('rating_value');
|
|
my $rating_value = $query->param('rating');
|
|
my $rating;
|
|
|
|
# If JS is disabled and a user click on "Rate me" without selecting a rate
|
|
unless ( $biblionumber and $rating_value ) {
|
|
print $query->redirect(
|
|
"/cgi-bin/koha/opac-detail.pl?biblionumber=$biblionumber");
|
|
exit;
|
|
}
|
|
|
|
if ( !$rating_old_value ) {
|
|
$rating = AddRating( $biblionumber, $loggedinuser, $rating_value );
|
|
}
|
|
else {
|
|
$rating = ModRating( $biblionumber, $loggedinuser, $rating_value );
|
|
}
|
|
print $query->redirect(
|
|
"/cgi-bin/koha/opac-detail.pl?biblionumber=$biblionumber");
|