Koha/misc
Tomas Cohen Arazi 3cd669e527 Bug 22049: Make MarkIssueReturned rely on returndate only
This patch changes the params accepted by
C4::Circulation::MarkIssueReturned by removing the $dropbox_branch
param.

This passed branchcode was only used to initialize the Koha::Calendar
object, but the date arithmetic has already taken place in a couple
places before we reach this point. This logic needs to be simplified
(bug 14591), and this is the starting point.

To test:
- Apply this patch
- Run:
  $ git grep MarkIssueReturned
=> SUCCESS: Check all the uses of the function either originally passed
undef, or now pass the same date that would've been calculated anyway,
in the returndate param.
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation/MarkIssueReturned.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-01-25 20:46:47 +00:00
..
admin
bin
cronjobs Bug 22049: Make MarkIssueReturned rely on returndate only 2019-01-25 20:46:47 +00:00
devel Bug 22048: Use set_password in create_superlibrarian.pl 2019-01-25 20:15:30 +00:00
interface_customization Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests button is wrong 2018-08-10 10:38:12 +00:00
load_testing Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
maintenance Bug 21150: add the biblionumber to the output 2018-08-22 12:48:22 +00:00
migration_tools Bug 21908: (QA follow-up) Remove useless parentheses in query 2018-12-11 19:19:47 +00:00
release_notes Correct release notes encoding issues 2018-11-27 12:04:15 +00:00
search_tools Bug 19893: Add pods, remove syspref, add tests for serialization format 2018-11-16 11:04:59 +00:00
translator Bug 21895: Fix path to POT file 2018-11-29 17:57:54 +00:00
batchCompareMARCvsFrameworks.pl
batchdeletebiblios.pl
batchDeleteUnusedSubfields.pl Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
batchImportMARCWithBiblionumbers.pl
batchRebuildBiblioTables.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
batchRebuildItemsTables.pl Bug 20893: batchRebuildItemsTables.pl has incorrect parameter 2018-06-29 19:40:16 +00:00
batchRepairMissingBiblionumbers.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
check_sysprefs.pl Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
commit_file.pl
export_borrowers.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
export_records.pl Bug 20486: Add --marc_conditions option to export_records.pl 2018-11-08 02:23:29 +00:00
exportauth.pl
import_patrons.pl Bug 12598: Fix POD 2018-02-16 14:05:18 -03:00
koha-install-log Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
kohalib.pl
link_bibs_to_authorities.pl Bug 19365: Fix several issues with the Elasticsearch code 2018-11-26 16:11:01 +00:00
mod_zebraqueue.pl
perlmodule_ls.pl
perlmodule_rm.pl
recreateIssueStatistics.pl
sax_parser_print.pl Bug 17626 (QA followup) 2016-11-22 11:29:07 +00:00
sax_parser_test.pl
sip_cli_emulator.pl Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing 2017-03-31 13:56:37 +00:00
stage_file.pl Bug 19049: Fix regression on stage-marc-import with to_marc plugin 2017-08-15 12:17:41 -03:00