Main Koha release repository https://koha-community.org
Find a file
Janik Hilser 6341d520ac
Bug 29930: Cardnumber incorrectly set to userid on LDAP auth if cardnumber not mapped
In the sub the userId was given, but the cardnumber was expected, therefore at every login the cardnumber changed to the userId.

To test:
1. Login to the OPAC with an LDAP account that has a cardnumber which is different to the userId
2. Check the patron record's cardnumber.
3. The cardnumber should equal to the userId
4. Apply the patch.
5. Login to the OPAC with an LDAP account that has a cardnumber which is different to the userId
6. Check the patron record's cardnumber.
7. The cardnumber should be the same as before

Signed-off-by: Alexander Wagner <alexander.wagner@desy.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Extra test plan:
1. Apply the regression tests
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Auth_with_ldap.t
=> FAIL: Tests fail! 'cardnumber' incorrectly overwritten
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests now pass!
5. Sign off :-D

Signed-off-by: Alexander Wagner <alexander.wagner@desy.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-01-26 15:13:49 +01:00
acqui Bug 30070: Update edifactmsgs to use the API 2024-01-17 11:38:53 +01:00
admin Bug 35460: Fix add and edit of hold rules in circulation rules table 2023-12-11 19:41:26 +01:00
api Bug 30070: EDIFACT and ID are abbreviations 2024-01-17 11:38:59 +01:00
authorities
basket
bin
bookings Bug 35574: Bookings tab from biblio details should only require manage_bookings permission 2023-12-18 15:21:04 +01:00
C4 Bug 29930: Cardnumber incorrectly set to userid on LDAP auth if cardnumber not mapped 2024-01-26 15:13:49 +01:00
catalogue Bug 34913: Adjust item search 2024-01-26 15:13:44 +01:00
cataloguing Bug 33639: Make add item to item group work from additem.pl 2024-01-11 15:44:46 +01:00
circ Bug 25835: Include overdues with fines in overdues_report permission 2024-01-11 15:44:45 +01:00
clubs
course_reserves Bug 20256: Use new methods 2023-02-02 11:59:26 -03:00
debian Bug 25691: (follow-up) Update control file with wiki link 2024-01-16 12:06:09 +01:00
docs Bug 35504: Split list of ERM Topic experts 2024-01-11 15:44:51 +01:00
erm
errors
etc Bug 35086: (follow-up) Use 5000 as example in conf file 2024-01-16 12:06:02 +01:00
ill
installer Bug 35687: DBRev 23.12.00.004 2024-01-26 15:13:46 +01:00
Koha Bug 35843: Correct invalid exception 2024-01-26 15:13:47 +01:00
koha-tmpl Bug 35912: Corretc field name form itemprice to price in addorderiso2709 template 2024-01-26 15:13:47 +01:00
labels Bug 10762: (QA follow-up) Perltidy 2023-10-25 10:35:31 -03:00
lib/CGI/Session/Serialize
members Bug 30287: Conditionally render notice preview 2023-12-19 13:42:10 +01:00
misc Bug 34854: (follow-up) Param name change + POD 2024-01-17 11:39:05 +01:00
offline_circ Bug 34529: Offline circulation should be able to accept userid as well as cardnumber 2023-11-06 11:34:44 -03:00
opac Bug 35496: (QA follow-up): tidy up code 2023-12-14 16:29:22 +01:00
patron_lists Bug 34977: (QA follow-up) Tidy code 2023-11-08 11:41:33 -03:00
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins Bug 25672: Fix double output_html_with_http_headers 2023-10-31 11:02:45 -03:00
pos Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
preservation Bug 34030: Add a "print slips" action links to print in batch 2023-10-23 11:33:55 -03:00
recalls
reports Bug 34456: (QA follow-up) perltidy code 2023-11-01 17:23:18 -03:00
reserve Bug 34519: Add a template plugin for fetch searchable patron attributes 2023-11-08 17:52:37 -03:00
reviews
rotating_collections Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
serials Bug 28012: Use definedness test instead of bool when checking whether to null fields 2023-12-27 19:06:06 +01:00
services
skel
suggestion Bug 35276: Remove authentication params from suggestion hash 2023-11-14 10:32:38 -03:00
svc Bug 34913: Adjust C4::Utils::DataTables::VirtualShelves 2024-01-26 15:13:42 +01:00
t Bug 29930: Regression tests 2024-01-26 15:13:48 +01:00
tags
tools Bug 34913: Adjust "Manage staged MARC records" 2024-01-26 15:13:43 +01:00
virtualshelves Bug 35547: Show public "staff only" lists in addbybiblionumber.pl 2023-12-27 19:06:03 +01:00
xt
.editorconfig
.eslintrc.json
.gitignore Bug 35174: Add misc/translator/po to .gitignore 2023-11-16 08:56:36 +01:00
.htaccess
.mailmap 23.11.00: Update mailmap 2023-11-30 14:58:47 -03:00
.perlcriticrc
.perltidyrc
.proverc.dist
.stylelintrc.json
about.pl Bug 35504: Distinguish different RMaint and Topic Expert roles 2024-01-11 15:44:52 +01:00
app.psgi
build-resources.PL
changelanguage.pl
cpanfile
cypress.config.ts
fix-perl-path.PL
gulpfile.js Bug 35428: Remove temporary files for gulp po tasks 2023-12-12 15:04:54 +01:00
help.pl
INSTALL
Koha.pm Bug 35687: DBRev 23.12.00.004 2024-01-26 15:13:46 +01:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 35759: (bug 30708 follow-up) Generated dist file not installed for preservation module 2024-01-16 12:06:17 +01:00
MANIFEST.SKIP
package.json
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo