Marcel de Rooy
15fd90dcbc
The error codes 1 to 7 are used in Uploader.pm or tools/upload.pl.
It would be nice to use alphanumeric codes instead.
No behavior change expected.
Test plan:
[1] Run t/db_dependent/Upload.t
[2] Verify that a regular upload with tools/upload.pl still works.
[3] Rename upload_path in your koha-conf.xml. Restart Plack, flush the cache
and try to upload to a category. Correct error message?
[4] Upload the same file twice to the same category.
Correct error message the second time?
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Bug 19633: (QA follow-up) Really remove these ugly numbers
See BZ comment5. We now remove the numbers also from the constant names.
Test plan:
Read the changes.
Git grep "ERRCODE_"
Run t/db_dependent/Upload.t (Note: You may see one failure here; it is fixed
on bug 20727. So depends on who reaches master first.)
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
|
||
|---|---|---|
| .. | ||
| csv-profiles | ||
| quotes | ||
| access_files.pl | ||
| ajax-inventory.pl | ||
| automatic_item_modification_by_age.pl | ||
| background-job-progress.pl | ||
| batch_delete_records.pl | ||
| batch_record_modification.pl | ||
| batch_records_ajax.pl | ||
| batchMod.pl | ||
| cleanborrowers.pl | ||
| copy-holidays.pl | ||
| csv-profiles.pl | ||
| exceptionHolidays.pl | ||
| export.pl | ||
| holidays.pl | ||
| import_borrowers.pl | ||
| inventory.pl | ||
| koha-news.pl | ||
| letter.pl | ||
| manage-marc-import.pl | ||
| marc_modification_templates.pl | ||
| modborrowers.pl | ||
| newHolidays.pl | ||
| overduerules.pl | ||
| picture-upload.pl | ||
| quotes-upload.pl | ||
| quotes.pl | ||
| scheduler.pl | ||
| showdiffmarc.pl | ||
| stage-marc-import.pl | ||
| tools-home.pl | ||
| upload-cover-image.pl | ||
| upload-file.pl | ||
| upload.pl | ||
| viewlog.pl | ||