b168f4a2e9
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
115 lines
3 KiB
Perl
Executable file
115 lines
3 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
#
|
|
# Copyright (C) 2012 ByWater Solutions
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
BEGIN {
|
|
# find Koha's Perl modules
|
|
# test carefully before changing this
|
|
use FindBin;
|
|
eval { require "$FindBin::Bin/../kohalib.pl" };
|
|
}
|
|
|
|
use Koha::Script;
|
|
use C4::Context;
|
|
use C4::Installer;
|
|
|
|
use Getopt::Long;
|
|
use Data::Dumper;
|
|
|
|
sub print_usage {
|
|
print <<_USAGE_
|
|
$0: Remove duplicate fines
|
|
|
|
Due to bug 8253, upgrading from Koha 3.6 to 3.8 may introduce duplicate fines.
|
|
This script will remove these duplicate fines. To use, repeatably run this
|
|
script until there are no more duplicates in the database.
|
|
|
|
Parameters:
|
|
--confirm or -c Confirm you want to run the script.
|
|
--help or -h Print out this help message.
|
|
_USAGE_
|
|
}
|
|
|
|
my $help;
|
|
my $confirm;
|
|
my $result = GetOptions(
|
|
'confirm|c' => \$confirm,
|
|
'help|h' => \$help,
|
|
);
|
|
if ( $help || !$confirm ) {
|
|
print_usage();
|
|
exit 0;
|
|
}
|
|
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
my $query = "
|
|
SELECT * FROM accountlines
|
|
WHERE ( accounttype = 'FU' OR accounttype = 'F' )
|
|
AND description like '%23:59%'
|
|
ORDER BY borrowernumber, itemnumber, accountlines_id, description
|
|
";
|
|
my $sth = $dbh->prepare($query);
|
|
$sth->execute();
|
|
my $results = $sth->fetchall_arrayref( {} );
|
|
|
|
$query =
|
|
"SELECT * FROM accountlines WHERE description LIKE ? AND description NOT LIKE ?";
|
|
$sth = $dbh->prepare($query);
|
|
|
|
foreach my $keeper (@$results) {
|
|
|
|
warn "WORKING ON KEEPER: " . Data::Dumper::Dumper( $keeper );
|
|
my ($description_to_match) = split( / 23:59/, $keeper->{'description'} );
|
|
$description_to_match .= '%';
|
|
|
|
warn "DESCRIPTION TO MATCH: " . $description_to_match;
|
|
|
|
$sth->execute( $description_to_match, $keeper->{'description'} );
|
|
|
|
my $has_changed = 0;
|
|
|
|
while ( my $f = $sth->fetchrow_hashref() ) {
|
|
|
|
warn "DELETING: " . Data::Dumper::Dumper( $f );
|
|
|
|
if ( $f->{'amountoutstanding'} < $keeper->{'amountoutstanding'} ) {
|
|
$keeper->{'amountoutstanding'} = $f->{'amountoutstanding'};
|
|
$has_changed = 1;
|
|
}
|
|
|
|
my $sql =
|
|
"DELETE FROM accountlines WHERE accountlines_id = ?";
|
|
$dbh->do( $sql, undef, $f->{'accountlines_id'} );
|
|
}
|
|
|
|
if ($has_changed) {
|
|
my $sql =
|
|
"UPDATE accountlines SET amountoutstanding = ? WHERE accountlines_id = ?";
|
|
$dbh->do(
|
|
$sql, undef,
|
|
$keeper->{'amountoutstanding'}, $keeper->{'accountlines_id'}
|
|
);
|
|
}
|
|
}
|
|
|
|
exit;
|