Koha/xt/tt_valid.t
Tomas Cohen Arazi b6cd9ab896 Bug 16174: Warning in tt_valid.t due to bug 15527
Bug 15527 introduced a new directory (xslt) on the top level OPAC templates
directory. The tt_valid.t script should include that top level dir on the list
of excluded dirs so it doesn't look for themes there.

To test:
- Run
  $ prove xt/tt_valid.t
=> FAIL: You get the following warning:
Can't stat koha-tmpl/opac-tmpl/xslt/en: No such file or directory
 at xt/tt_valid.t line 8
- Apply the patch
- Run
  $ prove xt/tt_valid.t
=> SUCCESS: Tests pass and don't raise warnings.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2016-04-01 19:11:32 +00:00

129 lines
3.4 KiB
Perl
Executable file

#!/usr/bin/perl
# This file is part of Koha.
#
# Copyright (C) 2011 Tamil s.a.r.l.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Test::More tests => 3;
use File::Find;
use Cwd;
use C4::TTParser;
my @themes;
# OPAC themes
my $opac_dir = 'koha-tmpl/opac-tmpl';
opendir ( my $dh, $opac_dir ) or die "can't opendir $opac_dir: $!";
for my $theme ( grep { not /^\.|lib|js|xslt/ } readdir($dh) ) {
push @themes, "$opac_dir/$theme/en";
}
close $dh;
# STAFF themes
my $staff_dir = 'koha-tmpl/intranet-tmpl';
opendir ( $dh, $staff_dir ) or die "can't opendir $staff_dir: $!";
for my $theme ( grep { not /^\.|lib|js/ } readdir($dh) ) {
push @themes, "$staff_dir/$theme/en";
}
close $dh;
my $checkers = [
{
description => 'TT syntax: not using TT directive within HTML tag',
check => sub {
my ($self, $name, $token) = @_;
my $attr = $token->{_attr};
next unless $attr;
push @{$self->{errors}->{$name}}, $token->{_lc} if $attr->{'[%'} or $attr->{'[%-'};
},
errors => {},
},
{
description => '<body> tag with id and class attributes',
check => sub {
my ($self, $name, $token) = @_;
return if $name =~ /bodytag\.inc/;
my $tag = $token->{_string};
push @{$self->{errors}->{$name}}, $token->{_lc}
if $tag =~ /^<body/ &&
($tag !~ /id=".+"/ || $tag !~ /class=".+"/);
},
errors => {},
},
];
find( sub {
my $dir = getcwd();
return if $dir =~ /blib/;
return unless /\.(tt|inc)$/;
($dir) = $dir =~ /koha-tmpl\/(.*)$/;
my $name = $_;
my $parser = C4::TTParser->new;
$parser->build_tokens( $name );
while ( my $token = $parser->next_token ) {
my $attr = $token->{_attr};
next unless $attr;
for my $checker (@$checkers) {
$checker->{check}->($checker, "$dir/$name", $token);
}
}
}, @themes
);
for my $check (@$checkers) {
my @files = sort keys %{$check->{errors}};
ok( !@files, $check->{description} )
or diag(
"Files list: \n",
join( "\n", map { "$_: " . join(', ', @{$check->{errors}->{$_}})
} @files )
);
}
my $testtoken = 0;
my $ttparser = C4::TTParser->new();
$ttparser->unshift_token($testtoken);
my $testtokenagain = C4::TTParser::next_token();
is( $testtoken, $testtokenagain, "Token received same as original put on stack");
=head1 NAME
tt_valid.t
=head1 DESCRIPTION
This test validate Template Toolkit (TT) Koha files.
For the time being, two validations are done:
[1] Test if TT files contain TT directive within HTML tag. For example:
<li[% IF
This kind of construction MUST be avoided because it breaks Koha translation
process.
[2] Test tag <body> tags have both attibutes 'id' and 'class'
=head1 USAGE
From Koha root directory:
prove -v xt/tt_valid.t
=cut