Owen Leonard
987874f4d8
If you try to save an SQL report with an invalid authorized value placeholder you will be presented with a confirmation dialog. This patch updates it to use Font Awesome icons. Also fixed: Validation error found in testing: Duplicated <form> tag and series of redundant inputs. Each input cut had an exact duplicate in the same form. To test, apply the patch and go to Reports -> Create from SQL. - Create a new SQL report and fill in as many fields as possible to verify correct operation. - Try to save your report with an invalid authorized value placeholder, for example: SELECT * FROM items WHERE items.itype = <<foo|bar>> - Confirm that the confirmation dialog is styled correctly. - Test the operation of the "Edit SQL" button. You should be sent back a page. - Test the operation of the "Save anyway" button and confirm that your report was saved. - Repeat these steps when editing an existing report. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com |
||
|---|---|---|
| .. | ||
| acquisitions_stats.tt | ||
| bor_issues_top.tt | ||
| borrowers_out.tt | ||
| borrowers_stats.tt | ||
| cat_issues_top.tt | ||
| catalogue_out.tt | ||
| catalogue_stats.tt | ||
| dictionary.tt | ||
| guided_reports_start.tt | ||
| issues_avg_stats.tt | ||
| issues_by_borrower_category.tt | ||
| issues_stats.tt | ||
| itemslost.tt | ||
| itemtypes.tt | ||
| reports-home.tt | ||
| reserves_stats.tt | ||
| serials_stats.tt | ||
| stats_screen.tt | ||