Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Alex Buckley 66f1605c59 Bug 21754: Automatically clean up outstanding transfers on lost items 
This is an alternative to bug 21732 as transfers are automatically cancelled on marking an item lost, and the items holding rbanch is set to the transfers source ('from') branch.

When an item is marked as lost, the routine should also clean up any
outstanding transfers.

Also added tests to t/db_dependent/Circulation.t which check:
* If transfer is automatically deleted when item is marked as lost
* If the items holdingbranch automatically changes when item with
transfers on it is marked as lost.

Test plan:
1. Find a item which is in transfer, i.e. find an item with the text in
the 'Status' field of the table in detail.pl that indicates it is in
transfer
2. Set the item to 'Lost' either by clicking on Edit->Edit items from
the detail.pl page
OR
clicking on the Items tab on the left side of the detail.pl page
3. Notice that the transfer is now cancelled for the item and the items
holdingbranch is the transfers source ('from') branch
4. Run t/db_dependent/Circulation.t

Sponsored-by: Brimbank Library, Australia
Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>
(fixed the introduction of a whitespace line and removed a double
declare warning from the new tests as part of QA)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-12-26 20:47:08 +00:00
..
Acquisition Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
api/v1 Bug 21835: (QA follow-up) Fix failing test 2018-11-16 17:29:30 +00:00
Auth
Authority
Biblio
Circulation Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
CourseReserves Bug 10382: Course reserves: handle empty values 2018-10-15 12:44:50 +00:00
Creators Bug 21281: (QA follow-up) Introduce _add_backtics 2018-09-26 15:22:57 +00:00
data Bug 21749: (QA follow-up) Add more tests for ImportFramework 2018-11-15 12:47:36 +00:00
Exporter Bug 20486: Add --marc_conditions option to export_records.pl 2018-11-08 02:23:29 +00:00
Holds Bug 21597: Incorrect date value: '0' for column 'onloan' 2018-10-18 14:18:00 +00:00
Illrequest Bug 20996: (follow-up) Fix test 2018-11-05 14:40:55 +00:00
Items Bug 21413: (QA follow-up) Fix tests 2018-11-09 11:06:22 -03:00
Koha Bug 21065: Add tests 2018-12-19 16:07:47 +00:00
Labels Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
LDAP
Letters Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Members Bug 21360: Prevent IssueSlip.t to fail when run at 23:59 2018-09-15 23:59:17 +00:00
OAI Bug 20665: Units tests for testing MySQL connection time zone 2018-05-03 12:46:55 -03:00
Patron Bug 21133: Fix use statements order 2018-07-31 16:28:02 -03:00
Record Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Reports Bug 20495: Remove get_saved_report 2018-07-02 12:06:54 +00:00
Reserves Bug 15524: (QA follow-up) Change Can[Book|Item]BeReserved to return hashref, pass limit to template 2018-08-24 16:27:27 +00:00
Search Bug 21087: Hash passwords in ->update_password 2018-07-30 14:58:06 -03:00
selenium Bug 21956: (bug 21775 follow-up) Use set_preference to reset the value 2018-12-19 16:32:01 +00:00
Serials Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
SIP
Template/Plugin Bug 7534: Use search parameters for Koha::Template::Plugin::Branches->all 2018-09-06 17:27:05 +00:00
Utils Bug 20287: Use DBIC transaction instead of AutoCommit=0 2018-07-18 15:49:49 +00:00
www Bug 18316: (follow-up) Don't let 'fields' be undef and adjust tests 2018-11-08 02:18:45 +00:00
XSLT_Handler
00-strict.t Bug 19817: Remove local help files + edit help feature 2018-09-06 17:32:27 +00:00
01-test_dbic.t
Accounts.t Bug 18677: Remove new issue_id param from charlostitem 2018-11-16 12:43:11 +00:00
Acquisition.t Bug 21467: Prevent tests to fail 2018-11-13 19:31:11 +00:00
AdditionalField.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Amazon.t
ArticleRequests.t Bug 17530: (QA follow-up) Add pref ArticleRequestsLinkControl 2018-09-07 13:16:10 +00:00
AudioAlerts.t
Auth.t Bug 21911: Regression test 2018-12-11 19:12:39 +00:00
Auth_with_cas.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Auth_with_ldap.t Bug 18947: LDAP - do not assume anonymous bind if no user or password 2018-08-20 14:40:13 +00:00
AuthorisedValues.t
AuthoritiesMarc.t
BackgroundJob.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Barcodes.t
Barcodes_ValueBuilder.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Biblio.t Bug 19349: Store record's creator and last modifier in record 2018-11-08 20:53:27 +00:00
Bookseller.t
Breeding.t Bug 12747: Add extra column in Z3950 search 2018-10-01 13:56:26 +00:00
Budgets.t Bug 21604: Add two trivial test cases 2018-11-02 10:33:01 +00:00
Calendar.t
Charset.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
check_kohastructure.t
check_sysprefs.t
Circulation.t Bug 21754: Automatically clean up outstanding transfers on lost items 2018-12-26 20:47:08 +00:00
Clubs.t
ColumnsSettings.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Context.t
Contract.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
CourseReserves.t Bug 21603: Remove incorrect GROUP BY from C4::CourseReserves 2018-10-26 16:33:14 +00:00
db_structure.t
DecreaseLoanHighHolds.t Bug 21086: Fix wrong mock of DateTime->now 2018-07-19 16:24:57 +00:00
default_search_class.pl
Filter_MARC_ViewPolicy.t
Fines.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
FrameworkPlugin.t
Heading_MARC21.t
Hold.t
Holds.t Bug 15486: Unit tests 2018-10-24 13:24:04 +00:00
HoldsQueue.t Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel 2017-09-12 12:42:58 -03:00
Holidays.t
Illcomments.t Bug 18591: Allow any number of comments on ILLs 2018-10-27 13:15:58 +00:00
Illrequestattributes.t
Illrequests.t Bug 20996: Fix unit tests 2018-11-02 10:33:03 +00:00
ILSDI_Services.t Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
ImportBatch.t Bug 20764: (QA follow-up) Fix path to sample plugins 2018-05-14 12:13:20 -03:00
ImportExportFramework.t Bug 21749: (QA follow-up) Add more tests for ImportFramework 2018-11-15 12:47:36 +00:00
Installer.t Bug 17234: Need to separate KEY and FOREIGN KEY checks 2017-01-12 12:43:10 +00:00
Items.t Bug 21774: Cloned item subfields disappear when editing an item 2018-11-21 13:52:11 +00:00
Items_DelItemCheck.t
KitchenSinkPlugin.kpz Bug 17368: Update KitchenSinkPlugin.kpz 2016-10-21 14:48:53 +00:00
Koha.t
Koha_Authority.t
Koha_Database.t
Koha_ExternalContent_OverDrive.t Bug 21567: Move Koha_ExternalContent_OverDrive.t to db_dependent 2018-11-16 13:04:57 +00:00
Koha_ExternalContent_RecordedBooks.t Bug 17602: RecordedBooks Integration to Koha 2018-10-01 13:56:38 +00:00
Koha_Misc_Files.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Languages.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Letters.t Bug 20356: Add EmailSMSSendDriverFromAddress system preference 2018-11-13 14:36:55 +00:00
LibraryGroups.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Linker_FirstMatch.t
Log.t
MarcModificationTemplates.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Members.t Bug 20287: Test exception DuplicateID for Koha::Patron->store 2018-07-18 15:49:57 +00:00
MungeMarcPrice.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
NewsChannels.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Overdues.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Passwordrecovery.t
PatronLists.t Bug 19524: Share patron lists between staff 2018-07-18 16:49:29 +00:00
Patrons.t
Plugins.t Bug 20968: Rename method get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button 2018-11-02 10:36:03 +00:00
QueryParser.t
Record.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t
Reports.t Bug 5327: Shifting a db dependent test to the right place 2012-02-01 18:15:19 +01:00
Reserves.t Bug 15524: (QA follow-up) Change Can[Book|Item]BeReserved to return hashref, pass limit to template 2018-08-24 16:27:27 +00:00
rollingloans.t Bug 20900: Add CPL test branch in rollingloans.t 2018-07-13 12:05:46 +00:00
RotatingCollections.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Search.t Bug 21962: Unit tests 2018-12-11 19:15:38 +00:00
Serials.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Serials_2.t Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber 2018-07-18 15:49:47 +00:00
Service.t
ShelfBrowser.t Bug 21133: Fix use statements order 2018-07-31 16:28:02 -03:00
Sitemapper.t Bug 21015: Remove unecessary 'use Koha::Schema' statements in t/ 2018-11-08 02:18:48 +00:00
Stats.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
StockRotationItems.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationRotas.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationStages.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
SuggestionEngine_ExplodedTerms.t
Suggestions.t Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber 2018-07-18 15:49:47 +00:00
sysprefs.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Tags.t Bug 12916 - Missing Test to demonstrate warnings. 2014-10-30 00:31:26 -03:00
Templates.t Bug 20727: Move temporary_directory() to C4::Context 2018-06-22 16:10:09 +00:00
TestBuilder.t Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty 2018-01-23 16:05:54 -03:00
Upload.t Bug 19633: Use alphanumeric error codes in upload 2018-08-10 10:10:46 +00:00
UsageStats.t Bug 21226: Remove xISBN services 2018-08-16 13:20:22 +00:00
Virtualshelves.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
XISBN.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
XSLT_Handler.t Bug 20272: Replace error numbers by codes in XSLT_Handler 2018-07-02 12:12:48 +00:00
zebra_config.pl Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00