Koha/recalls/recalls_to_pull.pl
Marcel de Rooy b9ba0e131a Bug 19532: (QA follow-up) Fix few Koha::Recalls->search occurrences
Due to the wantarray change, we should fix this call in list context.
We should either use an iterator now or append as_list.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2022-03-14 22:45:51 -10:00

125 lines
5.2 KiB
Perl
Executable file

#!/usr/bin/perl
# Copyright 2020 Aleisha Amohia <aleisha@catalyst.net.nz>
#
# This file is part of Koha.
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use CGI qw ( -utf8 );
use C4::Auth qw( get_template_and_user );
use C4::Output qw( output_html_with_http_headers );
use Koha::BiblioFrameworks;
my $query = CGI->new;
my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
{
template_name => "recalls/recalls_to_pull.tt",
query => $query,
type => "intranet",
flagsrequired => { recalls => 'manage_recalls' },
debug => 1,
}
);
my $op = $query->param('op') || 'list';
my $recall_id = $query->param('recall_id');
if ( $op eq 'cancel' ) {
my $recall = Koha::Recalls->find( $recall_id );
if ( $recall->in_transit ) {
C4::Items::ModItemTransfer( $recall->item->itemnumber, $recall->item->holdingbranch, $recall->item->homebranch, 'CancelRecall' );
}
$recall->set_cancelled;
$op = 'list';
}
if ( $op eq 'list' ) {
my @recalls = Koha::Recalls->search({ status => [ 'R','O','T' ] })->as_list;
my @pull_list;
my %seen_bib;
foreach my $recall ( @recalls ) {
if ( $seen_bib{$recall->biblionumber} ){
# we've already looked at the recalls on this biblio
next;
} else {
# this is an unseen biblio
$seen_bib{$recall->biblionumber}++;
# get recall data about this biblio
my @this_bib_recalls = Koha::Recalls->search({ biblionumber => $recall->biblionumber, status => [ 'R','O','T' ] }, { order_by => { -asc => 'recalldate' } })->as_list;
my $recalls_count = scalar @this_bib_recalls;
my @unique_patrons = do { my %seen; grep { !$seen{$_->borrowernumber}++ } @this_bib_recalls };
my $patrons_count = scalar @unique_patrons;
my $first_recall = $this_bib_recalls[0];
my $items_count = 0;
my @callnumbers;
my @copynumbers;
my @enumchrons;
my @itemtypes;
my @locations;
my @libraries;
my @items = Koha::Items->search({ biblionumber => $recall->biblionumber });
foreach my $item ( @items ) {
if ( $item->can_be_waiting_recall and !$item->checkout ) {
# if item can be pulled to fulfill recall, collect item data
$items_count++;
push( @callnumbers, $item->itemcallnumber ) if ( $item->itemcallnumber );
push( @copynumbers, $item->copynumber ) if ( $item->copynumber );
push( @enumchrons, $item->enumchron ) if ( $item->enumchron );
push( @itemtypes, $item->effective_itemtype ) if ( $item->effective_itemtype );
push( @locations, $item->location ) if ( $item->location );
push( @libraries, $item->holdingbranch ) if ( $item->holdingbranch );
}
}
if ( $items_count > 0 ) {
# don't push data if there are no items available for this recall
# get unique values
my @unique_callnumbers = do { my %seen; grep { !$seen{$_}++ } @callnumbers };
my @unique_copynumbers = do { my %seen; grep { !$seen{$_}++ } @copynumbers };
my @unique_enumchrons = do { my %seen; grep { !$seen{$_}++ } @enumchrons };
my @unique_itemtypes = do { my %seen; grep { !$seen{$_}++ } @itemtypes };
my @unique_locations = do { my %seen; grep { !$seen{$_}++ } @locations };
my @unique_libraries = do { my %seen; grep { !$seen{$_}++ } @libraries };
push( @pull_list, {
biblio => $recall->biblio,
items_count => $items_count,
recalls_count => $recalls_count,
patrons_count => $patrons_count,
pull_count => $items_count <= $recalls_count ? $items_count : $recalls_count,
first_recall => $first_recall,
callnumbers => \@unique_callnumbers,
copynumbers => \@unique_copynumbers,
enumchrons => \@unique_enumchrons,
itemtypes => \@unique_itemtypes,
locations => \@unique_locations,
libraries => \@unique_libraries,
});
}
}
}
$template->param(
recalls => \@pull_list,
);
}
# Checking if there is a Fast Cataloging Framework
$template->param( fast_cataloging => 1 ) if Koha::BiblioFrameworks->find( 'FA' );
# writing the template
output_html_with_http_headers $query, $cookie, $template->output;