Jonathan Druart
39597b86ae
When creating a new subfield for an authority framework, the checkboxes don't behave as they should. If you click on the 'repeatable', 'mandatory' or 'is url' checkbox's label, the checkbox from the second tab will be checked/unchecked. This is caused by a non-unique id of the input element. I have found this bug when working on the removal of CGI::checkbox in both admin/auth_subfields_structure.pl and admin/marc_subfields_structure.pl scripts. This patch remove the use of CGI::checkbox as well as the generation of html code from these 2 pl scripts (which should be avoided). The code these scripts are now pretty similar. Test plan: Add/modify/remove subfield for a MARC framework and an Authority framework. Use as many field as possible and confirm that the values are correctly inserted/displayed. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
341 lines
18 KiB
Text
341 lines
18 KiB
Text
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Administration › Authority MARC subfield structure</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
<script type="text/javascript">
|
|
//<![CDATA[
|
|
$(document).ready(function() {
|
|
$('#subfieldtabs').tabs();
|
|
});
|
|
//]]>
|
|
</script>
|
|
</head>
|
|
<body id="admin_auth_subfields_structure" class="admin">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'cat-search.inc' %]
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> ›
|
|
<a href="/cgi-bin/koha/admin/authtypes.pl">Authority types</a> ›
|
|
[% IF ( authtypecode ) %]<a href="/cgi-bin/koha/admin/auth_tag_structure.pl?authtypecode=[% authtypecode | uri%]">[% authtypecode |html%] framework</a> ›
|
|
[% ELSE %]<a href="/cgi-bin/koha/admin/auth_tag_structure.pl">Default framework</a> ›
|
|
[% END %]
|
|
[% IF ( else ) %]Authority MARC subfield structure for [% tagfield | html %]
|
|
[% ELSE %]<a href="/cgi-bin/koha/admin/auth_subfields_structure.pl?tagfield=[% tagfield | uri %]&tagsubfield=[% tagsubfield %]&authtypecode=[% authtypecode |uri %]">Authority MARC subfield structure for [% tagfield | html %]</a> ›
|
|
[% END %]
|
|
[% IF ( delete_confirm ) %]Confirm deletion of subfield [% tagsubfield %]?[% END %]
|
|
[% IF ( delete_confirmed ) %]Data deleted[% END %]
|
|
[% IF ( add_form ) %]
|
|
[% IF ( use_heading_flags_p ) %]
|
|
[% IF ( heading_edit_subfields_p ) %]Edit MARC subfields constraints[% END %]
|
|
[% ELSE %][% action %][% END %]
|
|
[% END %]
|
|
</div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
|
|
[% IF ( add_form ) %]
|
|
|
|
<h1>[% IF ( use_heading_flags_p ) %]
|
|
[% IF ( heading_edit_subfields_p ) %]Edit MARC subfields constraints for field [% tagfield | html %] authority [% authtypecode |html%][% END %]
|
|
[% ELSE %][% action %][% END %]</h1>
|
|
<form action="[% script_name %]" name="Aform" method="post">
|
|
<input type="hidden" name="op" value="add_validate" />
|
|
<input type="hidden" name="tagfield" value="[% tagfield | html %]" />
|
|
<input type="hidden" name="authtypecode" value="[% authtypecode | html%]" />
|
|
<fieldset class="action"><input type="submit" class="submit" value="Save changes" /> <a class="cancel" href="/cgi-bin/koha/admin/auth_subfields_structure.pl?tagfield=[% tagfield | uri %]&authtypecode=[% authtypecode |uri %]">Cancel</a></fieldset>
|
|
<div id="subfieldtabs" class="toptabs numbered">
|
|
<ul>
|
|
[% FOREACH loo IN loop %]
|
|
[% IF ( loo.new_subfield ) %]
|
|
<li><a href="#sub[% loo.tagsubfield %]field" title="[% loo.liblibrarian | html_entity %]">New</a></li>
|
|
[% ELSE %]
|
|
<li><a href="#sub[% loo.tagsubfield %]field" title="[% loo.liblibrarian | html_entity %]">
|
|
[% loo.tagsubfield %]
|
|
</a></li>
|
|
[% END %]
|
|
[% END %]
|
|
</ul>
|
|
|
|
[% FOREACH loo IN loop %]
|
|
<div id="sub[% loo.tagsubfield %]field">
|
|
<fieldset class="rows"><ol>
|
|
|
|
[% IF ( loo.new_subfield ) %]
|
|
<li>
|
|
<label for="tagsubfieldinput[% loo.row %]">Subfield code: </label>
|
|
<input type="text" name="tagsubfield" value="[% loo.tagsubfield %]" size="1" id="tagsubfield" maxlength="1" />
|
|
</li>
|
|
[% ELSE %]
|
|
<li>
|
|
<input type="hidden" name="tagsubfield" value="[% loo.tagsubfield %]" />
|
|
</li>
|
|
[% END %]
|
|
<li>
|
|
<label for="repeatable[% loo.row %]">Repeatable: </label>
|
|
[% IF loo.repeatable %]
|
|
<input type="checkbox" id="repeatable[% loo.row %]" name="repeatable[% loo.row %]" checked="checked" value="1" />
|
|
[% ELSE %]
|
|
<input type="checkbox" id="repeatable[% loo.row %]" name="repeatable[% loo.row %]" value="1" />
|
|
[% END %]
|
|
</li>
|
|
<li>
|
|
<label for="mandatory[% loo.row %]">Mandatory: </label>
|
|
[% IF loo.mandatory %]
|
|
<input type="checkbox" id="mandatory[% loo.row %]" name="mandatory[% loo.row %]" checked="checked" value="1" />
|
|
[% ELSE %]
|
|
<input type="checkbox" id="mandatory[% loo.row %]" name="mandatory[% loo.row %]" value="1" />
|
|
[% END %]
|
|
</li>
|
|
<li><label for="liblibrarian[% loo.row %]">Text for librarian: </label><input id="liblibrarian[% loo.row %]" type="text" name="liblibrarian" value="[% loo.liblibrarian | html_entity %]" size="40" maxlength="80" /></li>
|
|
<li><label for="libopac[% loo.row %]">Text for OPAC: </label><input type="text" id="libopac[% loo.row %]" name="libopac" value="[% loo.libopac | html_entity %]" size="40" maxlength="80" /></li>
|
|
<li><label for="tab[% loo.row %]">Managed in tab: </label>
|
|
<select name="tab" size="1" id="tab[% loo.row %]">
|
|
[%- IF ( loo.tab == -1 ) -%]
|
|
<option value="-1" selected="selected">ignore</option>
|
|
[%- ELSE -%]
|
|
<option value="-1">ignore</option>
|
|
[%- END -%]
|
|
[%- FOREACH t IN [ '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10'] -%]
|
|
[%- IF ( loo.tab == t && t.length>0 ) -%]
|
|
<option value="[%- t -%]" selected="selected">[%- t -%]</option>
|
|
[%- ELSIF ( loo.tab == t ) -%]
|
|
<option value="[%- t -%]" selected="selected"> </option>
|
|
[%- ELSE -%]
|
|
<option value="[%- t -%]">[%- t -%]</option>
|
|
[%- END -%]
|
|
[%- END -%]
|
|
</select>
|
|
(ignore means that the subfield does not display in the record editor)
|
|
</li>
|
|
<li>
|
|
<fieldset>
|
|
<legend>Display</legend>
|
|
<ol>
|
|
<li><label for="ohidden[% loo.row %]">Select to display or not:</label>
|
|
<select name="ohidden" size="1" id="ohidden[% loo.row %]">
|
|
[%- IF ( loo.ohidden == 0 ) -%]
|
|
<option value= "0" selected="selected">Show all</option>
|
|
<option value="-5">Hide all</option>
|
|
[%- ELSIF ( loo.ohidden == -5 ) -%]
|
|
<option value= "0">Show all</option>
|
|
<option value="-5" selected="selected">Hide all</option>
|
|
[%- ELSE -%]
|
|
<option value= "0">Show all</option>
|
|
<option value="-5">Hide all</option>
|
|
[%- END -%]
|
|
</select>
|
|
</li>
|
|
</ol>
|
|
</fieldset>
|
|
</li>
|
|
<li>
|
|
<fieldset class="rows">
|
|
<legend>Advanced constraints:</legend>
|
|
<ol>
|
|
<li>
|
|
<label for="isurl[% loo.row %]">Is a URL:</label>
|
|
[% IF loo.isurl %]
|
|
<input type="checkbox" id="isurl[% loo.row %]" name="isurl[% loo.row %]" checked="checked" value="1" />
|
|
[% ELSE %]
|
|
<input type="checkbox" id="isurl[% loo.row %]" name="isurl[% loo.row %]" value="1" />
|
|
[% END %]
|
|
(if checked, it means that the subfield is a URL and can be clicked)
|
|
</li>
|
|
<li>
|
|
<label for="defaultvalue[% loo.row %]">Default value:</label>
|
|
<input type="text" name="defaultvalue" id="defaultvalue[% loo.row %]" value="[% loo.defaultvalue %]" />
|
|
</li>
|
|
</ol>
|
|
</fieldset>
|
|
</li>
|
|
<li>
|
|
<fieldset><legend>Help input</legend>
|
|
<ol>
|
|
<li>
|
|
<label for="kohafield[% loo.row %]">Koha field:</label>
|
|
<select name="kohafield" id="kohafield[% loo.row %]" size="1">
|
|
[%- FOREACH value IN loo.kohafields %]
|
|
[% IF ( value == loo.kohafield && value.length>0 ) -%]
|
|
<option value="[% value %]" selected="selected">[% value %]</option>
|
|
[%- ELSIF ( value == loo.kohafield ) -%]
|
|
<option value="[% value %]" selected="selected"> </option>
|
|
[%- ELSIF ( value.length==0 ) -%]
|
|
<option value="[% value %]"> </option>
|
|
[%- ELSE -%]
|
|
<option value="[% value %]">[% value %]</option>
|
|
[%- END -%]
|
|
[%- END %]
|
|
</select>
|
|
</li>
|
|
<li>
|
|
<label for="authorised_value[% loo.row %]">Authorized value:</label>
|
|
<select name="authorised_value" id="authorised_value[% loo.row %]" size="1">
|
|
[%- FOREACH value IN loo.authorised_values %]
|
|
[% IF ( value == loo.authorised_value && value.length>0 ) -%]
|
|
<option value="[% value %]" selected="selected">[% value %]</option>
|
|
[%- ELSIF ( value == loo.authorised_value ) -%]
|
|
<option value="[% value %]" selected> </option>
|
|
[%- ELSIF ( value.length==0 ) -%]
|
|
<option value="[% value %]"> </option>
|
|
[%- ELSE -%]
|
|
<option value="[% value %]">[% value %]</option>
|
|
[%- END -%]
|
|
[%- END %]
|
|
</select>
|
|
</li>
|
|
<li>
|
|
<label for="frameworkcode[% loo.row %]">Thesaurus:</label>
|
|
<select name="frameworkcode" id="frameworkcode[% loo.row %]" size="1">
|
|
[%- FOREACH value IN loo.frameworkcodes %]
|
|
[% IF ( value == loo.frameworkcode && value.length>0 ) -%]
|
|
<option value="[% value %]" selected="selected">[% value %]</option>
|
|
[%- ELSIF ( value == loo.frameworkcode ) -%]
|
|
<option value="[% value %]" selected="selected"> </option>
|
|
[%- ELSIF ( value.length==0 ) -%]
|
|
<option value="[% value %]"> </option>
|
|
[%- ELSE -%]
|
|
<option value="[% value %]">[% value %]</option>
|
|
[%- END -%]
|
|
[%- END %]
|
|
</select>
|
|
</li>
|
|
<li>
|
|
<label for="value_builder[% loo.row %]">Plugin:</label>
|
|
<select name="value_builder" id="value_builder[% loo.row %]" size="1">
|
|
[%- FOREACH value IN loo.value_builders %]
|
|
[% IF ( value == loo.value_builder && value.length>0 ) -%]
|
|
<option value="[% value %]" selected="selected">[% value %]</option>
|
|
[%- ELSIF ( value == loo.value_builder ) -%]
|
|
<option value="[% value %]" selected="selected"> </option>
|
|
[%- ELSIF ( value.length==0 ) -%]
|
|
<option value="[% value %]"> </option>
|
|
[%- ELSE -%]
|
|
<option value="[% value %]">[% value %]</option>
|
|
[%- END -%]
|
|
[%- END %]
|
|
</select>
|
|
</li>
|
|
</ol>
|
|
</fieldset>
|
|
</li>
|
|
</ol></fieldset><br class="clear" />
|
|
</div>
|
|
[% END %]
|
|
</div>
|
|
</form>
|
|
[% END %]
|
|
|
|
[% IF ( delete_confirm ) %]
|
|
|
|
<div class="dialog alert">
|
|
<h3>Delete subfield <span class="ex">'[% tagsubfield %]'?</span></h3>
|
|
<form action="[% delete_link %]" method="post">
|
|
<input type="hidden" name="op" value="delete_confirmed" />
|
|
<table>
|
|
<tr><th scope="row">Subfield:</th> <td>[% tagsubfield %]</td></tr>
|
|
<tr><th scope="row">Description:</th> <td>[% liblibrarian | html_entity %]</td></tr>
|
|
</table>
|
|
<input type="hidden" name="searchfield" value="[% searchfield %]" />
|
|
<input type="hidden" name="tagfield" value="[% tagfield%]" />
|
|
<input type="hidden" name="tagsubfield" value="[% tagsubfield | html %]" />
|
|
<input type="hidden" name="authtypecode" value="[% authtypecode | html %]" />
|
|
<button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> Yes, delete this subfield</button>
|
|
</form>
|
|
|
|
<form action="[% delete_link %]" method="get">
|
|
<input type="hidden" name="searchfield" value="[% searchfield %]" />
|
|
<input type="hidden" name="tagfield" value="[% tagfield | html %]" />
|
|
<input type="hidden" name="tagsubfield" value="[% tagsubfield %]" />
|
|
<input type="hidden" name="authtypecode" value="[% authtypecode |html %]" />
|
|
<button type="submit" class="deny"><i class="fa fa-fw fa-remove"></i> No, do not delete</button>
|
|
</form>
|
|
</form></div>
|
|
[% END %]
|
|
|
|
[% IF ( delete_confirmed ) %]
|
|
|
|
<div class="dialog message"> <h3>Data deleted</h3>
|
|
<form action="[% script_name %]" method="post">
|
|
<input type="hidden" name="tagfield" value="[% tagfield | html %]" />
|
|
<input type="submit" class="approve" value="OK" />
|
|
</form></div>
|
|
[% END %]
|
|
|
|
|
|
[% IF ( else ) %]
|
|
<h1>Authority MARC subfield structure admin for [% tagfield | html %] (authority: [% authtypecode | html%])</h1>
|
|
<p>This screen shows the subfields associated with the selected tag. You can edit subfields or add a new one by clicking on edit.</p>
|
|
<p>The column 'Koha field' shows that the subfield is linked with a Koha field.</p>
|
|
|
|
<table>
|
|
<tr>
|
|
<th>Subfield</th>
|
|
<th>Text</th>
|
|
<th>Constraints</th>
|
|
<th>Delete</th>
|
|
</tr>
|
|
[% FOREACH loo IN loop %]
|
|
<tr>
|
|
<td>[% loo.tagsubfield %]</td>
|
|
<td>
|
|
[% IF ( loo.subfield_ignored ) %]
|
|
<i>[% loo.liblibrarian | html_entity %]</i>
|
|
[% ELSE %]
|
|
[% loo.liblibrarian | html_entity %]
|
|
[% END %]
|
|
</td>
|
|
<td>
|
|
[% IF ( loo.subfield_ignored ) %]
|
|
<i>subfield ignored</i>
|
|
[% ELSE %]
|
|
<strong>Tab:</strong>[% loo.tab %],
|
|
[% IF ( loo.kohafield ) %] | <strong>Koha field:</strong> [% loo.kohafield %], [% END %]
|
|
[% IF ( loo.repeatable ) %]Repeatable, [% ELSE %]Not repeatable,
|
|
[% END %]
|
|
[% IF ( loo.mandatory ) %]Mandatory, [% ELSE %]Not mandatory,
|
|
[% END %]
|
|
[% IF ( loo.hidden ) %]hidden,
|
|
[% END %]
|
|
[% IF ( loo.isurl ) %]is a url,
|
|
[% END %]
|
|
[% IF ( loo.authorised_value ) %] | <strong>Auth value:</strong>[% loo.authorised_value %],
|
|
[% END %]
|
|
[% IF ( loo.frameworkcode ) %] | <strong>Authority:</strong>[% loo.frameworkcode %],
|
|
[% END %]
|
|
[% IF ( loo.value_builder ) %] | <strong>Plugin:</strong>[% loo.value_builder %],[% END %]
|
|
[% END %]
|
|
</td>
|
|
<td><a href="[% loo.delete %]">Delete</a></td>
|
|
</tr>
|
|
[% END %]
|
|
</table>
|
|
|
|
<form action="[% script_name %]" method="get">
|
|
<fieldset class="action"><input type="hidden" name="op" value="add_form" />
|
|
<input type="hidden" name="tagfield" value="[% edit_tagfield %]" />
|
|
<input type="hidden" name="authtypecode" value="[% edit_authtypecode %]" />
|
|
<input type="submit" value="Edit subfields" />
|
|
<a class="cancel" href="auth_tag_structure.pl?searchfield=[% tagfield | uri%]&authtypecode=[% authtypecode | uri %]">Cancel</a></fieldset>
|
|
</form>
|
|
|
|
[% IF ( previous ) %]
|
|
<input type="image" src="[% interface %]/[% theme %]/images/1leftarrow.png" title="previous" alt="previous" border="0" />
|
|
</a>
|
|
[% END %]
|
|
[% IF ( next ) %]
|
|
[% next %]
|
|
<input type="image" src="[% interface %]/[% theme %]/images/1rightarrow.png" title="next" alt="next" border="0" />
|
|
</a>
|
|
[% END %]
|
|
|
|
[% END %]
|
|
|
|
</div>
|
|
</div>
|
|
<div class="yui-b">
|
|
[% INCLUDE 'admin-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|