57608fdecb
This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Follow-up: - Added 3 tests in t/db_dependent/Circulation_Branches.t to test AddReturn policies - Removed HomeOrHoldingBranchReturn from sysprefs.sql - Added notice on removing syspref in updatedatabase QA edits: - removed trailing whitespace in tests - moved branchname lookup from returns.pl to template Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> |
||
---|---|---|
.. | ||
preferences | ||
admin-home.tt | ||
aqbudgetperiods.tt | ||
aqbudgets.tt | ||
aqcontract.tt | ||
aqplan.tt | ||
auth_subfields_structure.tt | ||
auth_tag_structure.tt | ||
authorised_values.tt | ||
authtypes.tt | ||
biblio_framework.tt | ||
branch_transfer_limits.tt | ||
branches.tt | ||
categorie.tt | ||
checkmarc.tt | ||
cities.tt | ||
classsources.tt | ||
clone-rules.tt | ||
columns_settings.tt | ||
currency.tt | ||
didyoumean.tt | ||
fieldmapping.tt | ||
item_circulation_alerts.tt | ||
items_search_field.tt | ||
items_search_fields.tt | ||
itemtypes.tt | ||
koha2marclinks.tt | ||
marc_subfields_structure.tt | ||
marctagstructure.tt | ||
matching-rules.tt | ||
oai_set_mappings.tt | ||
oai_sets.tt | ||
patron-attr-types.tt | ||
preferences.tt | ||
printers.tt | ||
smart-rules.tt | ||
sru_modmapping.tt | ||
stopwords.tt | ||
systempreferences.tt | ||
transport-cost-matrix.tt | ||
z3950servers.tt |