6973e3b7d5
This patch consolidates the code for constructing the parameters for GetBorrowersToExpunge() into a subroutine. As a side-effect, this fixes a regression introduced by the main patch where no patrons would be deleted when filtering by expiration date. To test: [1] Follow the test plan in the main patch. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
189 lines
6 KiB
Perl
Executable file
189 lines
6 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 2 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along with
|
|
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
|
|
# Suite 330, Boston, MA 02111-1307 USA
|
|
#
|
|
# Written by Antoine Farnault antoine@koha-fr.org on Nov. 2006.
|
|
|
|
=head1 cleanborrowers.pl
|
|
|
|
This script allows to do 2 things.
|
|
|
|
=over 2
|
|
|
|
=item * Anonymise the borrowers' issues if issue is older than a given date. see C<datefilter1>.
|
|
|
|
=item * Delete the borrowers who has not borrowered since a given date. see C<datefilter2>.
|
|
|
|
=back
|
|
|
|
=cut
|
|
|
|
use strict;
|
|
|
|
#use warnings; FIXME - Bug 2505
|
|
use CGI;
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
use C4::Members; # GetBorrowersWhoHavexxxBorrowed.
|
|
use C4::Circulation; # AnonymiseIssueHistory.
|
|
use C4::VirtualShelves (); #no import
|
|
use Koha::DateUtils qw( dt_from_string output_pref );
|
|
use Date::Calc qw/Today Add_Delta_YM/;
|
|
|
|
my $cgi = new CGI;
|
|
|
|
# Fetch the paramater list as a hash in scalar context:
|
|
# * returns paramater list as tied hash ref
|
|
# * we can edit the values by changing the key
|
|
# * multivalued CGI paramaters are returned as a packaged string separated by "\0" (null)
|
|
my $params = $cgi->Vars;
|
|
|
|
my $step = $params->{step} || 1;
|
|
my $not_borrowered_since = # the date which filter on issue history.
|
|
$params->{not_borrowered_since}
|
|
? dt_from_string $params->{not_borrowered_since}
|
|
: undef;
|
|
my $last_issue_date = # the date which filter on borrowers last issue.
|
|
$params->{last_issue_date}
|
|
? dt_from_string $params->{last_issue_date}
|
|
: undef;
|
|
my $borrower_dateexpiry =
|
|
$params->{borrower_dateexpiry}
|
|
? dt_from_string $params->{borrower_dateexpiry}
|
|
: undef;
|
|
|
|
my $borrower_categorycode = $params->{'borrower_categorycode'} || q{};
|
|
|
|
# getting the template
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{ template_name => "tools/cleanborrowers.tmpl",
|
|
query => $cgi,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { tools => 'delete_anonymize_patrons', catalogue => 1 },
|
|
}
|
|
);
|
|
|
|
if ( $step == 2 ) {
|
|
|
|
my %checkboxes = map { $_ => 1 } split /\0/, $params->{'checkbox'};
|
|
|
|
my $totalDel;
|
|
my $membersToDelete;
|
|
if ( $checkboxes{borrower} ) {
|
|
$membersToDelete = GetBorrowersToExpunge(
|
|
_get_selection_params($not_borrowered_since, $borrower_dateexpiry, $borrower_categorycode)
|
|
);
|
|
_skip_borrowers_with_nonzero_balance( $membersToDelete );
|
|
$totalDel = scalar @$membersToDelete;
|
|
|
|
}
|
|
my $totalAno;
|
|
my $membersToAnonymize;
|
|
if ( $checkboxes{issue} ) {
|
|
$membersToAnonymize = GetBorrowersWithIssuesHistoryOlderThan($last_issue_date);
|
|
$totalAno = scalar @$membersToAnonymize;
|
|
}
|
|
|
|
$template->param(
|
|
totalToDelete => $totalDel,
|
|
totalToAnonymize => $totalAno,
|
|
memberstodelete_list => $membersToDelete,
|
|
memberstoanonymize_list => $membersToAnonymize,
|
|
);
|
|
}
|
|
|
|
elsif ( $step == 3 ) {
|
|
my $do_delete = $params->{'do_delete'};
|
|
my $do_anonym = $params->{'do_anonym'};
|
|
|
|
my ( $totalDel, $totalAno, $radio ) = ( 0, 0, 0 );
|
|
|
|
# delete members
|
|
if ($do_delete) {
|
|
my $membersToDelete = GetBorrowersToExpunge(
|
|
_get_selection_params($not_borrowered_since, $borrower_dateexpiry, $borrower_categorycode)
|
|
);
|
|
_skip_borrowers_with_nonzero_balance( $membersToDelete );
|
|
$totalDel = scalar(@$membersToDelete);
|
|
$radio = $params->{'radio'};
|
|
for ( my $i = 0 ; $i < $totalDel ; $i++ ) {
|
|
$radio eq 'testrun' && last;
|
|
my $borrowernumber = $membersToDelete->[$i]->{'borrowernumber'};
|
|
$radio eq 'trash' && MoveMemberToDeleted( $borrowernumber );
|
|
C4::VirtualShelves::HandleDelBorrower( $borrowernumber );
|
|
DelMember( $borrowernumber );
|
|
}
|
|
$template->param(
|
|
do_delete => '1',
|
|
TotalDel => $totalDel
|
|
);
|
|
}
|
|
|
|
# Anonymising all members
|
|
if ($do_anonym) {
|
|
#FIXME: anonymisation errors are not handled
|
|
($totalAno,my $anonymisation_error) = AnonymiseIssueHistory($last_issue_date);
|
|
$template->param(
|
|
do_anonym => '1',
|
|
);
|
|
}
|
|
|
|
$template->param(
|
|
trash => ( $radio eq "trash" ) ? (1) : (0),
|
|
testrun => ( $radio eq "testrun" ) ? 1: 0,
|
|
);
|
|
}
|
|
|
|
$template->param(
|
|
step => $step,
|
|
not_borrowered_since => $not_borrowered_since,
|
|
borrower_dateexpiry => $borrower_dateexpiry,
|
|
last_issue_date => $last_issue_date,
|
|
borrower_categorycodes => GetBorrowercategoryList(),
|
|
borrower_categorycode => $borrower_categorycode,
|
|
);
|
|
|
|
#writing the template
|
|
output_html_with_http_headers $cgi, $cookie, $template->output;
|
|
|
|
sub _skip_borrowers_with_nonzero_balance {
|
|
my $borrowers = shift;
|
|
my $balance;
|
|
@$borrowers = map {
|
|
(undef, undef, $balance) = GetMemberIssuesAndFines( $_->{borrowernumber} );
|
|
($balance != 0) ? (): ($_);
|
|
} @$borrowers;
|
|
}
|
|
|
|
sub _get_selection_params {
|
|
my ($not_borrowered_since, $borrower_dateexpiry, $borrower_categorycode) = @_;
|
|
|
|
my $params = {};
|
|
$params->{not_borrowered_since} = output_pref({
|
|
dt => $not_borrowered_since,
|
|
dateformat => 'iso',
|
|
dateonly => 1
|
|
}) if $not_borrowered_since;
|
|
$params->{expired_before} = output_pref({
|
|
dt => $borrower_dateexpiry,
|
|
dateformat => 'iso',
|
|
dateonly => 1
|
|
}) if $borrower_dateexpiry;
|
|
$params->{borrower_categorycode} = $borrower_categorycode if $borrower_categorycode;
|
|
|
|
return $params;
|
|
};
|