Koha/acqui
Nick Clemens c3035f7e1b
Bug 35892: Populate order price using GetMarcPrice if no price specified
Previously this happened after the fact, automagically, if no price was included in the order record. We should
rather load the Marc price into the order form if we don't have a price form the '...ToOrder' system preferences

To test:

Setup -- Set systempreferences below

MarcFieldsToOrder:
price: 949$g
quantity: 949$k
budget_code: 949$l
discount: 949$m
sort1: 949$n
sort2: 949$q

MarcItemFieldsToOrder:
homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l

Stage the attached bib-303.marcxml file
Add to basket from the staged file
Note that item prices are populated as '6.50' from 949$g
Cancel
Update MarcFieldsToOrder and map price to "020$c"
Add to basket from the staged file
Note the price is not populated, because 020$c contains a dollar sign
Cancel
Apply patch, restart all
Add to basket from the staged file
Note the price is now correctly populated from fallback to GetMarcPrice

Note: GetMarcPrice does some automatic munging, that's why 020$c on it's own doesn't work - this could be done to fields in MarcFieldsToOrder/MarcItemFieldsToOrder but this would be an enhancement.
This bug simply restores the previous behavious, but does it on the front end and is more obvious to the user

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-03-07 16:36:44 +01:00
..
acqui-home.pl Bug 29287: Add child funds to display of parent funds on acqui home 2022-03-01 22:47:46 -10:00
addorder.pl Bug 34478: Changes for addorder 2024-03-01 10:57:48 +01:00
addorderiso2709.pl Bug 35892: Populate order price using GetMarcPrice if no price specified 2024-03-07 16:36:44 +01:00
ajax-getauthvaluedropbox.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
basket.pl Bug 34478: Manual fix - reopen basket - add cud- - basket.tt 2024-03-01 11:00:23 +01:00
basketgroup.pl Bug 34478: Basket group export CSV option should not check cud-op 2024-03-01 10:59:17 +01:00
basketheader.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
booksellers.pl Bug 33103: Prevent vendors to be displayed several times in the search result 2023-04-20 15:48:42 -03:00
cancelorder.pl Bug 34478: Manual fix - adjust op for acqui/cancelorder 2024-03-01 11:00:17 +01:00
check_budget_total.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
check_uniqueness.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
duplicate_orders.pl Bug 34478: Manual fix - duplicate_orders (cud-select) 2024-03-01 10:56:15 +01:00
edi_ean.pl Bug 34478: Manual fix - edi_ean (cud-ediorder) 2024-03-01 10:56:22 +01:00
edifactmsgs.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
edimsg.pl Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
finishreceive.pl Bug 34022: Adjust items data structure 2023-06-23 09:46:45 -03:00
histsearch.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
invoice-files.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
invoice.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
invoices.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
lateorders-export.pl Bug 15348: trivial code simplification 2022-09-16 10:36:53 -03:00
lateorders.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
moddeliverydate.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
modordernotes.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
neworderempty.pl Bug 34478: Manual fix - Switch to post, update op - neworderempty_duplicate 2024-03-01 10:56:43 +01:00
newordersubscription.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
newordersuggestion.pl Bug 23991: Move SearchSuggestion to Koha::Suggestions 2022-06-27 12:30:28 -03:00
ordered.pl Bug 31631: Optionally use tax-exclusive values for calculating fund values 2023-10-18 15:41:35 -03:00
orderreceive.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
parcel.pl Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
parcels.pl Bug 34478: op =~ ^cud- in pl/pm - Manual parcels.pl 2024-03-01 10:56:32 +01:00
showorder.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
spent.pl Bug 31631: (QA follow-up) Tidy code 2023-10-18 15:41:37 -03:00
supplier.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
transferorder.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
uncertainprice.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
updatesupplier.pl Bug 34478: Changes for acqui/supplier 2024-03-01 10:57:47 +01:00
vendor_issues.pl Bug 34478: Manual fix - acqui/vendor_issues.pl 2024-03-01 10:59:50 +01:00
z3950_search.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00