Tomas Cohen Arazi
e3a98dd05c
This patch removes calls to CGI->param from within the templates (patroncards-errors.inc) and passes error_* variables with the same codes from the controllers to the template instead. This way we can be sure CGI->param is not called in list context. To test, try those pages and see they don't show warnings anymore. Verify that error situations still show the error messages. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
159 lines
6.1 KiB
Perl
Executable file
159 lines
6.1 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
#
|
|
# Copyright 2006 Katipo Communications.
|
|
# Parts Copyright 2009 Foundations Bible College.
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use autouse 'Data::Dumper' => qw(Dumper);
|
|
|
|
use C4::Auth qw( get_template_and_user );
|
|
use C4::Output qw( output_html_with_http_headers );
|
|
use C4::Creators qw( get_card_summary html_table );
|
|
use C4::Patroncards;
|
|
use Koha::Patrons;
|
|
|
|
my $cgi = CGI->new;
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "patroncards/edit-batch.tt",
|
|
query => $cgi,
|
|
type => "intranet",
|
|
flagsrequired => { tools => 'label_creator' },
|
|
}
|
|
);
|
|
|
|
my $err = 0;
|
|
my $duplicate_count = undef;
|
|
my $duplicate_message = undef;
|
|
my $db_rows = {};
|
|
my $batch = undef;
|
|
my $display_columns = [ {_summary => {label => 'Summary', link_field => 0}},
|
|
{borrowernumber => {label => 'Borrower Number', link_field => 0}},
|
|
{_action => {label => 'Actions ', link_field => 0}},
|
|
{select => {label => 'Select', value => '_label_id'}},
|
|
];
|
|
my $op = $cgi->param('op') || 'new';
|
|
my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || 0;
|
|
my $description = $cgi->param('description') || '';
|
|
my ( @label_ids, @item_numbers, @borrower_numbers );
|
|
@label_ids = $cgi->multi_param('label_id') if $cgi->param('label_id');
|
|
@item_numbers = $cgi->multi_param('item_number') if $cgi->param('item_number');
|
|
@borrower_numbers = $cgi->multi_param('borrower_number') if $cgi->param('borrower_number');
|
|
my $errstr = $cgi->param('error') || '';
|
|
my $bor_num_list = $cgi->param('bor_num_list') || undef;
|
|
my $branch_code = C4::Context->userenv->{'branch'};
|
|
|
|
my @errors = ( 'pdferr', 'errnocards', 'errba', 'errpl', 'errpt', 'errlo', 'errtpl', );
|
|
foreach my $param (@errors) {
|
|
my $error = $cgi->param($param) ? 1 : 0;
|
|
$template->param( 'error_' . $param => $error )
|
|
if $error;
|
|
}
|
|
|
|
if ($op eq 'remove') {
|
|
$batch = C4::Patroncards::Batch->retrieve(batch_id => $batch_id);
|
|
foreach my $label_id (@label_ids) {
|
|
$err = $batch->remove_item($label_id);
|
|
}
|
|
if ($err) {
|
|
print $cgi->redirect("edit-batch.pl?op=edit&batch_id=$batch_id&error=403"); # this allows us to avoid problems with the user hitting their refresh button
|
|
exit;
|
|
}
|
|
}
|
|
elsif ($op eq 'delete') {
|
|
$err = C4::Creators::Batch::delete(batch_id => $batch_id, branch_code => $branch_code);
|
|
if ($err) {
|
|
print $cgi->redirect("edit-batch.pl?op=edit&batch_id=$batch_id&error=404");
|
|
exit;
|
|
}
|
|
}
|
|
elsif ($op eq 'add') {
|
|
if ($bor_num_list) {
|
|
my @bor_nums_unchecked = split /\n/, $bor_num_list; # $bor_num_list is effectively passed in as a <cr> separated list
|
|
foreach my $number (@bor_nums_unchecked) {
|
|
$number =~ s/\r$//; # strip any naughty return chars
|
|
if ( Koha::Patrons->find( $number )) { # we must test in case an invalid borrowernumber is passed in; we effectively disgard them atm
|
|
my $borrower_number = $number;
|
|
push @borrower_numbers, $borrower_number;
|
|
}
|
|
}
|
|
}
|
|
if ($batch_id != 0) {$batch = C4::Patroncards::Batch->retrieve(batch_id => $batch_id);}
|
|
if ($batch_id == 0 || $batch == -2) {$batch = C4::Patroncards::Batch->new(branch_code => $branch_code);}
|
|
$template->param( description => $batch->{'description'} );
|
|
if ($branch_code){
|
|
foreach my $borrower_number (@borrower_numbers) {
|
|
$err = $batch->add_item($borrower_number);
|
|
}
|
|
$batch_id = $batch->get_attr('batch_id') if $batch_id == 0; #update batch_id if we added to a new batch
|
|
if ($err) {
|
|
print $cgi->redirect("edit-batch.pl?op=edit&batch_id=$batch_id&error=401");
|
|
exit;
|
|
}
|
|
}
|
|
else {
|
|
print $cgi->redirect("edit-batch.pl?op=edit&batch_id=$batch_id&error=402");
|
|
exit;
|
|
}
|
|
}
|
|
elsif ($op eq 'de_duplicate') {
|
|
$batch = C4::Patroncards::Batch->retrieve(batch_id => $batch_id);
|
|
$duplicate_count = $batch->remove_duplicates();
|
|
$duplicate_message = 1 if $duplicate_count != -1;
|
|
if ($duplicate_count == -1) {
|
|
print $cgi->redirect("edit-batch.pl?op=edit&batch_id=$batch_id&error=405");
|
|
exit;
|
|
}
|
|
}
|
|
elsif ($op eq 'edit') {
|
|
$batch = C4::Patroncards::Batch->retrieve(batch_id => $batch_id);
|
|
$template->param( description => $batch->{'description'} );
|
|
}
|
|
elsif ($op eq 'new') {
|
|
if ($branch_code eq '') {
|
|
warn sprintf('Batch edit interface called with an invalid/non-existent branch code: %s',$branch_code ? $branch_code : 'NULL');
|
|
print $cgi->redirect("manage.pl?card_element=batch&error=203");
|
|
exit;
|
|
}
|
|
$batch = C4::Patroncards::Batch->new(branch_code => $branch_code);
|
|
$batch_id = $batch->get_attr('batch_id');
|
|
}
|
|
else {
|
|
warn sprintf('Batch edit interface called an unsupported operation: %s',$op);
|
|
print $cgi->redirect("manage.pl?card_element=batch&error=202");
|
|
exit;
|
|
}
|
|
|
|
my $items = $batch->get_attr('items');
|
|
$db_rows = get_card_summary(items => $items, batch_id => $batch_id);
|
|
|
|
my $table = html_table($display_columns, $db_rows);
|
|
|
|
$template->param(
|
|
op => $op,
|
|
batch_id => $batch_id,
|
|
table_loop => $table,
|
|
duplicate_message => $duplicate_message,
|
|
duplicate_count => $duplicate_count,
|
|
error => $errstr,
|
|
);
|
|
|
|
output_html_with_http_headers $cgi, $cookie, $template->output;
|