4a3eaf02e2
This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowCheckoutNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave a checkout note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage checkout notes. 13) Go to main intranet page. There should be no message saying 'checkout notes pending'. 14) Go to circulation home page. There should be no link to Checkout notes. 15) Go back to user's permissions and tick circulate->manage checkout notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Checkout notes pending: 2' 17) Go to circulation home page. There should be a link to Checkout notes with a 2 next to it. Click this link 18) Attempt to mark an checkout note as seen. This should update the status of the checkout note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Confirm that buttons at the bottom are only enabled if a checkbox is checked 22) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 23) Confirm the barcode link to the item works as expected. 24) Confirm the cardnumber link to the user works as expected. 25) Confirm all table details show correctly. Sponsored-by: Catalyst IT Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: Remove self-checkout permissions Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
63 lines
1.8 KiB
Perl
Executable file
63 lines
1.8 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Copyright 2017 Aleisha Amohia <aleisha@catalyst.net.nz>
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use JSON qw( to_json );
|
|
use CGI;
|
|
use C4::Service;
|
|
use C4::Auth qw /check_cookie_auth/;
|
|
use C4::Output qw(:DEFAULT :ajax);
|
|
use Koha::Checkouts;
|
|
|
|
=head1 NAME
|
|
|
|
svc/checkout_notes - Web service for managing patron notes set on issues
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
=cut
|
|
|
|
# AJAX requests
|
|
my $is_ajax = is_ajax();
|
|
my $query = new CGI;
|
|
my ( $auth_status, $sessionID ) = check_cookie_auth( $query->cookie('CGISESSID'), { circulate => 'manage_checkout_notes' } );
|
|
if ( $auth_status ne "ok" ) {
|
|
exit 0;
|
|
}
|
|
if ($is_ajax) {
|
|
my $issue_id = $query->param('issue_id');
|
|
my $issue = Koha::Checkouts->find($issue_id);
|
|
my $action = $query->param('action');
|
|
my $status = 'success';
|
|
if ($action eq 'seen'){
|
|
$issue->set({ noteseen => 1 })->store;
|
|
if ( $issue->noteseen != 1 ) {
|
|
$status = 'failure';
|
|
}
|
|
} elsif ($action eq 'notseen'){
|
|
$issue->set({ noteseen => 0 })->store;
|
|
if ( $issue->noteseen != 0 ) {
|
|
$status = 'failure';
|
|
}
|
|
}
|
|
my $json = to_json ( { status => $status } );
|
|
output_with_http_headers $query, undef, $json, 'js';
|
|
exit;
|
|
}
|