Jonathan Druart
0fdc1021d4
C4::Koha::IsAuthorisedValueCategory contains only 2 useful calls, from
C4::Reports::Guided and reports/guided_reports.pl
It can be replaced with
Koha::AuthorisedValues->search({ category => $authorised_value})->count
Test plan:
1/ Create a sql report using an authorised value category, something
like:
SELECT COUNT(*) FROM items where itemlost=<<lost|LOST>>
2/ Execute the report and confirm that everything works fine.
3/ Create a sql report using a nonexistent authorised value categor,
something like:
SELECT COUNT(*) FROM items where itemlost=<<lost|NONEXIST>>
4/ When saving the report, you should get a warning message
"lost: The authorized value category (NONEXIST) you selected does not exist."
5/ Save anyway and execute the report, you should get the same warning
message.
QA:
git grep IsAuthorisedValueCategory
should not return any results
prove t/db_dependent/ReportsGuided.t
should return green
Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as described
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
|
||
|---|---|---|
| .. | ||
| acquisitions_stats.pl | ||
| bor_issues_top.pl | ||
| borrowers_out.pl | ||
| borrowers_stats.pl | ||
| cat_issues_top.pl | ||
| catalogue_out.pl | ||
| catalogue_stats.pl | ||
| dictionary.pl | ||
| guided_reports.pl | ||
| issues_avg_stats.pl | ||
| issues_by_borrower_category.plugin | ||
| issues_stats.pl | ||
| itemslost.pl | ||
| itemtypes.plugin | ||
| manager.pl | ||
| reports-home.pl | ||
| reserves_stats.pl | ||
| serials_stats.pl | ||
| stats.print.pl | ||
| stats.screen.pl | ||