Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/C4
History
Ian Walls 6e497471e3 Bug 7093: placeholds for suggestion table not working in notices 
In parseletter_sth, the suggestions table was defined twice.  The first time (which
is the only definition to get called, as it matches first then exists), defined the
primary search keys as borrowernumber and biblionumber.  This is incorrect; the only
usage of the suggestions table tokens is with suggestionid as the key.  This is defined
further down the if/then chain.

This patch removes the erroneous sth query definition.

To test:

1.  Place a suggestion with a patron account with a configured email you can access
2.  Approve or reject it
3.  Verify the message you receive contains suggestion tokens (like title, author and reason)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Suggestion mails for accepted, rejected and ordered look good now.
I couldn't test the suggestion mail AVAILABLE (bug 7096), but
assuming this would work too.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2011-12-13 16:49:54 +01:00
..
AuthoritiesMarc Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Barcodes Bug 5385 - Fixing an error that crept in with the POD cleanup 2010-11-12 10:38:42 +13:00
Cache Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
ClassSortRoutine Bug 4265: Fix padding of short callnumbers and Bib-1 attribute for sorting 2011-03-29 21:54:12 +13:00
Creators Bug 7215 - changed callnumber PRESET field to itemcallnumber 2011-12-12 17:36:09 +01:00
External Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Form Fix for Bug 6458 - incorrect parsing result in translation processing 2011-09-15 08:38:58 +12:00
Heading Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
ILSDI bug/7285 Use C4::Auth::checkpw instead of checkpw only 2011-12-06 18:58:30 +01:00
Installer Bug 7078: Remove HTML::Template::Pro from Koha perl dependencies list 2011-10-22 09:01:26 +13:00
Labels bug 5653: use itemcallnumber in bib label layouts 2011-06-13 11:15:34 +12:00
Members bug_6253: Unified member Search() 2011-10-19 16:23:02 +13:00
Output
Patroncards fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00
Reports Bug 6755 : Fixing a bug with guided reports 2011-09-27 07:04:02 +13:00
Search Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
SIP Bug 3704: SIP Checkin of not checked out item returns error without reason 2011-09-22 19:39:29 +12:00
tests
VirtualShelves Bug 7073: GetCOinSBiblio should take $record object, not biblionumber 2011-11-24 11:44:02 +01:00
Accounts.pm bug_5533: Slightly improved marking items as lost 2011-10-18 09:01:39 +13:00
Acquisition.pm Bug 7254 Show pending orders from baskets with closedate > 180 days 2011-11-24 15:15:18 +01:00
Auth.pm Bug 6483 - Paging in opac-detail when coming from a search 2011-10-21 04:57:09 +13:00
Auth_cas_servers.yaml.orig Bug 5630 CAS improvements 2011-10-13 10:49:49 +13:00
Auth_with_cas.pm Bug 5630 CAS improvements 2011-10-13 10:49:49 +13:00
Auth_with_ldap.pm Bug 6022: Auth_with_ldap check if categorycode is valid 2011-12-06 19:51:15 +01:00
AuthoritiesMarc.pm 6094 Fixing ModAuthority problems 2011-10-20 11:28:53 +13:00
BackgroundJob.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Barcodes.pm Bug 5681: Fixes leading zeroes in Add Mulpiple Copies 2011-02-03 10:08:50 +13:00
Biblio.pm Bug 7073: GetCOinSBiblio should take $record object, not biblionumber 2011-11-24 11:44:02 +01:00
Bookseller.pm Bug 3388: Restore account number on vendor page 2011-11-25 11:07:11 +01:00
Boolean.pm Bug 5448: Refactor Boolean.pm 2010-12-02 08:51:33 +13:00
Branch.pm Bug 7034: de-nesting C4/Branch.pm 2011-10-19 03:23:31 +13:00
Breeding.pm Fix for Bug 4290 - search for author in repository 2011-03-06 08:22:06 +13:00
Budgets.pm bug_4831: Use unitprice (actual cost) when totalling spent amounts for "All available funds", as in "Already received" 2011-09-22 19:35:40 +12:00
Cache.pm Bug 5363 - Removing unused module (C4::Cache::FastMemcached) 2010-11-04 20:05:36 +13:00
Calendar.pm Fix for Bug 4991, Overhaul of Calendar interface 2010-11-02 15:02:54 +13:00
Category.pm Bug 6989 Patron categories not properly displayed if not pure ASCII 2011-11-04 12:07:08 +01:00
Charset.pm bug 5579 : Fixes several exports to embed items 2011-04-19 22:35:15 +12:00
Circulation.pm bug_5211: LostItem() - added charge_fee param to control fee charging 2011-12-06 11:36:34 +01:00
ClassSortRoutine.pm Bug 7035 de-nesting C4::ClassSource & ClassSortRoutine 2011-10-19 03:25:59 +13:00
ClassSource.pm Bug 7035 de-nesting C4::ClassSource & ClassSortRoutine 2011-10-19 03:25:59 +13:00
Context.pm Bug 6132: preference were case sensitive. 2011-12-06 11:39:37 +01:00
Contract.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Creators.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
Csv.pm
Dates.pm Bug 6908 - increase DEBUG level for *NOISY* Dates.pm init() messages 2011-12-06 20:38:08 +01:00
Debug.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Heading.pm Bug 5415 Let calls of SimpleSearch utilize considtent interface 2011-04-08 13:52:57 +12:00
ImportBatch.pm Bug 5859: Allow user to set encoding for import 2011-04-19 13:05:48 +12:00
ImportExportFramework.pm Bug 6723 : import-framework-crlf 2011-08-26 12:46:52 +12:00
Input.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Installer.pm Bug 6699 follow-up 2011-12-03 07:43:15 +01:00
ItemCirculationAlertPreference.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Items.pm Bug 3385 - Add checkout date and renewal date to display list of checked out items 2011-12-06 19:22:01 +01:00
ItemType.pm Bug 6371 Item Types description not properly displayed if not pure ASCII 2011-10-08 20:10:29 +13:00
Koha.pm Merge remote branch 'kc/new/pending_qa/enh/bug_3644' into kcmaster 2011-04-09 19:16:45 +12:00
Labels.pm
Languages.pm Bug 6755 Web browser default lang != syspref selected langs 2011-09-26 23:26:09 +13:00
Letters.pm Bug 7093: placeholds for suggestion table not working in notices 2011-12-13 16:49:54 +01:00
Log.pm Bug 6460: alternative fix, updating template and script instead of C4::Log 2011-09-24 10:01:09 +12:00
Maintainance.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Matcher.pm Bug 5415 Let calls of SimpleSearch utilize considtent interface 2011-04-08 13:52:57 +12:00
Members.pm Bug 6328 follow-up for QA comments 2011-11-25 14:00:47 +01:00
Message.pm POD Cleanups 2010-06-09 08:38:59 -04:00
NewsChannels.pm
Output.pm Bug 2616: Remove unnecessary 'use HTML::Template' calls 2011-12-06 11:34:05 +01:00
Overdues.pm Bug 6987 Make return from Overdues::GetFine consistent 2011-12-08 11:19:10 +01:00
Patroncards.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
Print.pm Bug 7037 de-nesting C4/Print.pm 2011-10-19 03:48:21 +13:00
Record.pm Bug 5453 : Move declarations out of conditionals 2011-07-15 15:50:24 +12:00
Reports.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Reserves.pm Bug 7057: CheckReserves uses GetMemberDetails unnecessarily 2011-10-20 14:03:20 +13:00
Review.pm Bug 7259 - Show a count of items pending approval on staff client home and tools pages 2011-12-08 12:06:41 +01:00
Ris.pm bug 5780 followup: RIS export now includes all URLs 2011-10-14 10:37:31 +13:00
RotatingCollections.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
Scheduler.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Scrubber.pm Bug 5611: Simple typo fix in the comments 2011-01-13 08:17:27 +13:00
Search.pm Bug 6786: Follow up fixing index names with hyphens 2011-12-06 11:46:09 +01:00
Serials.pm Bug 7105: Bad request in GetSubscriptions 2011-12-03 08:21:21 +01:00
Service.pm POD Cleanups 2010-06-09 08:38:59 -04:00
ShelfBrowser.pm Bug 5551 - allow shelf browser filters to be changed 2011-01-21 11:08:42 +13:00
SMS.pm More POD cleanups 2010-06-09 08:38:58 -04:00
SQLHelper.pm Bug 7134: patron records getting corrupted birthdates 2011-11-18 22:59:11 +01:00
Stats.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Suggestions.pm Bug 6893 : Updates suggestions list when adding orders 2011-12-06 20:30:04 +01:00
Tags.pm Bug 7259 - Show a count of items pending approval on staff client home and tools pages 2011-12-08 12:04:28 +01:00
Templates.pm Bug 6629 : Sanitizing input from language cookie 2011-11-25 10:56:04 +01:00
TmplToken.pm Bug 6458 Template Toolkit files test case 2011-08-18 21:11:50 +12:00
TmplTokenType.pm Bug 6458 Template Toolkit files test case 2011-08-18 21:11:50 +12:00
TTParser.pm Bug 6458 Template Toolkit files test case 2011-08-18 21:11:50 +12:00
UploadedFile.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Utils.pm
VirtualShelves.pm Bug 6555 : only 10 lists show in the staff client 2011-09-07 09:00:38 +12:00
XISBN.pm Fix for Bug 5570 - item types not showing on other editions 2011-01-07 14:18:09 +13:00
XSLT.pm Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
Z3950.pm fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00