Koha/Koha/Holds.pm
Jonathan Druart 9d6d641d1f Bug 17600: Standardize our EXPORT_OK
On bug 17591 we discovered that there was something weird going on with
the way we export and use subroutines/modules.
This patch tries to standardize our EXPORT to use EXPORT_OK only.

That way we will need to explicitely define the subroutine we want to
use from a module.

This patch is a squashed version of:
Bug 17600: After export.pl
Bug 17600: After perlimport
Bug 17600: Manual changes
Bug 17600: Other manual changes after second perlimports run
Bug 17600: Fix tests

And a lot of other manual changes.

export.pl is a dirty script that can be found on bug 17600.

"perlimport" is:
git clone https://github.com/oalders/App-perlimports.git
cd App-perlimports/
cpanm --installdeps .
export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib"
find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \;

The ideas of this patch are to:
* use EXPORT_OK instead of EXPORT
* perltidy the EXPORT_OK list
* remove '&' before the subroutine names
* remove some uneeded use statements
* explicitely import the subroutines we need within the controllers or
modules

Note that the private subroutines (starting with _) should not be
exported (and not used from outside of the module except from tests).

EXPORT vs EXPORT_OK (from
https://www.thegeekstuff.com/2010/06/perl-exporter-examples/)
"""
Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members.

@EXPORT and @EXPORT_OK are the two main variables used during export operation.

@EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace.

@EXPORT_OK does export of symbols on demand basis.
"""

If this patch caused a conflict with a patch you wrote prior to its
push:
* Make sure you are not reintroducing a "use" statement that has been
removed
* "$subroutine" is not exported by the C4::$MODULE module
means that you need to add the subroutine to the @EXPORT_OK list
* Bareword "$subroutine" not allowed while "strict subs"
means that you didn't imported the subroutine from the module:
  - use $MODULE qw( $subroutine list );
You can also use the fully qualified namespace: C4::$MODULE::$subroutine

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-07-16 08:58:47 +02:00

177 lines
3.7 KiB
Perl

package Koha::Holds;
# Copyright ByWater Solutions 2014
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Koha::Database;
use Koha::Hold;
use base qw(Koha::Objects);
=head1 NAME
Koha::Holds - Koha Hold object set class
=head1 API
=head2 Class Methods
=cut
=head3 waiting
returns a set of holds that are waiting from an existing set
=cut
sub waiting {
my ( $self ) = @_;
return $self->search( { found => 'W' } );
}
=head3 unfilled
returns a set of holds that are unfilled from an existing set
=cut
sub unfilled {
my ( $self ) = @_;
return $self->search( { found => undef } );
}
=head3 forced_hold_level
If a patron has multiple holds for a single record,
those holds must be either all record level holds,
or they must all be item level holds.
This method should be used with Hold sets where all
Hold objects share the same patron and record.
This method will return 'item' if the patron has
at least one item level hold. It will return 'record'
if the patron has holds but none are item level,
Finally, if the patron has no holds, it will return
undef which indicates the patron may select either
record or item level holds, barring any other rules
that would prevent one or the other.
=cut
sub forced_hold_level {
my ($self) = @_;
my $item_level_count = $self->search( { itemnumber => { '!=' => undef } } )->count();
return 'item' if $item_level_count > 0;
my $record_level_count = $self->search( { itemnumber => undef } )->count();
return 'record' if $record_level_count > 0;
return;
}
=head3 get_items_that_can_fill
my $items = $holds->get_items_that_can_fill();
Return the list of items that can fill the hold set.
Items that are not:
in transit
waiting
lost
widthdrawn
not for loan
not on loan
=cut
sub get_items_that_can_fill {
my ( $self ) = @_;
my @biblionumbers = $self->get_column('biblionumber');
my @branchtransfers = map { $_->itemnumber }
Koha::Item::Transfers->search(
{ datearrived => undef },
{
columns => ['itemnumber'],
collapse => 1,
}
);
my @waiting_holds = map { $_->itemnumber }
Koha::Holds->search(
{ 'found' => 'W' },
{
columns => ['itemnumber'],
collapse => 1,
}
);
my @hold_not_allowed_itypes = Koha::CirculationRules->search(
{
rule_name => 'holdallowed',
branchcode => undef,
categorycode => undef,
rule_value => 'not_allowed',
}
)->get_column('itemtype');
return Koha::Items->search(
{
biblionumber => { in => \@biblionumbers },
itemlost => 0,
withdrawn => 0,
notforloan => 0,
onloan => undef,
itemnumber => { -not_in => [ @branchtransfers, @waiting_holds ] },
itype => { -not_in => \@hold_not_allowed_itypes },
}
);
}
=head3 type
=cut
sub _type {
return 'Reserve';
}
=head3 object_class
=cut
sub object_class {
return 'Koha::Hold';
}
=head1 AUTHOR
Kyle M Hall <kyle@bywatersolutions.com>
=cut
1;