Jonathan Druart
6eade474ed
The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
||
---|---|---|
.. | ||
ILS | ||
Sip | ||
t | ||
acstest.py | ||
example_institution_dump.sh | ||
ILS.pm | ||
ILS.pod | ||
interactive_item_dump.pl | ||
interactive_patron_check_password.pl | ||
interactive_patron_dump.pl | ||
interactive_renew_all_dump.pl | ||
Makefile | ||
README | ||
Sip.pm | ||
SIPServer.pm | ||
test.txt | ||
xmlparse.pl |
README for Open NSIP 3M-SIP Server DEPENDENCIES SIPServer is written entirely in Perl, but it require these CPAN perl modules to run: Net::Server - The SIP server is a Net::Server::Prefork server XML::LibXML XML::Parser XML::Simple - for parsing the config file UNIVERSAL::require - for loading the correct ILS interface module Clone - for running the test cases LOGGING SIPServer uses syslog() for status and debugging messages. All syslog messages are logged using the syslog facility 'local6'. If you need to change this, because something else on your system is already using that facililty, just change the definition of 'LOG_SIP' at the top of the file SIPServer.pm Make sure to update your syslog configuration to capture facility 'local6' and record it.