Jonathan Druart
6eade474ed
The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
101 lines
2.6 KiB
Perl
Executable file
101 lines
2.6 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Move an item from a biblio to another
|
|
#
|
|
# Copyright 2009 BibLibre
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use strict;
|
|
#use warnings; FIXME - Bug 2505
|
|
use CGI qw ( -utf8 );
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
use C4::Biblio;
|
|
use C4::Items;
|
|
use C4::Context;
|
|
use C4::Koha;
|
|
use C4::ClassSource;
|
|
use C4::Acquisition qw/GetOrderFromItemnumber ModOrder GetOrder/;
|
|
|
|
use Date::Calc qw(Today);
|
|
|
|
use MARC::File::XML;
|
|
|
|
use Koha::Items;
|
|
|
|
my $query = CGI->new;
|
|
|
|
# The biblio to move the item to
|
|
my $biblionumber = $query->param('biblionumber');
|
|
|
|
# The barcode of the item to move
|
|
my $barcode = $query->param('barcode');
|
|
|
|
my ($template, $loggedinuser, $cookie) = get_template_and_user(
|
|
{
|
|
template_name => "cataloguing/moveitem.tt",
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { editcatalogue => 'edit_items' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
|
|
|
|
my $biblio = GetBiblioData($biblionumber);
|
|
$template->param(bibliotitle => $biblio->{'title'});
|
|
$template->param(biblionumber => $biblionumber);
|
|
|
|
# If we already have the barcode of the item to move and the biblionumber to move the item to
|
|
if ($barcode && $biblionumber) {
|
|
|
|
my $itemnumber;
|
|
my $item = Koha::Items->find({ barcode => $barcode });
|
|
|
|
if ($item) {
|
|
|
|
$itemnumber = $item->itemnumber;
|
|
my $frombiblionumber = $item->biblionumber;
|
|
|
|
my $moveresult = MoveItemFromBiblio($itemnumber, $frombiblionumber, $biblionumber);
|
|
if ($moveresult) {
|
|
$template->param(success => 1);
|
|
} else {
|
|
$template->param(error => 1,
|
|
errornonewitem => 1);
|
|
}
|
|
|
|
|
|
} else {
|
|
$template->param(error => 1,
|
|
errornoitem => 1);
|
|
}
|
|
$template->param(
|
|
barcode => $barcode,
|
|
itemnumber => $itemnumber,
|
|
);
|
|
|
|
} else {
|
|
$template->param(missingparameter => 1);
|
|
if (!$barcode) { $template->param(missingbarcode => 1); }
|
|
if (!$biblionumber) { $template->param(missingbiblionumber => 1); }
|
|
}
|
|
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|